morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #473] [MERGED] refactor(domain): encode comparison and lifecycle states exactly #2019

New issue

Closed

opened 2026-10-16 21:13:25 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:25 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/473
Author: @morluto
Created: 8/11/2026
Status: ✅ Merged
Merged: 8/11/2026
Merged by: @morluto

Base: main ← Head: agent/encode-domain-states

📝 Commits (7)

c07a7c2 refactor(domain): encode comparison states exactly
f523005 refactor(domain): make evidence lifecycles explicit
715af80 refactor(browser): parse capture states once
8a401fa test: prefer behavior over implementation seams
21fd5e3 chore: refresh schema-derived metadata
33bb8b4 test(process): preserve lifecycle cleanup coverage
2cf98de test(hopper): bind rename cache coverage to dispatch

📊 Changes

43 files changed (+1728 additions, -776 deletions)

View changed files

📝 docs/product-catalog.json (+2 -2)
📝 docs/verification/managed-conformance-manifest.json (+2 -2)
📝 skills/reverse-engineer-anything/SKILL.md (+1 -1)
📝 src/browser/WebSourceMapFetcher.ts (+67 -54)
📝 src/domain/callPath.test.ts (+18 -3)
📝 src/domain/callPath.ts (+118 -152)
➕ src/domain/callPathSchemas.ts (+194 -0)
📝 src/domain/changedBehavior.test.ts (+11 -0)
📝 src/domain/changedBehavior.ts (+68 -24)
📝 src/domain/conformanceReplay.ts (+55 -21)
📝 src/domain/conformanceTrustGate.ts (+22 -12)
📝 src/domain/functionComparison.test.ts (+26 -0)
📝 src/domain/functionComparisonResults.ts (+23 -14)
📝 src/domain/functionComparisonSchemas.ts (+45 -19)
📝 src/domain/investigationWorkspace.ts (+76 -43)
📝 src/domain/javascriptApplicationVersionComparison.ts (+43 -22)
📝 src/domain/javascriptApplicationVersionComparisonSchemas.ts (+191 -74)
📝 src/domain/javascriptApplicationVersionItems.ts (+171 -63)
📝 src/domain/javascriptApplicationVersionKeys.ts (+43 -16)
📝 src/domain/processTraceComparison.test.ts (+7 -0)

...and 23 more files

📄 Description

Description

Replace loosely correlated status, nullable, candidate, coverage, and count fields with boundary-parsed discriminated values across comparison, evidence, lifecycle, and browser-capture workflows. Contradictory states now fail at the owning schema instead of surviving into downstream logic and requiring repeated checks.

The refactor covers:

call-path, changed-behavior, function, and JavaScript application-version comparisons;
conformance replay/trust gates, investigation runs, process traces, reconstruction verification, and reference-source graphs;
web source-map collection and browser capture diffs.

Schema-only concerns are separated from traversal and comparison logic where that gives each concept one owner. Tests assert rejected impossible states and observable lifecycle behavior, including MCP notifications, provider capability mutation resistance, request cleanup, and Hopper rename-cache invalidation.

No tools or provider authorities are added or removed. Storage formats retain their legacy migration branches, the 116-tool inventory remains stable, and valid caller behavior is unchanged. The caller-visible schema projection is narrower only for combinations that contradicted their own status, coverage, evidence, or lifecycle fields.

Suggested review order:

Comparison state owners: c07a7c28.
Evidence and lifecycle owners: f5230054.
Browser source-map and capture boundaries: 715af808.
Behavior-focused test cleanup and lifecycle coverage: 8a401fa4, 33bb8b45, 2cf98dee.
Generated catalog and provenance refresh: 21fd5e3c.

Type of Change

Bug fix
New feature
Documentation update
Performance improvement
Refactoring (valid behavior preserved)
Tool contract change (MCP schema narrowing)

Testing Performed

Unit and boundary tests added or updated
npm run check:pr — typecheck, lint, formatting, Knip, metadata, 338 test files / 1,699 tests, TypeDoc, and generated-document checks passed
Focused post-review lifecycle suites — 53 tests passed
Focused Hopper cache-dispatch suite — 10 tests passed
npm pack --dry-run — 739 files, 1.1 MB package
Pre-push npm run check:fast — typecheck and lint passed
npm run verify:package — reached the packaged Linux Hopper platform check, then stopped because Xvfb is unavailable on this host
Real Hopper, Ghidra, browser, replay, and managed-provider verification performed

Tool Contract Impact

The canonical 116-tool inventory is unchanged. Output schemas now reject mismatched comparison endpoints, invalid match basis/confidence pairs, contradictory coverage and pagination counts, impossible lifecycle checkpoints, inconsistent conformance aggregates, invalid reference-source content states, and source-map/capture statuses that do not match retained evidence.

Generated MCP catalog, product catalog, bundled skill identity, and managed conformance provenance were refreshed and pass the repository drift checks.

Related Issues

No linked issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/473 **Author:** [@morluto](https://github.com/morluto) **Created:** 8/11/2026 **Status:** ✅ Merged **Merged:** 8/11/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/encode-domain-states` --- ### 📝 Commits (7) - [`c07a7c2`](https://github.com/morluto/rea/commit/c07a7c2840b9eec16d69b27aeaabbde73f282349) refactor(domain): encode comparison states exactly - [`f523005`](https://github.com/morluto/rea/commit/f523005454abdbd391f03ef80b1132c57c4bc1f8) refactor(domain): make evidence lifecycles explicit - [`715af80`](https://github.com/morluto/rea/commit/715af808fd486cd00c07f706a86f878f543c72e5) refactor(browser): parse capture states once - [`8a401fa`](https://github.com/morluto/rea/commit/8a401fa41e874a3f0cd9e3a0c0eb1aa9e99ab194) test: prefer behavior over implementation seams - [`21fd5e3`](https://github.com/morluto/rea/commit/21fd5e3c385ba48db4921bcfece4e23eb506b6a2) chore: refresh schema-derived metadata - [`33bb8b4`](https://github.com/morluto/rea/commit/33bb8b45a720b3d7e84b97d49e175f74cfc5ece7) test(process): preserve lifecycle cleanup coverage - [`2cf98de`](https://github.com/morluto/rea/commit/2cf98deec03f99295aca2e4fcaae0e2b0f73c11e) test(hopper): bind rename cache coverage to dispatch ### 📊 Changes **43 files changed** (+1728 additions, -776 deletions) <details> <summary>View changed files</summary> 📝 `docs/product-catalog.json` (+2 -2) 📝 `docs/verification/managed-conformance-manifest.json` (+2 -2) 📝 `skills/reverse-engineer-anything/SKILL.md` (+1 -1) 📝 `src/browser/WebSourceMapFetcher.ts` (+67 -54) 📝 `src/domain/callPath.test.ts` (+18 -3) 📝 `src/domain/callPath.ts` (+118 -152) ➕ `src/domain/callPathSchemas.ts` (+194 -0) 📝 `src/domain/changedBehavior.test.ts` (+11 -0) 📝 `src/domain/changedBehavior.ts` (+68 -24) 📝 `src/domain/conformanceReplay.ts` (+55 -21) 📝 `src/domain/conformanceTrustGate.ts` (+22 -12) 📝 `src/domain/functionComparison.test.ts` (+26 -0) 📝 `src/domain/functionComparisonResults.ts` (+23 -14) 📝 `src/domain/functionComparisonSchemas.ts` (+45 -19) 📝 `src/domain/investigationWorkspace.ts` (+76 -43) 📝 `src/domain/javascriptApplicationVersionComparison.ts` (+43 -22) 📝 `src/domain/javascriptApplicationVersionComparisonSchemas.ts` (+191 -74) 📝 `src/domain/javascriptApplicationVersionItems.ts` (+171 -63) 📝 `src/domain/javascriptApplicationVersionKeys.ts` (+43 -16) 📝 `src/domain/processTraceComparison.test.ts` (+7 -0) _...and 23 more files_ </details> ### 📄 Description ## Description Replace loosely correlated status, nullable, candidate, coverage, and count fields with boundary-parsed discriminated values across comparison, evidence, lifecycle, and browser-capture workflows. Contradictory states now fail at the owning schema instead of surviving into downstream logic and requiring repeated checks. The refactor covers: - call-path, changed-behavior, function, and JavaScript application-version comparisons; - conformance replay/trust gates, investigation runs, process traces, reconstruction verification, and reference-source graphs; - web source-map collection and browser capture diffs. Schema-only concerns are separated from traversal and comparison logic where that gives each concept one owner. Tests assert rejected impossible states and observable lifecycle behavior, including MCP notifications, provider capability mutation resistance, request cleanup, and Hopper rename-cache invalidation. No tools or provider authorities are added or removed. Storage formats retain their legacy migration branches, the 116-tool inventory remains stable, and valid caller behavior is unchanged. The caller-visible schema projection is narrower only for combinations that contradicted their own status, coverage, evidence, or lifecycle fields. Suggested review order: 1. Comparison state owners: `c07a7c28`. 2. Evidence and lifecycle owners: `f5230054`. 3. Browser source-map and capture boundaries: `715af808`. 4. Behavior-focused test cleanup and lifecycle coverage: `8a401fa4`, `33bb8b45`, `2cf98dee`. 5. Generated catalog and provenance refresh: `21fd5e3c`. ## Type of Change - [ ] Bug fix - [ ] New feature - [ ] Documentation update - [ ] Performance improvement - [x] Refactoring (valid behavior preserved) - [x] Tool contract change (MCP schema narrowing) ## Testing Performed - [x] Unit and boundary tests added or updated - [x] `npm run check:pr` — typecheck, lint, formatting, Knip, metadata, 338 test files / 1,699 tests, TypeDoc, and generated-document checks passed - [x] Focused post-review lifecycle suites — 53 tests passed - [x] Focused Hopper cache-dispatch suite — 10 tests passed - [x] `npm pack --dry-run` — 739 files, 1.1 MB package - [x] Pre-push `npm run check:fast` — typecheck and lint passed - [ ] `npm run verify:package` — reached the packaged Linux Hopper platform check, then stopped because Xvfb is unavailable on this host - [ ] Real Hopper, Ghidra, browser, replay, and managed-provider verification performed ## Tool Contract Impact The canonical 116-tool inventory is unchanged. Output schemas now reject mismatched comparison endpoints, invalid match basis/confidence pairs, contradictory coverage and pagination counts, impossible lifecycle checkpoints, inconsistent conformance aggregates, invalid reference-source content states, and source-map/capture statuses that do not match retained evidence. Generated MCP catalog, product catalog, bundled skill identity, and managed conformance provenance were refreshed and pass the repository drift checks. ## Related Issues No linked issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:25 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:47:43 +00:00

[GH-ISSUE #6870] Advertise a stable family for each tool in tools/list metadata, and document that DeepSeek Harness does not lazy-load #4208

bsakaguchi referenced this issue

2026-10-31 00:57:34 +00:00

[PR #2029] [MERGED] docs(install): explain Claude Code upfront tool loading on third-party endpoints #4973

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2019

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns