[PR #510] [MERGED] fix(javascript): bind named class expressions in their class scope #2036

New issue

Closed

opened 2026-10-16 21:13:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/510
Author: @rudycelekli
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: fix/named-class-expression-bindings-20261004

📝 Commits (2)

49cba8b fix(javascript): bind named class expressions in their class scope
b711a49 test(javascript): isolate class expression lexical names regression cases

📊 Changes

2 files changed (+54 additions, -0 deletions)

View changed files

📝 src/domain/javascriptSemanticAnalysis.structure.test.ts (+44 -0)
📝 src/domain/javascriptSemanticAnalysis.ts (+10 -0)

📄 Description

Change

Register the existing named class expression in its class scope. Internal self-references no longer resolve the unrelated same-named enclosing binding or appear unbound; the inner name remains unavailable outside the class. Preserve class declaration/name visibility. Public native source analyzer, no module mocks.

Reproduction and verification

26 tests PASS; before2FAIL4PASS

npm run check:pr: passed (Test Files 352 passed (352); Tests 1800 passed | 2 skipped (1802)).
npm run check:ci: passed.
npm run verify:package: passed installed-tarball CLI/MCP verification, including optional-dependency degradation.
npm pack --dry-run: passed.
Exact lockfile installation on Node 24.18.0 and npm 11.16.0.

These tests exercise the production seams described above. No real Hopper, Ghidra, desktop browser or Linux sandbox end-to-end verification is claimed.

Prepared with AI assistance; the reproductions and verification commands above were executed locally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/510 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/named-class-expression-bindings-20261004` --- ### 📝 Commits (2) - [`49cba8b`](https://github.com/morluto/rea/commit/49cba8b015f63045fdbeb5e9d016b2a076f007cf) fix(javascript): bind named class expressions in their class scope - [`b711a49`](https://github.com/morluto/rea/commit/b711a490fa9fc9880d6d43d458c32b474b7d19e3) test(javascript): isolate class expression lexical names regression cases ### 📊 Changes **2 files changed** (+54 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascriptSemanticAnalysis.structure.test.ts` (+44 -0) 📝 `src/domain/javascriptSemanticAnalysis.ts` (+10 -0) </details> ### 📄 Description ## Change Register the existing named class expression in its class scope. Internal self-references no longer resolve the unrelated same-named enclosing binding or appear unbound; the inner name remains unavailable outside the class. Preserve class declaration/name visibility. Public native source analyzer, no module mocks. ## Reproduction and verification 26 tests PASS; before2FAIL4PASS - `npm run check:pr`: passed (Test Files 352 passed (352); Tests 1800 passed | 2 skipped (1802)). - `npm run check:ci`: passed. - `npm run verify:package`: passed installed-tarball CLI/MCP verification, including optional-dependency degradation. - `npm pack --dry-run`: passed. - Exact lockfile installation on Node 24.18.0 and npm 11.16.0. These tests exercise the production seams described above. No real Hopper, Ghidra, desktop browser or Linux sandbox end-to-end verification is claimed. Prepared with AI assistance; the reproductions and verification commands above were executed locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:35 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:57:37 +00:00

[PR #2036] [CLOSED] fix(process): name CS_RESTRICT environment withholding in ownership diagnostics #4977

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2036

No description provided.

Rows
Columns