[PR #513] [MERGED] fix(web): retain uncertainty for incomplete capture inventories #2039

New issue

Closed

opened 2026-10-16 21:13:37 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/513
Author: @rudycelekli
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: fix/capture-incomplete-absence-20261004

📝 Commits (2)

8be1b0c fix(web): retain uncertainty for incomplete capture inventories
cd35de6 test(web): keep incomplete capture cases in a focused suite

📊 Changes

2 files changed (+62 additions, -1 deletions)

View changed files

📝 src/domain/webCaptureDiff.ts (+3 -1)
📝 tests/boundary/browser/webCaptureDiff.test.ts (+59 -0)

📄 Description

Change

Do not assert script/resource/network/WebMCP added or removed identities when either section is incomplete. Preserve observed shared-identity modifications. Tests use production CdpBrowserProvider against an owned fake CDP socket, not a real browser. Existing deliberate removal fixture now explicitly marks its script inventory complete.

Reproduction and verification

8 tests PASS; before2FAIL6PASS

npm run check:pr: passed (Test Files 352 passed (352); Tests 1800 passed | 2 skipped (1802)).
npm run check:ci: passed.
npm run verify:package: passed installed-tarball CLI/MCP verification, including optional-dependency degradation.
npm pack --dry-run: passed.
Exact lockfile installation on Node 24.18.0 and npm 11.16.0.

These tests exercise the production seams described above. No real Hopper, Ghidra, desktop browser or Linux sandbox end-to-end verification is claimed.

Prepared with AI assistance; the reproductions and verification commands above were executed locally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/513 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/capture-incomplete-absence-20261004` --- ### 📝 Commits (2) - [`8be1b0c`](https://github.com/morluto/rea/commit/8be1b0c2885db6fbfdd1ac79495032a13ff10804) fix(web): retain uncertainty for incomplete capture inventories - [`cd35de6`](https://github.com/morluto/rea/commit/cd35de63f543a64f4cca05a74831a6938f724d29) test(web): keep incomplete capture cases in a focused suite ### 📊 Changes **2 files changed** (+62 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/webCaptureDiff.ts` (+3 -1) 📝 `tests/boundary/browser/webCaptureDiff.test.ts` (+59 -0) </details> ### 📄 Description ## Change Do not assert script/resource/network/WebMCP added or removed identities when either section is incomplete. Preserve observed shared-identity modifications. Tests use production CdpBrowserProvider against an owned fake CDP socket, not a real browser. Existing deliberate removal fixture now explicitly marks its script inventory complete. ## Reproduction and verification 8 tests PASS; before2FAIL6PASS - `npm run check:pr`: passed (Test Files 352 passed (352); Tests 1800 passed | 2 skipped (1802)). - `npm run check:ci`: passed. - `npm run verify:package`: passed installed-tarball CLI/MCP verification, including optional-dependency degradation. - `npm pack --dry-run`: passed. - Exact lockfile installation on Node 24.18.0 and npm 11.16.0. These tests exercise the production seams described above. No real Hopper, Ghidra, desktop browser or Linux sandbox end-to-end verification is claimed. Prepared with AI assistance; the reproductions and verification commands above were executed locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:37 +00:00