[PR #516] [MERGED] fix(native): retain re-exported Mach-O library dependencies #2040

New issue

Closed

opened 2026-10-16 21:13:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/516
Author: @rudycelekli
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: fix/native-reexport-dependencies-20261004

📝 Commits (1)

0989126 fix(native): retain re-exported Mach-O library dependencies

📊 Changes

6 files changed (+202 additions, -1 deletions)

View changed files

📝 src/native/parsers/otool.ts (+6 -1)
➕ tests/boundary/providers/native/nativeReexport.golden.test.ts (+40 -0)
➕ tests/fixtures/native-macos/native-reexport/README.md (+14 -0)
➕ tests/fixtures/native-macos/native-reexport/leaf.c (+1 -0)
➕ tests/fixtures/native-macos/native-reexport/otool-load.txt (+140 -0)
➕ tests/fixtures/native-macos/native-reexport/outer.c (+1 -0)

📄 Description

Change

Retain observed LC_REEXPORT_DYLIB commands in Mach-O dependency inventories. The existing dependency filter discards these load commands despite recording them in the raw command list. Preserve existing dependency kinds and version/path fields.

Reproduction and verification

Actual owned clang-built re-export dylib inspected through the production default native provider: baseline one re-export regression failed while an ordinary dylib control passed; after 16 focused tests passed (two native producer cases, one recorded-format regression, and thirteen existing controls). No target binary was executed.

npm run check:pr: passed (Test Files 353 passed (353); Tests 1799 passed | 2 skipped (1801)).
npm run check:ci: passed.
npm run verify:package: passed installed-tarball CLI/MCP verification, including optional-dependency degradation.
npm pack --dry-run: passed.
npm run verify:apple-dispatch: passed source-built Objective-C and Swift fixture checks. The focused native producer reproduction is distinct from this lane.
Matching npm run verify:apple-dispatch: passed the native verification lane.
Exact lockfile installation on Node 24.18.0 and npm 11.16.0.

Source-built macOSarm64/Xcodetools only; noHopper/Ghidra/UI claims; patch acceptsobservedLC_REEXPORT_DYLIB andpreserves existingadmission.

Prepared with AI assistance; the reproductions and verification commands above were executed locally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/516 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/native-reexport-dependencies-20261004` --- ### 📝 Commits (1) - [`0989126`](https://github.com/morluto/rea/commit/0989126e31eaf91c2fb8ca03bd65063f1a43d50f) fix(native): retain re-exported Mach-O library dependencies ### 📊 Changes **6 files changed** (+202 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/native/parsers/otool.ts` (+6 -1) ➕ `tests/boundary/providers/native/nativeReexport.golden.test.ts` (+40 -0) ➕ `tests/fixtures/native-macos/native-reexport/README.md` (+14 -0) ➕ `tests/fixtures/native-macos/native-reexport/leaf.c` (+1 -0) ➕ `tests/fixtures/native-macos/native-reexport/otool-load.txt` (+140 -0) ➕ `tests/fixtures/native-macos/native-reexport/outer.c` (+1 -0) </details> ### 📄 Description ## Change Retain observed LC_REEXPORT_DYLIB commands in Mach-O dependency inventories. The existing dependency filter discards these load commands despite recording them in the raw command list. Preserve existing dependency kinds and version/path fields. ## Reproduction and verification Actual owned clang-built re-export dylib inspected through the production default native provider: baseline one re-export regression failed while an ordinary dylib control passed; after 16 focused tests passed (two native producer cases, one recorded-format regression, and thirteen existing controls). No target binary was executed. - `npm run check:pr`: passed (Test Files 353 passed (353); Tests 1799 passed | 2 skipped (1801)). - `npm run check:ci`: passed. - `npm run verify:package`: passed installed-tarball CLI/MCP verification, including optional-dependency degradation. - `npm pack --dry-run`: passed. - `npm run verify:apple-dispatch`: passed source-built Objective-C and Swift fixture checks. The focused native producer reproduction is distinct from this lane. Matching `npm run verify:apple-dispatch`: passed the native verification lane. - Exact lockfile installation on Node 24.18.0 and npm 11.16.0. Source-built macOSarm64/Xcodetools only; noHopper/Ghidra/UI claims; patch acceptsobservedLC_REEXPORT_DYLIB andpreserves existingadmission. Prepared with AI assistance; the reproductions and verification commands above were executed locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:39 +00:00