[PR #514] [MERGED] fix(artifacts): respect XML plist byte-order marks #2041

New issue

Closed

opened 2026-10-16 21:13:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/514
Author: @rudycelekli
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: fix/keyed-archive-xml-encoding-20261004

📝 Commits (1)

931fb89 fix(artifacts): respect XML plist byte-order marks

📊 Changes

5 files changed (+190 additions, -1 deletions)

View changed files

📝 src/artifacts/KeyedArchiveReader.ts (+22 -1)
➕ tests/boundary/providers/native/keyedArchiveEncoding.test.ts (+84 -0)
➕ tests/fixtures/native-macos/archive-xml-encoding/README.md (+17 -0)
➕ tests/fixtures/native-macos/archive-xml-encoding/archive.xml (+54 -0)
➕ tests/fixtures/native-macos/archive-xml-encoding/producer.swift (+13 -0)

📄 Description

Change

fix(artifacts): respect XML plist byte-order marks

Reproduction and verification

Source-owned NSKeyedArchiver UTF-8 XML was transcoded by Foundation to BOM-qualified UTF-16 LE and BE; Foundation and plutil accepted all three files. The actual production filesystem reader failed both UTF-16 files before and read their Café values correctly after. Final focused matrix: 6 failures / 5 controls before; 13 passing tests after. Binary and malformed-input controls preserved.

npm run check:pr: passed (Test Files 353 passed (353); Tests 1806 passed | 2 skipped (1808)).
npm run check:ci: passed.
npm run verify:package: passed installed-tarball CLI/MCP verification, including optional-dependency degradation.
npm pack --dry-run: passed.
Matching npm run verify:keyed-archive: passed the native verification lane.
Exact lockfile installation on Node 24.18.0 and npm 11.16.0.

UTF8andBOM-markedUTF16; no newoutputschema/noUIorarchivedclassinstantiation. ActualNSKeyedArchiverXML transcodedusingFoundation, notclaimitsdefaultoutputisUTF16. SystemPropertyListSerialization/plutilacceptbothendianness. OtherXMLencodingsnotnewlycovered.

Prepared with AI assistance; the reproductions and verification commands above were executed locally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/514 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/keyed-archive-xml-encoding-20261004` --- ### 📝 Commits (1) - [`931fb89`](https://github.com/morluto/rea/commit/931fb892577e7bb0a058c02a193ead9f691bed6f) fix(artifacts): respect XML plist byte-order marks ### 📊 Changes **5 files changed** (+190 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/artifacts/KeyedArchiveReader.ts` (+22 -1) ➕ `tests/boundary/providers/native/keyedArchiveEncoding.test.ts` (+84 -0) ➕ `tests/fixtures/native-macos/archive-xml-encoding/README.md` (+17 -0) ➕ `tests/fixtures/native-macos/archive-xml-encoding/archive.xml` (+54 -0) ➕ `tests/fixtures/native-macos/archive-xml-encoding/producer.swift` (+13 -0) </details> ### 📄 Description ## Change fix(artifacts): respect XML plist byte-order marks ## Reproduction and verification Source-owned NSKeyedArchiver UTF-8 XML was transcoded by Foundation to BOM-qualified UTF-16 LE and BE; Foundation and plutil accepted all three files. The actual production filesystem reader failed both UTF-16 files before and read their Café values correctly after. Final focused matrix: 6 failures / 5 controls before; 13 passing tests after. Binary and malformed-input controls preserved. - `npm run check:pr`: passed (Test Files 353 passed (353); Tests 1806 passed | 2 skipped (1808)). - `npm run check:ci`: passed. - `npm run verify:package`: passed installed-tarball CLI/MCP verification, including optional-dependency degradation. - `npm pack --dry-run`: passed. Matching `npm run verify:keyed-archive`: passed the native verification lane. - Exact lockfile installation on Node 24.18.0 and npm 11.16.0. UTF8andBOM-markedUTF16; no newoutputschema/noUIorarchivedclassinstantiation. ActualNSKeyedArchiverXML transcodedusingFoundation, notclaimitsdefaultoutputisUTF16. SystemPropertyListSerialization/plutilacceptbothendianness. OtherXMLencodingsnotnewlycovered. Prepared with AI assistance; the reproductions and verification commands above were executed locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:39 +00:00