[PR #521] [MERGED] fix(workflows): preserve punctuation in filesystem source paths #2046

New issue

Closed

opened 2026-10-16 21:13:41 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/521
Author: @rudycelekli
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: fix/source-path-punctuation-20261004

📝 Commits (2)

302c67d fix(workflows): preserve punctuation in filesystem source paths
2688c09 fix(workflows): share scheme URL pattern in path normalization

📊 Changes

3 files changed (+149 additions, -2 deletions)

View changed files

📝 src/domain/sourceToBundleComparison.test.ts (+80 -0)
📝 src/domain/sourceToBundleSignals.ts (+9 -2)
➕ tests/boundary/filesystem/sourceToBundlePaths.test.ts (+60 -0)

📄 Description

Change

Preserve literal # and ? punctuation in filesystem paths when matching historical sources to current application nodes. Query/fragment stripping applies only to scheme URLs; HTTPS and webpack controls remain intact. The actual owned filesystem/import/application-analysis producer previously returned unknown with no candidate for a present # file; a separate constructed complete inventory falsely classified that file as removed. Native after retains current path candidates and existing static split inference. This does not establish semantic equivalence or claim the native graph is complete.

Reproduction and verification

Final before3FAIL6PASS; after9PASS, officiallint exit0

npm run check:pr: passed (Test Files 353 passed (353); Tests 1803 passed | 2 skipped (1805)).
npm run check:ci: passed.
npm run verify:package: passed installed-tarball CLI/MCP verification, including optional-dependency degradation.
npm pack --dry-run: passed.
Exact lockfile installation on Node 24.18.0 and npm 11.16.0.

These tests exercise the production seams described above. No real Hopper, Ghidra, desktop browser or Linux sandbox end-to-end verification is claimed.

Prepared with AI assistance; the reproductions and verification commands above were executed locally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/521 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/source-path-punctuation-20261004` --- ### 📝 Commits (2) - [`302c67d`](https://github.com/morluto/rea/commit/302c67d525670e88e1e69ca633def9461bd6cd25) fix(workflows): preserve punctuation in filesystem source paths - [`2688c09`](https://github.com/morluto/rea/commit/2688c09268d63d97eb8bebf5dffb7de7137ce512) fix(workflows): share scheme URL pattern in path normalization ### 📊 Changes **3 files changed** (+149 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/sourceToBundleComparison.test.ts` (+80 -0) 📝 `src/domain/sourceToBundleSignals.ts` (+9 -2) ➕ `tests/boundary/filesystem/sourceToBundlePaths.test.ts` (+60 -0) </details> ### 📄 Description ## Change Preserve literal # and ? punctuation in filesystem paths when matching historical sources to current application nodes. Query/fragment stripping applies only to scheme URLs; HTTPS and webpack controls remain intact. The actual owned filesystem/import/application-analysis producer previously returned unknown with no candidate for a present # file; a separate constructed complete inventory falsely classified that file as removed. Native after retains current path candidates and existing static split inference. This does not establish semantic equivalence or claim the native graph is complete. ## Reproduction and verification Final before3FAIL6PASS; after9PASS, officiallint exit0 - `npm run check:pr`: passed (Test Files 353 passed (353); Tests 1803 passed | 2 skipped (1805)). - `npm run check:ci`: passed. - `npm run verify:package`: passed installed-tarball CLI/MCP verification, including optional-dependency degradation. - `npm pack --dry-run`: passed. - Exact lockfile installation on Node 24.18.0 and npm 11.16.0. These tests exercise the production seams described above. No real Hopper, Ghidra, desktop browser or Linux sandbox end-to-end verification is claimed. Prepared with AI assistance; the reproductions and verification commands above were executed locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:41 +00:00