[PR #525] [MERGED] fix(native): capture Mach-O header metadata alongside load commands #2052

New issue

Closed

opened 2026-10-16 21:13:45 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/525
Author: @rudycelekli
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: fix/native-macho-header-capture-20261004

📝 Commits (3)

ccde79a fix(native): capture Mach-O header metadata alongside load commands
4678b28 style(test): format native Mach-O header regression
d0a48da fix(native): drop dead bare otool override in header test

📊 Changes

7 files changed (+360 additions, -12 deletions)

View changed files

📝 src/native/NativeMachoInspection.ts (+1 -1)
📝 src/native/parsers/otool.ts (+0 -11)
➕ tests/boundary/providers/native/nativeMachoHeader.golden.test.ts (+44 -0)
➕ tests/fixtures/native-macos/native-macho-header/README.md (+14 -0)
➕ tests/fixtures/native-macos/native-macho-header/fixture.c (+2 -0)
➕ tests/fixtures/native-macos/native-macho-header/otool-header-load.txt (+152 -0)
➕ tests/fixtures/native-macos/native-macho-header/otool-load.txt (+147 -0)

📄 Description

Change

Capture actual otool numeric header with load commands; do not conflate segment/section flags with Mach-header flags. Individual command fields remain intact.

Reproduction and verification

2 native production-provider failures and2golden failures

npm run check:pr: passed (Test Files 353 passed (353); Tests 1800 passed | 2 skipped (1802)).
npm run check:ci: passed.
npm run verify:package: passed installed-tarball CLI/MCP verification, including optional-dependency degradation.
npm pack --dry-run: passed.
npm run verify:apple-dispatch: passed source-built Objective-C and Swift fixture checks. The focused native producer reproduction is distinct from this lane.
Matching npm run verify:apple-dispatch: passed the native verification lane.
Exact lockfile installation on Node 24.18.0 and npm 11.16.0.

Real source-builtmacOSarm64/nativeXcodetools only, noHopper/Ghidra/UI. Goldenfixtureproviderseam is deterministiccompatibilityproof, notrealruntimeproof.

Prepared with AI assistance; the reproductions and verification commands above were executed locally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/525 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/native-macho-header-capture-20261004` --- ### 📝 Commits (3) - [`ccde79a`](https://github.com/morluto/rea/commit/ccde79a377d132fbd1ca370f3b3e5bd31c67c48b) fix(native): capture Mach-O header metadata alongside load commands - [`4678b28`](https://github.com/morluto/rea/commit/4678b282deb5e0b3e3bc64bdd2faf1bb74185c3d) style(test): format native Mach-O header regression - [`d0a48da`](https://github.com/morluto/rea/commit/d0a48da1fa8f8db3b8740f2420280a6fe9a9e6f5) fix(native): drop dead bare otool override in header test ### 📊 Changes **7 files changed** (+360 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/native/NativeMachoInspection.ts` (+1 -1) 📝 `src/native/parsers/otool.ts` (+0 -11) ➕ `tests/boundary/providers/native/nativeMachoHeader.golden.test.ts` (+44 -0) ➕ `tests/fixtures/native-macos/native-macho-header/README.md` (+14 -0) ➕ `tests/fixtures/native-macos/native-macho-header/fixture.c` (+2 -0) ➕ `tests/fixtures/native-macos/native-macho-header/otool-header-load.txt` (+152 -0) ➕ `tests/fixtures/native-macos/native-macho-header/otool-load.txt` (+147 -0) </details> ### 📄 Description ## Change Capture actual otool numeric header with load commands; do not conflate segment/section flags with Mach-header flags. Individual command fields remain intact. ## Reproduction and verification 2 native production-provider failures and2golden failures - `npm run check:pr`: passed (Test Files 353 passed (353); Tests 1800 passed | 2 skipped (1802)). - `npm run check:ci`: passed. - `npm run verify:package`: passed installed-tarball CLI/MCP verification, including optional-dependency degradation. - `npm pack --dry-run`: passed. - `npm run verify:apple-dispatch`: passed source-built Objective-C and Swift fixture checks. The focused native producer reproduction is distinct from this lane. Matching `npm run verify:apple-dispatch`: passed the native verification lane. - Exact lockfile installation on Node 24.18.0 and npm 11.16.0. Real source-builtmacOSarm64/nativeXcodetools only, noHopper/Ghidra/UI. Goldenfixtureproviderseam is deterministiccompatibilityproof, notrealruntimeproof. Prepared with AI assistance; the reproductions and verification commands above were executed locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:45 +00:00