[PR #532] [MERGED] fix(native): retain lazy dylibs, normalize version-min builds, limit thread entrypoints #2053

New issue

Closed

opened 2026-10-16 21:13:46 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/532
Author: @morluto
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: cleanup/native-load-kinds

📝 Commits (1)

8f60cf9 fix(native): retain lazy dylibs, normalize version-min builds, limit thread entrypoints

📊 Changes

3 files changed (+112 additions, -8 deletions)

View changed files

📝 src/native/NativeMachoInspection.ts (+9 -0)
📝 src/native/parsers/otool.ts (+18 -8)
➕ tests/boundary/providers/native/nativeLoadKinds.golden.test.ts (+85 -0)

📄 Description

Follow-up sweep: dropped load-command variants.

LC_LAZY_LOAD_DYLIB was silently dropped by collectDependency (only LC_LOAD_* prefix + two explicit kinds). Retained like #516 did for re-exports.
LC_VERSION_MIN_{MACOSX,IPHONEOS,WATCHOS,TVOS} produced empty builds[] with no limitation. Normalized into builds with platform from the kind suffix (matching otool's own vocabulary, e.g. MACOSX), minimum_os from version, sdk from sdk, no tools. LC_SOURCE_VERSION stays raw-only (not a platform build record).
LC_UNIXTHREAD/LC_THREAD binaries reported bare entrypoints: []. Inspection now adds an explicit limitation when thread-state commands exist but no file offset was derived (offsets are arch register state this parser does not decode).

Tests: new nativeLoadKinds golden (parser + full inspect_macho limitation path). Parser suites + tsc + prettier green.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/532 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/native-load-kinds` --- ### 📝 Commits (1) - [`8f60cf9`](https://github.com/morluto/rea/commit/8f60cf96f04c59fb999e70f9a51f091abf3ddc26) fix(native): retain lazy dylibs, normalize version-min builds, limit thread entrypoints ### 📊 Changes **3 files changed** (+112 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/native/NativeMachoInspection.ts` (+9 -0) 📝 `src/native/parsers/otool.ts` (+18 -8) ➕ `tests/boundary/providers/native/nativeLoadKinds.golden.test.ts` (+85 -0) </details> ### 📄 Description Follow-up sweep: dropped load-command variants. - `LC_LAZY_LOAD_DYLIB` was silently dropped by `collectDependency` (only `LC_LOAD_*` prefix + two explicit kinds). Retained like #516 did for re-exports. - `LC_VERSION_MIN_{MACOSX,IPHONEOS,WATCHOS,TVOS}` produced empty `builds[]` with no limitation. Normalized into builds with platform from the kind suffix (matching otool's own vocabulary, e.g. MACOSX), `minimum_os` from `version`, `sdk` from `sdk`, no tools. `LC_SOURCE_VERSION` stays raw-only (not a platform build record). - `LC_UNIXTHREAD`/`LC_THREAD` binaries reported bare `entrypoints: []`. Inspection now adds an explicit limitation when thread-state commands exist but no file offset was derived (offsets are arch register state this parser does not decode). Tests: new nativeLoadKinds golden (parser + full inspect_macho limitation path). Parser suites + tsc + prettier green. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:46 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:57:47 +00:00

[PR #2054] [CLOSED] fix(cli): restore import-map option descriptions in trace-web-module-imports help #4992

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2053

No description provided.

Rows
Columns