[PR #596] [MERGED] fix(comparison): match generated names without swallowing symbol prefixes #2096

New issue

Closed

opened 2026-10-16 21:14:14 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:14:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/596
Author: @rudycelekli
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: campaign/rea-oct5-domain-symbol-names

📝 Commits (3)

050ba63 fix(comparison): match generated names without swallowing symbol prefixes
cf9adf3 test(comparison): cover symbol identity and callee dimensions
5ddd5e1 Merge origin/main into campaign/rea-oct5-domain-symbol-names

📊 Changes

3 files changed (+72 additions, -1 deletions)

View changed files

➕ node_modules (+1 -0)
📝 src/domain/functionComparison.test.ts (+70 -0)
📝 src/domain/functionComparisonNormalization.ts (+1 -1)

📄 Description

Summary

Explicit symbols retain symbol matching and unchanged identity/call dimensions; full address-derived function and callee names remain unknown.

No issue is linked: this is a narrow, reproduced correction to an existing comparison invariant discovered while reviewing current code, with no new feature, architectural change, or public contract requiring a proposal.

Problem and expected behavior

sub_deallocate, sub_deadbeef_handler, and fcn.dispatch were classified as generated names solely because a prefix looked address-derived. Full generated-address names should remain ambiguous; explicitly observed other symbols should keep symbol matching.

Change and scope

Anchor both generated-name alternatives at the full name and require hexadecimal suffixes for fcn names. Preserve existing conservative handling of actual sub_deadbeef and fcn.00401000 names.

Contract and boundary impact

Semantic owner and earliest changed stage: Function comparison / generated-symbol classification.
CLI and MCP/tool-catalog contract: same commands, schemas and result fields; corrected existing comparison values only.
Provider, bridge, target-format, or platform compatibility: no provider/bridge changes or new platform support.
Evidence, artifact, provenance, or reconstruction contract: existing content-addressed inputs and provenance preserved; no new artifact identity or authority claim.
Process execution, authorization, cleanup, or containment impact: none in production.
Generated metadata (docs/product-catalog.json), package, or installation impact: none; relevant metadata checks remain enforced.

Evidence and regression coverage

Tests added or updated: 16 focused function comparison tests pass, including unchanged/unknown identity dimensions and explicit/address-derived callee controls for the calls dimension. Combined CFG + generated-name source integration passes 16 tests.
Base reproduction or other evidence: executed production comparison regression fails on unchanged branch base; patched regression passes. No module mocks.
User-visible CLI/MCP output (if applicable): representative selected fields from the executed comparison fixture, not a claimed live CLI/provider session:

{"function_match":{"status":"matched","method":"symbol","left_name":"sub_deallocate","right_name":"sub_deallocate"},"dimensions":[{"dimension":"identity","status":"unchanged"}]}

Remaining proof gaps: Controlled complete dossier Evidence. No new claim that a name proves runtime equivalence.

For evidence-bearing changes:

Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

npm run test:focused -- src/domain/functionComparison.test.ts — pass: 1 files, 16 tests.
npm run check — pass on final signed head.
Current upstream AGENTS.md/CONTRIBUTING (#599) makes full check:pr optional for narrow fixes. Previous full-suite, check:ci and package evidence remains archived for the pre-repair or pre-rebase head; those counts are not claimed for this head. No packaging/distribution or provider behavior changed.

Existing upstream lint/TypeDoc warnings remain; passing gates are not claimed warning-free.

Compatibility, safety, and release

Breaking changes or migration steps: none; existing comparison result shape preserved.
Real Hopper/Ghidra, browser, or OS coverage: not required for this pure comparison correction; controlled Evidence/fixture coverage described above.
Package or release metadata impact: none.
Security, privacy, process, or containment review: no secrets, production data, new process execution, authorization mechanism, or containment change.

Review checklist

The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed (no new public contract or metadata change).
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

AI assistance was used for investigation, implementation and testing. The commit is signed and includes DCO sign-off.

Combined integration with the other function-normalization correction passes all 16 tests. The shared test insertion point may need a test-only conflict resolution; preserve both independent regression blocks.

Upstream integration and merge outcome

The maintainer merged this PR on 2026-10-05 at 17:57:21 UTC using their equivalent merge head 5ddd5e1. That merge preserves the complete owner CFG regression block and all explicit/generated identity and callee/calls controls in independent wrappers.

The equivalent comparison source was locally verified with all 16 function comparison tests, npm run check, and npm run check:fast. Remote checks for the merged owner head had no completed failures but still included a pending check at the last observation; this is not an all-green CI claim.

A subsequent signed fork-only commit 7f1ca11 preserves the owner merge and removes an accidentally tracked generated dependency symlink. Its production/test tree is identical to the merged owner head; all 16 focused tests and required static checks pass locally. That cleanup was pushed after the upstream merge and is not included in the merged PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/596 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `campaign/rea-oct5-domain-symbol-names` --- ### 📝 Commits (3) - [`050ba63`](https://github.com/morluto/rea/commit/050ba63b01b3921f771ce41461dd83d175393c7f) fix(comparison): match generated names without swallowing symbol prefixes - [`cf9adf3`](https://github.com/morluto/rea/commit/cf9adf3c6044bd85689babd074d664aaff213471) test(comparison): cover symbol identity and callee dimensions - [`5ddd5e1`](https://github.com/morluto/rea/commit/5ddd5e123ec2795cf5a35d6e7c16394d7a38ccb8) Merge origin/main into campaign/rea-oct5-domain-symbol-names ### 📊 Changes **3 files changed** (+72 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `node_modules` (+1 -0) 📝 `src/domain/functionComparison.test.ts` (+70 -0) 📝 `src/domain/functionComparisonNormalization.ts` (+1 -1) </details> ### 📄 Description ## Summary Explicit symbols retain symbol matching and unchanged identity/call dimensions; full address-derived function and callee names remain unknown. No issue is linked: this is a narrow, reproduced correction to an existing comparison invariant discovered while reviewing current code, with no new feature, architectural change, or public contract requiring a proposal. ## Problem and expected behavior `sub_deallocate`, `sub_deadbeef_handler`, and `fcn.dispatch` were classified as generated names solely because a prefix looked address-derived. Full generated-address names should remain ambiguous; explicitly observed other symbols should keep symbol matching. ## Change and scope Anchor both generated-name alternatives at the full name and require hexadecimal suffixes for fcn names. Preserve existing conservative handling of actual sub_deadbeef and fcn.00401000 names. ## Contract and boundary impact - Semantic owner and earliest changed stage: Function comparison / generated-symbol classification. - CLI and MCP/tool-catalog contract: same commands, schemas and result fields; corrected existing comparison values only. - Provider, bridge, target-format, or platform compatibility: no provider/bridge changes or new platform support. - Evidence, artifact, provenance, or reconstruction contract: existing content-addressed inputs and provenance preserved; no new artifact identity or authority claim. - Process execution, authorization, cleanup, or containment impact: none in production. - Generated metadata (`docs/product-catalog.json`), package, or installation impact: none; relevant metadata checks remain enforced. ## Evidence and regression coverage - Tests added or updated: 16 focused function comparison tests pass, including unchanged/unknown identity dimensions and explicit/address-derived callee controls for the calls dimension. Combined CFG + generated-name source integration passes 16 tests. - Base reproduction or other evidence: executed production comparison regression fails on unchanged branch base; patched regression passes. No module mocks. - User-visible CLI/MCP output (if applicable): representative selected fields from the executed comparison fixture, not a claimed live CLI/provider session: ```json {"function_match":{"status":"matched","method":"symbol","left_name":"sub_deallocate","right_name":"sub_deallocate"},"dimensions":[{"dimension":"identity","status":"unchanged"}]} ``` - Remaining proof gaps: Controlled complete dossier Evidence. No new claim that a name proves runtime equivalence. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - `npm run test:focused -- src/domain/functionComparison.test.ts` — pass: 1 files, 16 tests. - `npm run check` — pass on final signed head. - Current upstream AGENTS.md/CONTRIBUTING (#599) makes full check:pr optional for narrow fixes. Previous full-suite, check:ci and package evidence remains archived for the pre-repair or pre-rebase head; those counts are not claimed for this head. No packaging/distribution or provider behavior changed. Existing upstream lint/TypeDoc warnings remain; passing gates are not claimed warning-free. ## Compatibility, safety, and release - Breaking changes or migration steps: none; existing comparison result shape preserved. - Real Hopper/Ghidra, browser, or OS coverage: not required for this pure comparison correction; controlled Evidence/fixture coverage described above. - Package or release metadata impact: none. - Security, privacy, process, or containment review: no secrets, production data, new process execution, authorization mechanism, or containment change. ## Review checklist - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed (no new public contract or metadata change). - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. AI assistance was used for investigation, implementation and testing. The commit is signed and includes DCO sign-off. Combined integration with the other function-normalization correction passes all 16 tests. The shared test insertion point may need a test-only conflict resolution; preserve both independent regression blocks. ## Upstream integration and merge outcome The maintainer merged this PR on 2026-10-05 at 17:57:21 UTC using their equivalent merge head `5ddd5e1`. That merge preserves the complete owner CFG regression block and all explicit/generated identity and callee/calls controls in independent wrappers. The equivalent comparison source was locally verified with all 16 function comparison tests, `npm run check`, and `npm run check:fast`. Remote checks for the merged owner head had no completed failures but still included a pending check at the last observation; this is not an all-green CI claim. A subsequent signed fork-only commit `7f1ca11` preserves the owner merge and removes an accidentally tracked generated dependency symlink. Its production/test tree is identical to the merged owner head; all 16 focused tests and required static checks pass locally. That cleanup was pushed after the upstream merge and is not included in the merged PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:14:14 +00:00