morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #599] [MERGED] chore(test): separate development feedback from full verification #2099

New issue

Closed

opened 2026-10-16 21:14:15 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:14:15 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/599
Author: @N0zoM1z0
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: chore/development-check-layers

📝 Commits (2)

fdc0f8e chore(test): separate development feedback from full verification
fdf7f75 Merge remote-tracking branch 'origin/main' into chore/development-check-layers

📊 Changes

13 files changed (+483 additions, -70 deletions)

View changed files

📝 .github/workflows/ci.yml (+1 -0)
📝 AGENTS.md (+5 -2)
📝 CONTRIBUTING.md (+35 -28)
📝 docs/testing.md (+54 -24)
📝 knip.json (+6 -1)
📝 package.json (+9 -11)
➕ scripts/lib/development-tests.d.mts (+21 -0)
➕ scripts/lib/development-tests.mjs (+77 -0)
➕ scripts/run-development-tests.mjs (+90 -0)
➕ tests/boundary/cli/developmentTests.test.ts (+100 -0)
➕ tests/evaluation/developmentTestPlan.test.ts (+69 -0)
📝 turbo.json (+8 -2)
📝 typedoc.json (+8 -2)

📄 Description

Summary

Separate routine source-test feedback from compiled-runtime and full-CI verification. Keep complete deterministic coverage and real-provider lanes intact, while removing mandatory full local reruns from every edit, rebase, or push.

Changes

test:local selects source tests without building; exact source paths run regardless of Git status.
Add test:focused -- PATH...: validate existing explicit files, build before compiled boundaries, and reject zero-test success. Build and tests run inside the repository test lock.
test:changed compares committed and dirty source changes against the branch merge base (default origin/main, override with --base). Add a dry-run plan and actionable missing-base errors.
Limit test:fast and source watch to projects without compiled prerequisites. Keep boundary, acceptance, full suite, coverage and actual provider commands available.
Separate generated-document freshness and regeneration from TypeDoc HTML. PR CI explicitly renders its API artifact.
Align build/API cache inputs with production compilation, exclude tests/fixtures, and retain their typecheck/lint checks. TypeDoc uses the production tsconfig and excludes fixture APIs.
Quiet successful cached typecheck/lint output; update contribution and agent guidance to use scoped local verification.

Changed-test selection remains feedback: runtime registration, generated data, shell and bridge edges require explicit boundary/provider verification. Large capacity regressions remain in the existing full source/CI suites.

Verification

npm run test:local -- tests/evaluation/developmentTestPlan.test.ts: 15 passed; no build.
npm run test:focused -- tests/boundary/cli/developmentTests.test.ts tests/evaluation/developmentTestPlan.test.ts: 18 passed. Real temporary Git repository and real Vitest prove clean committed-branch selection and source execution without dist.
Compiled tests/acceptance/applications/runtime.test.ts: 2 passed, real stdio startup/catalog/call/shutdown.
tests/process-global/vitestConfiguration.test.ts: passed, every deterministic test has exactly one owner.
npm run test:fast: 197 files, 1,259 passed / 1 skipped, 43.24s on this host.
npm run check: all 5 static tasks passed.
npm run docs:check: passed, 2 tasks / 11.443s; no TypeDoc task.
npm run docs:api:cached: real render passed, 0 errors (202 existing warnings).
Actual Turbo hash probes: test/fixture additions preserve build and API hashes; production-source addition changes both hashes. All probe files removed.
npm pack --dry-run --ignore-scripts --json: 696 entries, required compiled entrypoints and bridge present.

Full coverage and cross-platform package evidence remain in PR CI. Real Hopper/Ghidra verification was not run locally: provider implementations, bridge protocols and binary-analysis behavior are unchanged.

Compatibility

Development scripts and contributing guidance change; public CLI/MCP tools, setup confirmation, OS/process ownership and artifact containment remain intact. No binaries, private inputs or local probe artifacts are committed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/599 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `chore/development-check-layers` --- ### 📝 Commits (2) - [`fdc0f8e`](https://github.com/morluto/rea/commit/fdc0f8e3e22d00a80c46be2cff6ccd59925e5b63) chore(test): separate development feedback from full verification - [`fdf7f75`](https://github.com/morluto/rea/commit/fdf7f75f9aa4ceb979733ada5c84491057c8c88f) Merge remote-tracking branch 'origin/main' into chore/development-check-layers ### 📊 Changes **13 files changed** (+483 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+1 -0) 📝 `AGENTS.md` (+5 -2) 📝 `CONTRIBUTING.md` (+35 -28) 📝 `docs/testing.md` (+54 -24) 📝 `knip.json` (+6 -1) 📝 `package.json` (+9 -11) ➕ `scripts/lib/development-tests.d.mts` (+21 -0) ➕ `scripts/lib/development-tests.mjs` (+77 -0) ➕ `scripts/run-development-tests.mjs` (+90 -0) ➕ `tests/boundary/cli/developmentTests.test.ts` (+100 -0) ➕ `tests/evaluation/developmentTestPlan.test.ts` (+69 -0) 📝 `turbo.json` (+8 -2) 📝 `typedoc.json` (+8 -2) </details> ### 📄 Description ## Summary Separate routine source-test feedback from compiled-runtime and full-CI verification. Keep complete deterministic coverage and real-provider lanes intact, while removing mandatory full local reruns from every edit, rebase, or push. ## Changes - `test:local` selects source tests without building; exact source paths run regardless of Git status. - Add `test:focused -- PATH...`: validate existing explicit files, build before compiled boundaries, and reject zero-test success. Build and tests run inside the repository test lock. - `test:changed` compares committed and dirty source changes against the branch merge base (default `origin/main`, override with `--base`). Add a dry-run plan and actionable missing-base errors. - Limit `test:fast` and source watch to projects without compiled prerequisites. Keep boundary, acceptance, full suite, coverage and actual provider commands available. - Separate generated-document freshness and regeneration from TypeDoc HTML. PR CI explicitly renders its API artifact. - Align build/API cache inputs with production compilation, exclude tests/fixtures, and retain their typecheck/lint checks. TypeDoc uses the production tsconfig and excludes fixture APIs. - Quiet successful cached typecheck/lint output; update contribution and agent guidance to use scoped local verification. Changed-test selection remains feedback: runtime registration, generated data, shell and bridge edges require explicit boundary/provider verification. Large capacity regressions remain in the existing full source/CI suites. ## Verification - `npm run test:local -- tests/evaluation/developmentTestPlan.test.ts`: 15 passed; no build. - `npm run test:focused -- tests/boundary/cli/developmentTests.test.ts tests/evaluation/developmentTestPlan.test.ts`: 18 passed. Real temporary Git repository and real Vitest prove clean committed-branch selection and source execution without dist. - Compiled `tests/acceptance/applications/runtime.test.ts`: 2 passed, real stdio startup/catalog/call/shutdown. - `tests/process-global/vitestConfiguration.test.ts`: passed, every deterministic test has exactly one owner. - `npm run test:fast`: 197 files, 1,259 passed / 1 skipped, 43.24s on this host. - `npm run check`: all 5 static tasks passed. - `npm run docs:check`: passed, 2 tasks / 11.443s; no TypeDoc task. - `npm run docs:api:cached`: real render passed, 0 errors (202 existing warnings). - Actual Turbo hash probes: test/fixture additions preserve build and API hashes; production-source addition changes both hashes. All probe files removed. - `npm pack --dry-run --ignore-scripts --json`: 696 entries, required compiled entrypoints and bridge present. Full coverage and cross-platform package evidence remain in PR CI. Real Hopper/Ghidra verification was not run locally: provider implementations, bridge protocols and binary-analysis behavior are unchanged. ## Compatibility Development scripts and contributing guidance change; public CLI/MCP tools, setup confirmation, OS/process ownership and artifact containment remain intact. No binaries, private inputs or local probe artifacts are committed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:14:15 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:59:00 +00:00

[PR #2099] [MERGED] fix(browser): compare PNG IHDR bytes without ASCII folding #5028

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2099

No description provided.

Rows
Columns