[PR #615] [MERGED] chore: migrate formatting to Oxfmt #2115

Closed
opened 2026-10-16 21:14:29 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/615
Author: @morluto
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: chore/migrate-oxfmt


📝 Commits (1)

  • e91dbfe chore: migrate formatting to Oxfmt

📊 Changes

25 files changed (+514 additions, -139 deletions)

View changed files

➕ .oxfmtrc.json (+15 -0)
➖ .prettierignore (+0 -8)
📝 AGENTS.md (+1 -1)
📝 CONTRIBUTING.md (+3 -1)
📝 README_ar.md (+19 -19)
📝 docs/adr/0003-managed-code-evidence-and-provider-boundary.md (+1 -1)
📝 docs/native-investigation.md (+1 -1)
📝 package-lock.json (+386 -17)
📝 package.json (+5 -5)
📝 scripts/generate-error-schema.mjs (+5 -4)
📝 scripts/generate-mcp-tool-catalog.mjs (+3 -3)
➕ scripts/lib/format-generated-file.mjs (+12 -0)
📝 scripts/lib/product-catalog.mjs (+5 -2)
📝 scripts/verify-real-ghidra-switch-controls.mjs (+4 -6)
📝 scripts/verify-real-ghidra-switch.mjs (+2 -3)
📝 src/application/SetupPlan.ts (+15 -17)
📝 src/application/runtime.ts (+6 -9)
📝 src/browser/PlaywrightBrowserScenarioProvider.ts (+1 -3)
📝 src/browser/PlaywrightElectronActiveActions.ts (+5 -7)
📝 src/browser/PlaywrightElectronActiveProvider.ts (+1 -3)

...and 5 more files

📄 Description

Formatting commands, staged-file hooks, and generated-document scripts previously used Prettier. This migrates them to pinned Oxfmt 0.72.0 and removes the direct Prettier dependency.

The committed configuration preserves the 80-column width and disables import and package sorting. Document generators share that configuration through a small adapter that reports formatter errors before writing output. The remaining source and documentation changes are formatting only; generated catalogs remain unchanged.

Validation:

  • npm run check:pr passed: 369 test files, 2,144 tests passed, 2 skipped; static and generated-document checks passed.
  • npm run docs:generate and git diff --check passed.
  • Reformatted implementation files retained equivalent syntax trees; generator smoke checks covered valid and malformed JSON.
  • A single local formatting-check measurement fell from 13.61 seconds with Prettier to 0.18 seconds with Oxfmt. This is a local measurement, not a general benchmark.
  • Real Hopper/Ghidra verification was not performed; provider behavior is unchanged.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/615 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `chore/migrate-oxfmt` --- ### 📝 Commits (1) - [`e91dbfe`](https://github.com/morluto/rea/commit/e91dbfe28035996921bd4661677d05a57b6a6d72) chore: migrate formatting to Oxfmt ### 📊 Changes **25 files changed** (+514 additions, -139 deletions) <details> <summary>View changed files</summary> ➕ `.oxfmtrc.json` (+15 -0) ➖ `.prettierignore` (+0 -8) 📝 `AGENTS.md` (+1 -1) 📝 `CONTRIBUTING.md` (+3 -1) 📝 `README_ar.md` (+19 -19) 📝 `docs/adr/0003-managed-code-evidence-and-provider-boundary.md` (+1 -1) 📝 `docs/native-investigation.md` (+1 -1) 📝 `package-lock.json` (+386 -17) 📝 `package.json` (+5 -5) 📝 `scripts/generate-error-schema.mjs` (+5 -4) 📝 `scripts/generate-mcp-tool-catalog.mjs` (+3 -3) ➕ `scripts/lib/format-generated-file.mjs` (+12 -0) 📝 `scripts/lib/product-catalog.mjs` (+5 -2) 📝 `scripts/verify-real-ghidra-switch-controls.mjs` (+4 -6) 📝 `scripts/verify-real-ghidra-switch.mjs` (+2 -3) 📝 `src/application/SetupPlan.ts` (+15 -17) 📝 `src/application/runtime.ts` (+6 -9) 📝 `src/browser/PlaywrightBrowserScenarioProvider.ts` (+1 -3) 📝 `src/browser/PlaywrightElectronActiveActions.ts` (+5 -7) 📝 `src/browser/PlaywrightElectronActiveProvider.ts` (+1 -3) _...and 5 more files_ </details> ### 📄 Description Formatting commands, staged-file hooks, and generated-document scripts previously used Prettier. This migrates them to pinned Oxfmt 0.72.0 and removes the direct Prettier dependency. The committed configuration preserves the 80-column width and disables import and package sorting. Document generators share that configuration through a small adapter that reports formatter errors before writing output. The remaining source and documentation changes are formatting only; generated catalogs remain unchanged. Validation: - `npm run check:pr` passed: 369 test files, 2,144 tests passed, 2 skipped; static and generated-document checks passed. - `npm run docs:generate` and `git diff --check` passed. - Reformatted implementation files retained equivalent syntax trees; generator smoke checks covered valid and malformed JSON. - A single local formatting-check measurement fell from 13.61 seconds with Prettier to 0.18 seconds with Oxfmt. This is a local measurement, not a general benchmark. - Real Hopper/Ghidra verification was not performed; provider behavior is unchanged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-16 21:14:29 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#2115
No description provided.