[PR #616] [MERGED] chore: remove tracked developer dependency symlink #2116

New issue

Closed

opened 2026-10-16 21:14:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:14:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/616
Author: @rudycelekli
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @N0zoM1z0

Base: main ← Head: campaign/rea-remove-tracked-dependency-link-20261005

📝 Commits (1)

d8431cc chore: remove tracked developer dependency symlink

📊 Changes

2 files changed (+1 additions, -2 deletions)

View changed files

📝 .gitignore (+1 -1)
➖ node_modules (+0 -1)

📄 Description

Summary

Remove the accidentally tracked developer-local node_modules symlink and make the existing dependency ignore rule cover both directories and symlinks.

This is a maintenance follow-up to the merged comparison PR. No issue is linked because it removes a reproduced generated-artifact mistake that directly violates the existing AGENTS.md rule; there is no new feature or design proposal.

Problem and expected behavior

Current main contains node_modules as a tracked mode-120000 symlink to a developer-local absolute path. That target does not exist in a fresh checkout on this host. Dependencies should be installed locally and remain untracked.

The existing node_modules/ ignore rule only matches directories, so an actual dependency symlink remains visible to Git and can be staged. Native git check-ignore -v node_modules exits 1 for the real link before the rule change and 0 afterward.

Change and scope

Delete the tracked dependency symlink.
Change the existing ignore pattern from node_modules/ to node_modules, covering the same generated dependency name whether it is a directory or a symlink.
Preserve all production code, contracts, lockfile contents and package metadata.

Contract and boundary impact

Semantic owner and earliest changed stage: repository checkout/generated dependency tracking.
CLI and MCP/tool-catalog contract: no changes.
Provider, bridge, target-format, or platform compatibility: no changes.
Evidence, artifact, provenance, or reconstruction contract: no production changes.
Process execution, authorization, cleanup, or containment impact: removes a repository-tracked generated link only; no runtime cleanup behavior added.
Generated metadata, package, or installation impact: dependency versions and metadata are unchanged; installs continue to create local ignored dependencies.

Evidence and regression coverage

Confirmed current-main Git tree entry: node_modules, mode 120000, developer-local absolute target; target absent on this host.
Confirmed final signed Git tree contains no tracked node_modules entry.
Actual symlink ignore proof: before exit 1, after exit 0 with .gitignore:10:node_modules.
Existing dependency installation boundary tests: four passed.
No new source tests added for this generated-artifact removal. No real Hopper, Ghidra, browser or native-provider support claims are made.

Validation performed

npm run test:focused -- tests/boundary/filesystem/dependencyInstall.test.ts — 4 passed; prerequisite build passed.
npm run check — passed, including current Oxfmt formatting, typecheck, lint, knip and metadata checks.
npm run check:fast — passed.
git check-ignore -v node_modules — passed on the actual dependency symlink.
Final tracked tree is clean; no dependencies/build outputs are included in the commit.

Current upstream warnings remain: 99 lint warnings, 0 errors, plus one knip configuration hint. The gates are not claimed warning-free. Current CONTRIBUTING makes the full local check:pr optional for narrow changes; no packaging/distribution or provider behavior changed.

Verification reused existing installed dependencies through a separate read-only overlay and installed only the current pinned Oxfmt version in an isolated cache. Active shared dependency environments were not changed.

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: not needed for Git tracking/ignore behavior.
Package or release metadata impact: none.
Security, privacy, process, or containment review: no secrets or new execution authority; the developer-local target is removed from tracked repository content.

Review checklist

One focused maintenance outcome and conventional title.
Reason for no linked issue stated above.
Native Git reproduction plus relevant existing tests executed.
No source/contract/generated metadata changes.
Final diff checked for unrelated changes and unsupported claims.

AI assistance was used for investigation and verification. The commit is signed and includes DCO sign-off.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/616 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `campaign/rea-remove-tracked-dependency-link-20261005` --- ### 📝 Commits (1) - [`d8431cc`](https://github.com/morluto/rea/commit/d8431ccd8f85632dcdfe2f4fe8aa3a1d170f2118) chore: remove tracked developer dependency symlink ### 📊 Changes **2 files changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) ➖ `node_modules` (+0 -1) </details> ### 📄 Description ## Summary Remove the accidentally tracked developer-local `node_modules` symlink and make the existing dependency ignore rule cover both directories and symlinks. This is a maintenance follow-up to the merged comparison PR. No issue is linked because it removes a reproduced generated-artifact mistake that directly violates the existing AGENTS.md rule; there is no new feature or design proposal. ## Problem and expected behavior Current main contains `node_modules` as a tracked mode-120000 symlink to a developer-local absolute path. That target does not exist in a fresh checkout on this host. Dependencies should be installed locally and remain untracked. The existing `node_modules/` ignore rule only matches directories, so an actual dependency symlink remains visible to Git and can be staged. Native `git check-ignore -v node_modules` exits 1 for the real link before the rule change and 0 afterward. ## Change and scope - Delete the tracked dependency symlink. - Change the existing ignore pattern from `node_modules/` to `node_modules`, covering the same generated dependency name whether it is a directory or a symlink. - Preserve all production code, contracts, lockfile contents and package metadata. ## Contract and boundary impact - Semantic owner and earliest changed stage: repository checkout/generated dependency tracking. - CLI and MCP/tool-catalog contract: no changes. - Provider, bridge, target-format, or platform compatibility: no changes. - Evidence, artifact, provenance, or reconstruction contract: no production changes. - Process execution, authorization, cleanup, or containment impact: removes a repository-tracked generated link only; no runtime cleanup behavior added. - Generated metadata, package, or installation impact: dependency versions and metadata are unchanged; installs continue to create local ignored dependencies. ## Evidence and regression coverage - Confirmed current-main Git tree entry: `node_modules`, mode 120000, developer-local absolute target; target absent on this host. - Confirmed final signed Git tree contains no tracked `node_modules` entry. - Actual symlink ignore proof: before exit 1, after exit 0 with `.gitignore:10:node_modules`. - Existing dependency installation boundary tests: four passed. - No new source tests added for this generated-artifact removal. No real Hopper, Ghidra, browser or native-provider support claims are made. ## Validation performed - `npm run test:focused -- tests/boundary/filesystem/dependencyInstall.test.ts` — 4 passed; prerequisite build passed. - `npm run check` — passed, including current Oxfmt formatting, typecheck, lint, knip and metadata checks. - `npm run check:fast` — passed. - `git check-ignore -v node_modules` — passed on the actual dependency symlink. - Final tracked tree is clean; no dependencies/build outputs are included in the commit. Current upstream warnings remain: 99 lint warnings, 0 errors, plus one knip configuration hint. The gates are not claimed warning-free. Current CONTRIBUTING makes the full local check:pr optional for narrow changes; no packaging/distribution or provider behavior changed. Verification reused existing installed dependencies through a separate read-only overlay and installed only the current pinned Oxfmt version in an isolated cache. Active shared dependency environments were not changed. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: not needed for Git tracking/ignore behavior. - Package or release metadata impact: none. - Security, privacy, process, or containment review: no secrets or new execution authority; the developer-local target is removed from tracked repository content. ## Review checklist - [x] One focused maintenance outcome and conventional title. - [x] Reason for no linked issue stated above. - [x] Native Git reproduction plus relevant existing tests executed. - [x] No source/contract/generated metadata changes. - [x] Final diff checked for unrelated changes and unsupported claims. AI assistance was used for investigation and verification. The commit is signed and includes DCO sign-off. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:14:30 +00:00