[PR #617] [MERGED] fix(repo): keep dependency links out of version control #2117

New issue

Closed

opened 2026-10-16 21:14:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:14:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/617
Author: @N0zoM1z0
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: fix/ignore-dependency-links

📝 Commits (1)

a3d40ff fix(repo): keep dependency links out of version control

📊 Changes

2 files changed (+1 additions, -2 deletions)

View changed files

📝 .gitignore (+1 -1)
➖ node_modules (+0 -1)

📄 Description

Changes

Fix the tracked absolute node_modules symlink introduced by #615. On this Linux checkout, dependency verification failed because the link points to a macOS workspace.

Remove the tracked link.
Ignore the basename node_modules, covering directories and symlinks. The previous trailing-slash rule ignored directories only and allowed a symlink to be committed.

Verification

Actual Git regression probe in an owned temporary repository: the old rule admits a dependency symlink; the new rule ignores the symlink and dependency-directory contents.
Locked dependencies reinstalled locally with the isolated Node switch; npm run deps:check passed.
npm run check:fast: typecheck/lint passed (16.913s).

Real Hopper/Ghidra verification was not run for this Git tracking change. The removed link itself was unlinked; its external target was not modified.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/617 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/ignore-dependency-links` --- ### 📝 Commits (1) - [`a3d40ff`](https://github.com/morluto/rea/commit/a3d40ff3d66145c80adac6c3c3ef7a4638dd7d07) fix(repo): keep dependency links out of version control ### 📊 Changes **2 files changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) ➖ `node_modules` (+0 -1) </details> ### 📄 Description ## Changes Fix the tracked absolute `node_modules` symlink introduced by #615. On this Linux checkout, dependency verification failed because the link points to a macOS workspace. - Remove the tracked link. - Ignore the basename `node_modules`, covering directories and symlinks. The previous trailing-slash rule ignored directories only and allowed a symlink to be committed. ## Verification - Actual Git regression probe in an owned temporary repository: the old rule admits a dependency symlink; the new rule ignores the symlink and dependency-directory contents. - Locked dependencies reinstalled locally with the isolated Node switch; `npm run deps:check` passed. - `npm run check:fast`: typecheck/lint passed (16.913s). Real Hopper/Ghidra verification was not run for this Git tracking change. The removed link itself was unlinked; its external target was not modified. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:14:30 +00:00