[PR #624] [MERGED] refactor(domain): consolidate canonical ordering and digest helpers #2120

New issue

Closed

opened 2026-10-16 21:14:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:14:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/624
Author: @morluto
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: cleanup/pr-1-canonical-helpers

📝 Commits (2)

bbd9db3 refactor(domain): consolidate canonical ordering and digest helpers
63557cd fix(ci): allow slower real browser startup

📊 Changes

74 files changed (+438 additions, -530 deletions)

View changed files

📝 scripts/verify-real-browser.mjs (+1 -1)
📝 src/application/ArtifactExtraction.ts (+3 -3)
📝 src/application/ArtifactGraphConstruction.ts (+24 -28)
📝 src/application/ArtifactInventory/scanCanonical.ts (+26 -17)
📝 src/application/BrowserScenarioEvidence.ts (+2 -2)
📝 src/application/DoctorScope.ts (+1 -3)
📝 src/application/ElectronActiveEvidence.ts (+5 -2)
📝 src/application/ElectronBoundaryAnalysis.ts (+1 -3)
📝 src/application/JavaScriptArtifactFiles.ts (+1 -3)
📝 src/application/JavaScriptJsonModules.ts (+1 -3)
📝 src/application/JavaScriptModuleRelationships.ts (+1 -3)
📝 src/application/JavaScriptSemanticGraphProjection.ts (+1 -1)
➖ src/browser/CdpCanonicalJsonDigest.ts (+0 -10)
📝 src/browser/CdpCaptureStorageFingerprints.ts (+1 -3)
📝 src/browser/CdpElectronInspection.ts (+2 -2)
📝 src/browser/CdpElectronScripts.ts (+2 -2)
📝 src/contracts/artifactComparisonExample.ts (+19 -23)
📝 src/domain/artifactInspection.ts (+24 -25)
📝 src/domain/artifactInventoryEvidence.ts (+60 -43)
📝 src/domain/browserScenarioDiff.ts (+0 -1)

...and 54 more files

📄 Description

Stack 1/7 (base: main).

Single owner for code-point ordering (domain/canonicalOrdering.ts) and canonical JSON digests (domain/comparisonSemantics.ts). Deletes all local compareCodePoints/compareText/digestCanonical duplicates and migrates every importer. No re-export shims. Deletes src/browser/CdpCanonicalJsonDigest.ts.

Verification: tsc clean, knip clean, jscpd 349 to 338 clones, focused tests pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/624 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/pr-1-canonical-helpers` --- ### 📝 Commits (2) - [`bbd9db3`](https://github.com/morluto/rea/commit/bbd9db37e231f86b0c07abaa1f50722a0f7af2cc) refactor(domain): consolidate canonical ordering and digest helpers - [`63557cd`](https://github.com/morluto/rea/commit/63557cd5fe618a9a1e77d88f9596bfc8d3044b4c) fix(ci): allow slower real browser startup ### 📊 Changes **74 files changed** (+438 additions, -530 deletions) <details> <summary>View changed files</summary> 📝 `scripts/verify-real-browser.mjs` (+1 -1) 📝 `src/application/ArtifactExtraction.ts` (+3 -3) 📝 `src/application/ArtifactGraphConstruction.ts` (+24 -28) 📝 `src/application/ArtifactInventory/scanCanonical.ts` (+26 -17) 📝 `src/application/BrowserScenarioEvidence.ts` (+2 -2) 📝 `src/application/DoctorScope.ts` (+1 -3) 📝 `src/application/ElectronActiveEvidence.ts` (+5 -2) 📝 `src/application/ElectronBoundaryAnalysis.ts` (+1 -3) 📝 `src/application/JavaScriptArtifactFiles.ts` (+1 -3) 📝 `src/application/JavaScriptJsonModules.ts` (+1 -3) 📝 `src/application/JavaScriptModuleRelationships.ts` (+1 -3) 📝 `src/application/JavaScriptSemanticGraphProjection.ts` (+1 -1) ➖ `src/browser/CdpCanonicalJsonDigest.ts` (+0 -10) 📝 `src/browser/CdpCaptureStorageFingerprints.ts` (+1 -3) 📝 `src/browser/CdpElectronInspection.ts` (+2 -2) 📝 `src/browser/CdpElectronScripts.ts` (+2 -2) 📝 `src/contracts/artifactComparisonExample.ts` (+19 -23) 📝 `src/domain/artifactInspection.ts` (+24 -25) 📝 `src/domain/artifactInventoryEvidence.ts` (+60 -43) 📝 `src/domain/browserScenarioDiff.ts` (+0 -1) _...and 54 more files_ </details> ### 📄 Description Stack 1/7 (base: main). Single owner for code-point ordering (domain/canonicalOrdering.ts) and canonical JSON digests (domain/comparisonSemantics.ts). Deletes all local compareCodePoints/compareText/digestCanonical duplicates and migrates every importer. No re-export shims. Deletes src/browser/CdpCanonicalJsonDigest.ts. Verification: tsc clean, knip clean, jscpd 349 to 338 clones, focused tests pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:14:35 +00:00