[PR #627] [MERGED] test: extract shared fixtures, drop knip carve-outs #2125

New issue

Closed

opened 2026-10-16 21:14:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:14:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/627
Author: @morluto
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: cleanup/pr-4-test-fixtures-knip

📝 Commits (5)

a8394b0 refactor(domain): consolidate canonical ordering and digest helpers (#624)
2794583 chore(config): remove dead eslint, dedupe scripts, cacheable turbo tasks
dad0aa9 fix(config): hash all test inputs for cached runs
7bf3870 docs: fix architecture diagram and pretty-print tool catalog
440268c test: extract shared fixtures, drop knip carve-outs

📊 Changes

21 files changed (+429 additions, -393 deletions)

View changed files

📝 .jscpd.json (+2 -2)
📝 .oxlintrc.json (+12 -1)
📝 docs/architecture.mermaid (+14 -3)
➖ eslint.config.js (+0 -28)
📝 knip.json (+1 -12)
📝 package.json (+2 -3)
📝 scripts/generate-mcp-tool-catalog.mjs (+2 -0)
📝 src/domain/mobileApplicationInvestigation.ts (+0 -1)
📝 src/domain/objcSwiftMetadata.ts (+0 -17)
📝 src/generatedMcpToolCatalog.ts (+1 -1)
📝 tests/composition/analysis-sessions/androidApplication.test.ts (+8 -12)
📝 tests/composition/analysis-sessions/appleApplication.test.ts (+8 -13)
📝 tests/composition/analysis-sessions/binarySession.test.ts (+48 -43)
📝 tests/composition/javascript-applications/javascriptArtifactReconstruction.test.ts (+29 -30)
📝 tests/composition/javascript-applications/javascriptBundlerAdapters.test.ts (+56 -80)
📝 tests/composition/javascript-applications/javascriptModuleRelationships.test.ts (+45 -121)
📝 tests/process-global/verifierRun.test.ts (+1 -21)
➕ tests/support/applicationSessionFixture.ts (+38 -0)
➕ tests/support/javascriptApplicationFixture.ts (+135 -0)
📝 tests/support/process/processFixture.ts (+4 -2)

...and 1 more files

📄 Description

Stack 4/7 (base: stack 3/7, merge in order).

Dedupes android/apple session tests, bundler adapter headers, and reconstruction helpers into tests/support fixtures. Deletes unused type aliases, removes the knip ignoreIssues block, lowers jscpd threshold 2.7 to 2.5. Verification: knip clean, 58/58 focused tests pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/627 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/pr-4-test-fixtures-knip` --- ### 📝 Commits (5) - [`a8394b0`](https://github.com/morluto/rea/commit/a8394b087156c55640b5b620aececf498b60e3a0) refactor(domain): consolidate canonical ordering and digest helpers (#624) - [`2794583`](https://github.com/morluto/rea/commit/2794583a0ea56b12839c1043f684c7b32ce6fc5d) chore(config): remove dead eslint, dedupe scripts, cacheable turbo tasks - [`dad0aa9`](https://github.com/morluto/rea/commit/dad0aa9578fa5a187cdc3c62d8b5adfeffa6df66) fix(config): hash all test inputs for cached runs - [`7bf3870`](https://github.com/morluto/rea/commit/7bf3870cd6fd642fd7a9039777ad6ea327e3ebd2) docs: fix architecture diagram and pretty-print tool catalog - [`440268c`](https://github.com/morluto/rea/commit/440268c04a91f79e7e784882577244c4e13c005c) test: extract shared fixtures, drop knip carve-outs ### 📊 Changes **21 files changed** (+429 additions, -393 deletions) <details> <summary>View changed files</summary> 📝 `.jscpd.json` (+2 -2) 📝 `.oxlintrc.json` (+12 -1) 📝 `docs/architecture.mermaid` (+14 -3) ➖ `eslint.config.js` (+0 -28) 📝 `knip.json` (+1 -12) 📝 `package.json` (+2 -3) 📝 `scripts/generate-mcp-tool-catalog.mjs` (+2 -0) 📝 `src/domain/mobileApplicationInvestigation.ts` (+0 -1) 📝 `src/domain/objcSwiftMetadata.ts` (+0 -17) 📝 `src/generatedMcpToolCatalog.ts` (+1 -1) 📝 `tests/composition/analysis-sessions/androidApplication.test.ts` (+8 -12) 📝 `tests/composition/analysis-sessions/appleApplication.test.ts` (+8 -13) 📝 `tests/composition/analysis-sessions/binarySession.test.ts` (+48 -43) 📝 `tests/composition/javascript-applications/javascriptArtifactReconstruction.test.ts` (+29 -30) 📝 `tests/composition/javascript-applications/javascriptBundlerAdapters.test.ts` (+56 -80) 📝 `tests/composition/javascript-applications/javascriptModuleRelationships.test.ts` (+45 -121) 📝 `tests/process-global/verifierRun.test.ts` (+1 -21) ➕ `tests/support/applicationSessionFixture.ts` (+38 -0) ➕ `tests/support/javascriptApplicationFixture.ts` (+135 -0) 📝 `tests/support/process/processFixture.ts` (+4 -2) _...and 1 more files_ </details> ### 📄 Description Stack 4/7 (base: stack 3/7, merge in order). Dedupes android/apple session tests, bundler adapter headers, and reconstruction helpers into tests/support fixtures. Deletes unused type aliases, removes the knip ignoreIssues block, lowers jscpd threshold 2.7 to 2.5. Verification: knip clean, 58/58 focused tests pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:14:39 +00:00