[PR #632] [MERGED] refactor(native): extract FAT header format switch in Mach-O slice selection #2129

New issue

Closed

opened 2026-10-16 21:14:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:14:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/632
Author: @morluto
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: cleanup/pr-0-fat-header-refactor

📝 Commits (1)

fdb7d3f refactor(native): extract FAT header format switch in Mach-O slice selection

📊 Changes

2 files changed (+28 additions, -4 deletions)

View changed files

📝 src/native/AppleDispatchMetadata.test.ts (+8 -0)
📝 src/native/AppleDispatchMetadata.ts (+20 -4)

📄 Description

Standalone (base: main, no stack dependency).

Replaces inline FAT-magic comparisons in selectMachoSlice with an exhaustive fatHeaderFormat switch and adds a regression test locking in rejection of 32-bit slice payloads inside little-endian containers.

Behavior-preserving: the new test passes 18/18 on the old implementation too. Follow-up to bede3e3c in the same area. Real-provider verification: not required (pure refactor, no behavior change); unit suite for the file passes 18/18.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/632 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/pr-0-fat-header-refactor` --- ### 📝 Commits (1) - [`fdb7d3f`](https://github.com/morluto/rea/commit/fdb7d3f08f1bbfade629005e654fb8dfcb5e62e5) refactor(native): extract FAT header format switch in Mach-O slice selection ### 📊 Changes **2 files changed** (+28 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/native/AppleDispatchMetadata.test.ts` (+8 -0) 📝 `src/native/AppleDispatchMetadata.ts` (+20 -4) </details> ### 📄 Description Standalone (base: main, no stack dependency). Replaces inline FAT-magic comparisons in selectMachoSlice with an exhaustive fatHeaderFormat switch and adds a regression test locking in rejection of 32-bit slice payloads inside little-endian containers. Behavior-preserving: the new test passes 18/18 on the old implementation too. Follow-up to bede3e3c in the same area. Real-provider verification: not required (pure refactor, no behavior change); unit suite for the file passes 18/18. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:14:39 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:01:05 +00:00

[PR #2133] [MERGED] fix(target): recognize binary plists by magic under any extension #5051

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2129

No description provided.

Rows
Columns