[PR #636] [MERGED] refactor(domain): split error taxonomy into thematic modules #2133

New issue

Closed

opened 2026-10-16 21:14:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:14:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/636
Author: @morluto
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: cleanup/split-errors

📝 Commits (1)

694df38 refactor(domain): split error taxonomy into thematic modules

📊 Changes

181 files changed (+872 additions, -907 deletions)

View changed files

📝 src/application/AnalysisClientCleanup.ts (+1 -1)
📝 src/application/AnalysisContextQueries.test.ts (+1 -1)
📝 src/application/AnalysisContextQueries.ts (+2 -2)
📝 src/application/AnalysisProvider.ts (+1 -1)
📝 src/application/AnalysisProviderEvaluation.ts (+1 -1)
📝 src/application/AnalysisProviderRegistry.test.ts (+3 -5)
📝 src/application/AnalysisProviderRegistry.ts (+2 -2)
📝 src/application/AnalysisSnapshotCache.ts (+3 -5)
📝 src/application/AnalysisSnapshotFiles.ts (+4 -1)
📝 src/application/AndroidApplicationService.ts (+1 -1)
📝 src/application/AppleApplicationService.ts (+1 -1)
📝 src/application/BinarySession.ts (+2 -4)
📝 src/application/BinarySessionExecution.ts (+4 -6)
📝 src/application/BinarySessionOpen.ts (+2 -4)
📝 src/application/BinarySessionPort.ts (+3 -5)
📝 src/application/BinarySessionRecords.ts (+3 -5)
📝 src/application/BinaryTargetResolver.ts (+1 -1)
📝 src/application/BrowserObservationPort.ts (+1 -1)
📝 src/application/BrowserObservationService.ts (+2 -4)
📝 src/application/BrowserScenarioCapturePort.ts (+1 -1)

...and 80 more files

📄 Description

Standalone (base: main, needs #634 merged first — it is).

Moves each error family out of domain/errors.ts into its own module (base, core, provider selection/adapter, browser observation, artifact, evidence, unknown registry, hopper, configuration) and relocates AnalysisErrorProjection to analysisErrorProjection. Migrates all 162 importers to the owning modules and deletes errors.ts. No re-export shims; behavior unchanged.

Full gate (Node 24): tsc clean, knip clean, format clean, docs:check clean, jscpd 2.39%, unit lanes 207 files / 1336 tests pass, boundary + acceptance 171 files / 867 tests pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/636 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/split-errors` --- ### 📝 Commits (1) - [`694df38`](https://github.com/morluto/rea/commit/694df38624b6c6885044d957328114b5fdcc8605) refactor(domain): split error taxonomy into thematic modules ### 📊 Changes **181 files changed** (+872 additions, -907 deletions) <details> <summary>View changed files</summary> 📝 `src/application/AnalysisClientCleanup.ts` (+1 -1) 📝 `src/application/AnalysisContextQueries.test.ts` (+1 -1) 📝 `src/application/AnalysisContextQueries.ts` (+2 -2) 📝 `src/application/AnalysisProvider.ts` (+1 -1) 📝 `src/application/AnalysisProviderEvaluation.ts` (+1 -1) 📝 `src/application/AnalysisProviderRegistry.test.ts` (+3 -5) 📝 `src/application/AnalysisProviderRegistry.ts` (+2 -2) 📝 `src/application/AnalysisSnapshotCache.ts` (+3 -5) 📝 `src/application/AnalysisSnapshotFiles.ts` (+4 -1) 📝 `src/application/AndroidApplicationService.ts` (+1 -1) 📝 `src/application/AppleApplicationService.ts` (+1 -1) 📝 `src/application/BinarySession.ts` (+2 -4) 📝 `src/application/BinarySessionExecution.ts` (+4 -6) 📝 `src/application/BinarySessionOpen.ts` (+2 -4) 📝 `src/application/BinarySessionPort.ts` (+3 -5) 📝 `src/application/BinarySessionRecords.ts` (+3 -5) 📝 `src/application/BinaryTargetResolver.ts` (+1 -1) 📝 `src/application/BrowserObservationPort.ts` (+1 -1) 📝 `src/application/BrowserObservationService.ts` (+2 -4) 📝 `src/application/BrowserScenarioCapturePort.ts` (+1 -1) _...and 80 more files_ </details> ### 📄 Description Standalone (base: main, needs #634 merged first — it is). Moves each error family out of domain/errors.ts into its own module (base, core, provider selection/adapter, browser observation, artifact, evidence, unknown registry, hopper, configuration) and relocates AnalysisErrorProjection to analysisErrorProjection. Migrates all 162 importers to the owning modules and deletes errors.ts. No re-export shims; behavior unchanged. Full gate (Node 24): tsc clean, knip clean, format clean, docs:check clean, jscpd 2.39%, unit lanes 207 files / 1336 tests pass, boundary + acceptance 171 files / 867 tests pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:14:42 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:01:05 +00:00

[PR #2133] [MERGED] fix(target): recognize binary plists by magic under any extension #5051

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2133

No description provided.

Rows
Columns