[PR #637] [MERGED] refactor(runtime): name all silent catch causes without changing diagnostics #2134

New issue

Closed

opened 2026-10-16 21:14:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:14:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/637
Author: @morluto
Created: 10/5/2026
Status: ✅ Merged
Merged: 10/5/2026
Merged by: @morluto

Base: main ← Head: cleanup/catch-sweep

📝 Commits (2)

694df38 refactor(domain): split error taxonomy into thematic modules
2cbc7fc refactor(runtime): name all silent catch causes without changing diagnostics

📊 Changes

231 files changed (+1235 additions, -1038 deletions)

View changed files

📝 src/application/AnalysisClientCleanup.ts (+1 -1)
📝 src/application/AnalysisContextQueries.test.ts (+1 -1)
📝 src/application/AnalysisContextQueries.ts (+2 -2)
📝 src/application/AnalysisProvider.ts (+1 -1)
📝 src/application/AnalysisProviderEvaluation.ts (+5 -3)
📝 src/application/AnalysisProviderRegistry.test.ts (+3 -5)
📝 src/application/AnalysisProviderRegistry.ts (+2 -2)
📝 src/application/AnalysisSnapshotCache.ts (+3 -5)
📝 src/application/AnalysisSnapshotFiles.ts (+4 -1)
📝 src/application/AndroidApplicationService.ts (+1 -1)
📝 src/application/AppleApplicationService.ts (+1 -1)
📝 src/application/ArtifactExtraction.ts (+5 -1)
📝 src/application/BinarySession.ts (+2 -4)
📝 src/application/BinarySessionExecution.ts (+4 -6)
📝 src/application/BinarySessionOpen.ts (+2 -4)
📝 src/application/BinarySessionPort.ts (+3 -5)
📝 src/application/BinarySessionRecords.ts (+9 -7)
📝 src/application/BinaryTargetResolver.ts (+1 -1)
📝 src/application/BrowserObservationPort.ts (+1 -1)
📝 src/application/BrowserObservationService.ts (+2 -4)

...and 80 more files

📄 Description

Stack (base: #636, merge in order).

Binds cause in every remaining bare catch and unhandled rejection across src/ (121 bare catches to zero; 24 unhandled rejections to 17, rest annotated or deferred below). Real failures preserve the cause for logging; best-effort cleanup carries an explicit comment. Caller-visible and Evidence strings are byte-identical — six interpolated messages from the first pass were reverted after boundary tests pinned the originals.

Deferred with reasons in code review: main/shutdown.ts:32, ghidra/GhidraRequestQueue.ts:151, ghidra/GhidraClient.ts:422, hopper/HopperCleanup.ts:107,140, hopper/HopperTargetLease.ts:38.

Verification (Node 24): tsc clean, knip clean, format clean, unit lanes 207 files / 1336 pass, boundary + acceptance 171 files / 867 pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/637 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/5/2026 **Status:** ✅ Merged **Merged:** 10/5/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/catch-sweep` --- ### 📝 Commits (2) - [`694df38`](https://github.com/morluto/rea/commit/694df38624b6c6885044d957328114b5fdcc8605) refactor(domain): split error taxonomy into thematic modules - [`2cbc7fc`](https://github.com/morluto/rea/commit/2cbc7fc305d6c59ed8346c56bca9b360010a3f41) refactor(runtime): name all silent catch causes without changing diagnostics ### 📊 Changes **231 files changed** (+1235 additions, -1038 deletions) <details> <summary>View changed files</summary> 📝 `src/application/AnalysisClientCleanup.ts` (+1 -1) 📝 `src/application/AnalysisContextQueries.test.ts` (+1 -1) 📝 `src/application/AnalysisContextQueries.ts` (+2 -2) 📝 `src/application/AnalysisProvider.ts` (+1 -1) 📝 `src/application/AnalysisProviderEvaluation.ts` (+5 -3) 📝 `src/application/AnalysisProviderRegistry.test.ts` (+3 -5) 📝 `src/application/AnalysisProviderRegistry.ts` (+2 -2) 📝 `src/application/AnalysisSnapshotCache.ts` (+3 -5) 📝 `src/application/AnalysisSnapshotFiles.ts` (+4 -1) 📝 `src/application/AndroidApplicationService.ts` (+1 -1) 📝 `src/application/AppleApplicationService.ts` (+1 -1) 📝 `src/application/ArtifactExtraction.ts` (+5 -1) 📝 `src/application/BinarySession.ts` (+2 -4) 📝 `src/application/BinarySessionExecution.ts` (+4 -6) 📝 `src/application/BinarySessionOpen.ts` (+2 -4) 📝 `src/application/BinarySessionPort.ts` (+3 -5) 📝 `src/application/BinarySessionRecords.ts` (+9 -7) 📝 `src/application/BinaryTargetResolver.ts` (+1 -1) 📝 `src/application/BrowserObservationPort.ts` (+1 -1) 📝 `src/application/BrowserObservationService.ts` (+2 -4) _...and 80 more files_ </details> ### 📄 Description Stack (base: #636, merge in order). Binds cause in every remaining bare catch and unhandled rejection across src/ (121 bare catches to zero; 24 unhandled rejections to 17, rest annotated or deferred below). Real failures preserve the cause for logging; best-effort cleanup carries an explicit comment. Caller-visible and Evidence strings are byte-identical — six interpolated messages from the first pass were reverted after boundary tests pinned the originals. Deferred with reasons in code review: main/shutdown.ts:32, ghidra/GhidraRequestQueue.ts:151, ghidra/GhidraClient.ts:422, hopper/HopperCleanup.ts:107,140, hopper/HopperTargetLease.ts:38. Verification (Node 24): tsc clean, knip clean, format clean, unit lanes 207 files / 1336 pass, boundary + acceptance 171 files / 867 pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:14:43 +00:00