[PR #670] [MERGED] fix(reference): preserve unresolved absolute module specifiers #2152

New issue

Closed

opened 2026-10-16 21:14:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:14:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/670
Author: @rudycelekli
Created: 10/6/2026
Status: ✅ Merged
Merged: 10/6/2026
Merged by: @morluto

Base: main ← Head: fix/rea-reference-absolute-imports-20261006

📝 Commits (1)

2ca6869 fix(reference): preserve unresolved absolute module specifiers

📊 Changes

2 files changed (+34 additions, -0 deletions)

View changed files

📝 src/application/ReferenceSourceImportEntries.ts (+2 -0)
📝 tests/boundary/filesystem/referenceSourceImport.test.ts (+32 -0)

📄 Description

Problem

Historical-source import treats an absolute module specifier as relative to its importing source file. With src/main.js importing both /outside/dep.js and ./outside/dep.js, and a local src/outside/dep.js, both observations collapse into one internal relationship. This falsely identifies the absolute import as that local member.

Change

Keep a POSIX absolute module specifier unresolved with its original spelling. Relative imports still resolve against the selected tree. This is a static source-graph correction; it does not resolve or execute host-absolute modules.

Verification

Baseline filesystem-boundary regression: 1 failure, 10 passing tests. Absolute import incorrectly becomes the relative internal edge.
After fix: npm run test:focused -- tests/boundary/filesystem/referenceSourceImport.test.ts: 11 passed. Both distinct edges survive, with the relative edge internal and the absolute edge unresolved.
npm run check: all five tasks passed (typecheck, lint, format, knip, metadata).
git diff --check: passed.
No schemas, generated metadata, packaging or provider behavior changed. No Hopper/Ghidra verification was run or is claimed.

AI-assisted implementation, reproduction and independent source review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/670 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/6/2026 **Status:** ✅ Merged **Merged:** 10/6/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/rea-reference-absolute-imports-20261006` --- ### 📝 Commits (1) - [`2ca6869`](https://github.com/morluto/rea/commit/2ca6869a3849a1f6f1431dc3c7ffaf74ec53c1e0) fix(reference): preserve unresolved absolute module specifiers ### 📊 Changes **2 files changed** (+34 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/application/ReferenceSourceImportEntries.ts` (+2 -0) 📝 `tests/boundary/filesystem/referenceSourceImport.test.ts` (+32 -0) </details> ### 📄 Description ## Problem Historical-source import treats an absolute module specifier as relative to its importing source file. With `src/main.js` importing both `/outside/dep.js` and `./outside/dep.js`, and a local `src/outside/dep.js`, both observations collapse into one internal relationship. This falsely identifies the absolute import as that local member. ## Change Keep a POSIX absolute module specifier unresolved with its original spelling. Relative imports still resolve against the selected tree. This is a static source-graph correction; it does not resolve or execute host-absolute modules. ## Verification - Baseline filesystem-boundary regression: 1 failure, 10 passing tests. Absolute import incorrectly becomes the relative internal edge. - After fix: `npm run test:focused -- tests/boundary/filesystem/referenceSourceImport.test.ts`: 11 passed. Both distinct edges survive, with the relative edge internal and the absolute edge unresolved. - `npm run check`: all five tasks passed (typecheck, lint, format, knip, metadata). - `git diff --check`: passed. - No schemas, generated metadata, packaging or provider behavior changed. No Hopper/Ghidra verification was run or is claimed. AI-assisted implementation, reproduction and independent source review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:14:57 +00:00