[PR #680] [CLOSED] fix(browser): retain all literal worker import arguments #2162

New issue

Closed

opened 2026-10-16 21:15:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:15:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/680
Author: @rudycelekli
Created: 10/6/2026
Status: ❌ Closed

Base: main ← Head: fix/rea-worker-import-arguments-20261006

📝 Commits (1)

d036d56 fix(browser): retain all literal worker import arguments

📊 Changes

2 files changed (+19 additions, -11 deletions)

View changed files

📝 src/domain/webBundleAnalyzer.test.ts (+13 -0)
📝 src/domain/webBundleAnalyzerInspection.ts (+6 -11)

📄 Description

What changed

Captured JavaScript dependency inspection now retains every literal argument of importScripts, in source order. Dynamic arguments remain unresolved and the existing deduplication still prevents repeated edges.

Consumer evidence

On an owned loopback page captured by actual Chrome 154, the complete public CdpBrowserProvider.analyzeBundle workflow previously recorded only one.js from importScripts("one.js", "two.js"). It now records both worker dependency edges. This verifies captured-source dependency analysis; it does not claim execution of the worker function.

Verification

New multi-argument/dynamic/dedup regression fails before, passes after; focused analyzer suite: 8 passed.
npm run check, npm run check:fast, git diff --check: passed.
Full npm run verify:browser: passed with real Chrome, including public browser/CLI/stdio workflows.
Complete public provider capture and ordered-edge assertions: passed.

No new tool, schema or execution authority. Hopper/Ghidra verification was not run because no binary provider behavior changes. AI assistance was used for investigation, implementation and verification. Hosted checks are pending on publication.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/680 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/6/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/rea-worker-import-arguments-20261006` --- ### 📝 Commits (1) - [`d036d56`](https://github.com/morluto/rea/commit/d036d567252906025d0b94a302285fa3c0a82727) fix(browser): retain all literal worker import arguments ### 📊 Changes **2 files changed** (+19 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/webBundleAnalyzer.test.ts` (+13 -0) 📝 `src/domain/webBundleAnalyzerInspection.ts` (+6 -11) </details> ### 📄 Description ## What changed Captured JavaScript dependency inspection now retains every literal argument of `importScripts`, in source order. Dynamic arguments remain unresolved and the existing deduplication still prevents repeated edges. ## Consumer evidence On an owned loopback page captured by actual Chrome 154, the complete public `CdpBrowserProvider.analyzeBundle` workflow previously recorded only `one.js` from `importScripts("one.js", "two.js")`. It now records both worker dependency edges. This verifies captured-source dependency analysis; it does not claim execution of the worker function. ## Verification - New multi-argument/dynamic/dedup regression fails before, passes after; focused analyzer suite: 8 passed. - `npm run check`, `npm run check:fast`, `git diff --check`: passed. - Full `npm run verify:browser`: passed with real Chrome, including public browser/CLI/stdio workflows. - Complete public provider capture and ordered-edge assertions: passed. No new tool, schema or execution authority. Hopper/Ghidra verification was not run because no binary provider behavior changes. AI assistance was used for investigation, implementation and verification. Hosted checks are pending on publication. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:15:04 +00:00