[PR #682] [MERGED] fix(cli): disable unmanaged skill synchronization #2164

New issue

Closed

opened 2026-10-16 21:15:05 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:15:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/682
Author: @kaoru0822-kitauji
Created: 10/6/2026
Status: ✅ Merged
Merged: 10/6/2026
Merged by: @kaoru0822-kitauji

Base: main ← Head: fix/disable-unmanaged-skill-sync

📝 Commits (1)

2c1bf92 fix(cli): disable unmanaged skill synchronization

📊 Changes

4 files changed (+55 additions, -22 deletions)

View changed files

📝 package-lock.json (+23 -11)
📝 package.json (+1 -1)
📝 src/cli.ts (+1 -10)
➕ tests/boundary/cli/skillSync.test.ts (+30 -0)

📄 Description

Summary

upgrade Incur to 0.6.1, the first published release with an explicit generated-skill opt-out
set sync: false so REA exposes only its managed setup/uninstall lifecycle instead of Incur's independent skills add
add a compiled-CLI regression covering help output, command rejection, and an untouched isolated home

Reproduction and behavior

On current main, rea skills add bypasses REA's setup plan and replaces the managed five-file reverse-engineer-anything skill with a SKILL.md-only copy. It can also generate command-skill folders, agent links, and a manifest that rea uninstall does not own.

With this change, rea skills add returns COMMAND_NOT_FOUND, the command is absent from root help, and no files are written. rea setup remains the canonical skill installer; its existing setup and skill tests pass.

Closes #660.
Closes #661.

Validation

Passed:

npm ci --ignore-scripts
focused boundary coverage: 22/22 tests across skill sync, setup, setup-skill, and product catalog
npm run lint
targeted oxfmt --check
npm run knip
npm run metadata:check
TypeScript typecheck and build via typescript@5.9.3
npm run docs:check:built
npm pack --dry-run --ignore-scripts
git diff --check

The full Vitest run completed with 2,179 passing tests and 95 failures. The failures require capabilities unavailable in the execution sandbox (mounted /proc, OS process inspection, Unix-socket listeners, and an absolute process.execPath); none touched this change's path.

Material unverified coverage

The repository's native TypeScript 7 compiler could not execute because the sandbox has no /proc/self/exe. Therefore npm run build:cached, the prepack hook, and their wrapper commands could not be run verbatim; the JavaScript TypeScript compiler fallback, direct built-doc checks, focused compiled-CLI tests, and script-free package dry run were used instead.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/682 **Author:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Created:** 10/6/2026 **Status:** ✅ Merged **Merged:** 10/6/2026 **Merged by:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Base:** `main` ← **Head:** `fix/disable-unmanaged-skill-sync` --- ### 📝 Commits (1) - [`2c1bf92`](https://github.com/morluto/rea/commit/2c1bf9201040ed3d60f475af9129b7bf85a508fa) fix(cli): disable unmanaged skill synchronization ### 📊 Changes **4 files changed** (+55 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+23 -11) 📝 `package.json` (+1 -1) 📝 `src/cli.ts` (+1 -10) ➕ `tests/boundary/cli/skillSync.test.ts` (+30 -0) </details> ### 📄 Description ## Summary - upgrade Incur to 0.6.1, the first published release with an explicit generated-skill opt-out - set `sync: false` so REA exposes only its managed `setup`/`uninstall` lifecycle instead of Incur's independent `skills add` - add a compiled-CLI regression covering help output, command rejection, and an untouched isolated home ## Reproduction and behavior On current `main`, `rea skills add` bypasses REA's setup plan and replaces the managed five-file `reverse-engineer-anything` skill with a `SKILL.md`-only copy. It can also generate command-skill folders, agent links, and a manifest that `rea uninstall` does not own. With this change, `rea skills add` returns `COMMAND_NOT_FOUND`, the command is absent from root help, and no files are written. `rea setup` remains the canonical skill installer; its existing setup and skill tests pass. Closes #660. Closes #661. ## Validation Passed: - `npm ci --ignore-scripts` - focused boundary coverage: 22/22 tests across skill sync, setup, setup-skill, and product catalog - `npm run lint` - targeted `oxfmt --check` - `npm run knip` - `npm run metadata:check` - TypeScript typecheck and build via `typescript@5.9.3` - `npm run docs:check:built` - `npm pack --dry-run --ignore-scripts` - `git diff --check` The full Vitest run completed with 2,179 passing tests and 95 failures. The failures require capabilities unavailable in the execution sandbox (mounted `/proc`, OS process inspection, Unix-socket listeners, and an absolute `process.execPath`); none touched this change's path. ## Material unverified coverage The repository's native TypeScript 7 compiler could not execute because the sandbox has no `/proc/self/exe`. Therefore `npm run build:cached`, the prepack hook, and their wrapper commands could not be run verbatim; the JavaScript TypeScript compiler fallback, direct built-doc checks, focused compiled-CLI tests, and script-free package dry run were used instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:15:05 +00:00