[PR #687] [CLOSED] fix(javascript): keep optional parameter input unknown #2169

New issue

Closed

opened 2026-10-16 21:15:09 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:15:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/687
Author: @rudycelekli
Created: 10/6/2026
Status: ❌ Closed

Base: main ← Head: fix/rea-default-inputs-20261006

📝 Commits (1)

282f82a fix(javascript): keep optional parameter input unknown

📊 Changes

2 files changed (+33 additions, -1 deletions)

View changed files

📝 src/domain/javascriptSemanticAnalysis.dataflow.test.ts (+29 -0)
📝 src/domain/javascriptSemanticAnalysis.ts (+4 -1)

📄 Description

What changed

Optional function parameters now retain unknown caller input instead of assuming their default expression was selected. This covers scalar, object-destructured, and array-destructured defaults. Concrete declaration inputs remain recoverable; catch bindings remain conservative.

Consumer evidence

The complete built public analyzeJavaScriptApplication workflow previously emitted an exact exported return field /mode: "safe" for launch(mode = "safe"). Native Node returns "fast" when a caller supplies that value. After the repair, the public return-shape projection keeps /mode unknown, while an unrelated guaranteed literal field stays exact. Native omitted-argument and caught-input controls were also exercised; the catch control was already unknown before this patch.

Verification

Three new optional-parameter regressions fail before the patch and pass after.
Focused semantic dataflow/structure, public semantic graph and export comparison suites: 66 passed.
npm run check, npm run check:fast, npm run build:cached, git diff --check: passed.
Complete built public application return-shape/native Node comparison: passed.

No new tool, schema or execution authority. Hopper/Ghidra verification was not run because no binary provider behavior changes. AI assistance was used for investigation, implementation and verification. Hosted checks are pending on publication.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/687 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/6/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/rea-default-inputs-20261006` --- ### 📝 Commits (1) - [`282f82a`](https://github.com/morluto/rea/commit/282f82a7c19af3bec537ff60352822bf2084acf2) fix(javascript): keep optional parameter input unknown ### 📊 Changes **2 files changed** (+33 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascriptSemanticAnalysis.dataflow.test.ts` (+29 -0) 📝 `src/domain/javascriptSemanticAnalysis.ts` (+4 -1) </details> ### 📄 Description ## What changed Optional function parameters now retain unknown caller input instead of assuming their default expression was selected. This covers scalar, object-destructured, and array-destructured defaults. Concrete declaration inputs remain recoverable; catch bindings remain conservative. ## Consumer evidence The complete built public `analyzeJavaScriptApplication` workflow previously emitted an exact exported return field `/mode: "safe"` for `launch(mode = "safe")`. Native Node returns `"fast"` when a caller supplies that value. After the repair, the public return-shape projection keeps `/mode` unknown, while an unrelated guaranteed literal field stays exact. Native omitted-argument and caught-input controls were also exercised; the catch control was already unknown before this patch. ## Verification - Three new optional-parameter regressions fail before the patch and pass after. - Focused semantic dataflow/structure, public semantic graph and export comparison suites: 66 passed. - `npm run check`, `npm run check:fast`, `npm run build:cached`, `git diff --check`: passed. - Complete built public application return-shape/native Node comparison: passed. No new tool, schema or execution authority. Hopper/Ghidra verification was not run because no binary provider behavior changes. AI assistance was used for investigation, implementation and verification. Hosted checks are pending on publication. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:15:09 +00:00