[PR #730] [CLOSED] docs(hopper): validate realpath fallback wording #2198

New issue

Closed

opened 2026-10-16 21:15:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:15:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/730
Author: @N0zoM1z0
Created: 10/6/2026
Status: ❌ Closed

Base: main ← Head: review/pr-711-realpath-fallback-wording

📝 Commits (2)

6847bc9 docs(hopper): document HopperTargetLease realpath fallback
c2f5fc6 docs(hopper): clarify realpath fallback scope

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 src/hopper/HopperTargetLease.ts (+6 -0)

📄 Description

CI-only validation for the follow-up commit to #711.

This branch is derived directly from #711 head 6847bc947316e43ff0e0af99ab75752cfabe40dd and adds one comment-only follow-up commit:

clarifies that the normal Hopper path already supplies a readable canonical target;
states that direct callers / filesystem changes are why the defensive realpath can still matter;
accurately documents that any realpath failure falls back;
records both consequences: the original filesystem error is discarded and aliases can take separate leases.

Do not merge this draft PR. It exists only to run the repository CI because the connected GitHub App cannot write to the contributor fork even though #711 allows maintainer edits.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/730 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/6/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `review/pr-711-realpath-fallback-wording` --- ### 📝 Commits (2) - [`6847bc9`](https://github.com/morluto/rea/commit/6847bc947316e43ff0e0af99ab75752cfabe40dd) docs(hopper): document HopperTargetLease realpath fallback - [`c2f5fc6`](https://github.com/morluto/rea/commit/c2f5fc661291216174c5dfb7357f201344290d18) docs(hopper): clarify realpath fallback scope ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/hopper/HopperTargetLease.ts` (+6 -0) </details> ### 📄 Description CI-only validation for the follow-up commit to #711. This branch is derived directly from #711 head `6847bc947316e43ff0e0af99ab75752cfabe40dd` and adds one comment-only follow-up commit: - clarifies that the normal Hopper path already supplies a readable canonical target; - states that direct callers / filesystem changes are why the defensive `realpath` can still matter; - accurately documents that **any** `realpath` failure falls back; - records both consequences: the original filesystem error is discarded and aliases can take separate leases. **Do not merge this draft PR.** It exists only to run the repository CI because the connected GitHub App cannot write to the contributor fork even though #711 allows maintainer edits. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:15:33 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2198

No description provided.

Rows
Columns