[PR #768] [CLOSED] fix(doctor): validate Node-wrapped client policy #2227

New issue

Closed

opened 2026-10-16 21:15:58 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:15:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/768
Author: @rudycelekli
Created: 10/6/2026
Status: ❌ Closed

Base: main ← Head: fix/doctor-node-client-policy-20261006

📝 Commits (1)

0924436 fix(doctor): validate Node-wrapped client policy

📊 Changes

2 files changed (+63 additions, -8 deletions)

View changed files

📝 src/application/ClientRegistrationStatus.ts (+7 -7)
📝 tests/boundary/filesystem/clientRegistrationStatus.test.ts (+56 -1)

📄 Description

Problem

Client-registration inspection returns early for a Node-wrapped REA command, bypassing the client-specific alignment checks. As a result, rea doctor --client codex reports a one-second startup timeout as healthy; Copilot registrations with a narrower tool selection similarly evade the existing policy check.

Change

Apply the existing client-specific checks before accepting the Node launcher shape. Ownership, disabled-state checks, accepted launcher forms, and registration-writing behavior are unchanged.

Evidence and verification

Actual built public doctor, isolated owned HOME and real TOML config: before the one-second registration reports healthy/aligned; after it reports config_drift/stale and exits 1. The valid 30-second control remains healthy and exits 0.
Regression baseline: two failures and eleven passing controls using real TOML/JSON files.
After: 42 focused registration/lifecycle/dialect tests pass.
npm run check and check:fast pass (125 existing warnings, zero errors).
Complete npm run verify:package passes: actual isolated npm-packed installation, CLI/MCP discovery and analysis, setup/backup/readback/update/startup checks. No user-global installation was changed.

AI-assisted implementation, independently reviewed; signed commit with DCO. This verifies REA's configuration assessment, not a running Codex or Copilot client session.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/768 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/6/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/doctor-node-client-policy-20261006` --- ### 📝 Commits (1) - [`0924436`](https://github.com/morluto/rea/commit/092443663bd2c23a2d9f9473c2377c823b1e473b) fix(doctor): validate Node-wrapped client policy ### 📊 Changes **2 files changed** (+63 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/application/ClientRegistrationStatus.ts` (+7 -7) 📝 `tests/boundary/filesystem/clientRegistrationStatus.test.ts` (+56 -1) </details> ### 📄 Description ## Problem Client-registration inspection returns early for a Node-wrapped REA command, bypassing the client-specific alignment checks. As a result, `rea doctor --client codex` reports a one-second startup timeout as healthy; Copilot registrations with a narrower tool selection similarly evade the existing policy check. ## Change Apply the existing client-specific checks before accepting the Node launcher shape. Ownership, disabled-state checks, accepted launcher forms, and registration-writing behavior are unchanged. ## Evidence and verification - Actual built public doctor, isolated owned HOME and real TOML config: before the one-second registration reports healthy/aligned; after it reports config_drift/stale and exits 1. The valid 30-second control remains healthy and exits 0. - Regression baseline: two failures and eleven passing controls using real TOML/JSON files. - After: 42 focused registration/lifecycle/dialect tests pass. - npm run check and check:fast pass (125 existing warnings, zero errors). - Complete npm run verify:package passes: actual isolated npm-packed installation, CLI/MCP discovery and analysis, setup/backup/readback/update/startup checks. No user-global installation was changed. AI-assisted implementation, independently reviewed; signed commit with DCO. This verifies REA's configuration assessment, not a running Codex or Copilot client session. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:15:58 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:03:53 +00:00

[PR #2227] [CLOSED] test(targets): cover bounded executable header readers #5096

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2227

No description provided.

Rows
Columns