[PR #818] [MERGED] fix: address review nits from batch integration follow-ups #2263

New issue

Closed

opened 2026-10-16 21:16:27 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:16:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/818
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: fix/review-nits-20261007

📝 Commits (1)

ec744f4 fix: address review nits from batch integration follow-ups

📊 Changes

9 files changed (+180 additions, -71 deletions)

View changed files

📝 src/application/BinaryTargetResolver.ts (+1 -0)
📝 src/application/ReconstructionObligationCandidates.test.ts (+96 -61)
📝 src/browser/CdpSafeMetadata.ts (+2 -1)
📝 src/browser/CdpWebMcpDiscovery.ts (+2 -0)
📝 src/ghidra/extensions/GhidraExtensions.test.ts (+2 -2)
📝 src/ghidra/extensions/nativeaot/NativeAotReport.ts (+8 -7)
📝 tests/boundary/filesystem/clientRegistrationStatus.test.ts (+19 -0)
📝 tests/boundary/filesystem/referenceSourceFailureDetails.test.ts (+25 -0)
📝 tests/boundary/providers/native/nativeTextRobustness.test.ts (+25 -0)

📄 Description

Summary

Follow-up to the #815 batch integration and the per-PR reviews. Applies the actionable nits; #771 (release-please) intentionally untouched.

browser referrer policy: empty tokens rejected structurally (+ regex) while still skipped per W3 fallback semantics — the naive + broke origin,, no-referrer, now covered.
browser WebMCP: documents that keys cannot collapse since unknown frames are excluded before keying.
ghidra NativeAOT: splits the non-recovery diagnostic into reason-missing vs payload-present variants, asserted exactly.
reference: locks secret-patterned exclusion before failure projection.
doctor: locks direct-launcher Codex timeout ordering both ways.
native: plutil -n platform note; fat-output control guarding the thin pre-scan.
reconstruction: multi-unknown limitation coverage via a shared fixture helper (also fixes a max-lines-per-function lint).

Verification

npm run check: 5 tasks passed; check:fast passed.
95 focused tests passed across the 7 touched test files.

Tracks #817 for the remaining smol-toml advisory left out of #785.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/818 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/review-nits-20261007` --- ### 📝 Commits (1) - [`ec744f4`](https://github.com/morluto/rea/commit/ec744f40b45e6474cdec314afc5123084a0c6194) fix: address review nits from batch integration follow-ups ### 📊 Changes **9 files changed** (+180 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `src/application/BinaryTargetResolver.ts` (+1 -0) 📝 `src/application/ReconstructionObligationCandidates.test.ts` (+96 -61) 📝 `src/browser/CdpSafeMetadata.ts` (+2 -1) 📝 `src/browser/CdpWebMcpDiscovery.ts` (+2 -0) 📝 `src/ghidra/extensions/GhidraExtensions.test.ts` (+2 -2) 📝 `src/ghidra/extensions/nativeaot/NativeAotReport.ts` (+8 -7) 📝 `tests/boundary/filesystem/clientRegistrationStatus.test.ts` (+19 -0) 📝 `tests/boundary/filesystem/referenceSourceFailureDetails.test.ts` (+25 -0) 📝 `tests/boundary/providers/native/nativeTextRobustness.test.ts` (+25 -0) </details> ### 📄 Description ## Summary Follow-up to the #815 batch integration and the per-PR reviews. Applies the actionable nits; #771 (release-please) intentionally untouched. - browser referrer policy: empty tokens rejected structurally (`+` regex) while still skipped per W3 fallback semantics — the naive `+` broke `origin,, no-referrer`, now covered. - browser WebMCP: documents that keys cannot collapse since unknown frames are excluded before keying. - ghidra NativeAOT: splits the non-recovery diagnostic into reason-missing vs payload-present variants, asserted exactly. - reference: locks secret-patterned exclusion before failure projection. - doctor: locks direct-launcher Codex timeout ordering both ways. - native: plutil `-n` platform note; fat-output control guarding the thin pre-scan. - reconstruction: multi-unknown limitation coverage via a shared fixture helper (also fixes a max-lines-per-function lint). ## Verification - npm run check: 5 tasks passed; check:fast passed. - 95 focused tests passed across the 7 touched test files. Tracks #817 for the remaining smol-toml advisory left out of #785. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:16:27 +00:00