[PR #823] [MERGED] refactor(domain): consolidate property-key extraction behind semanticStaticPropertyKey #2265

New issue

Closed

opened 2026-10-16 21:16:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:16:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/823
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: cleanup/property-keys

📝 Commits (1)

f3e3183 refactor(domain): consolidate property-key extraction behind semanticStaticPropertyKey

📊 Changes

8 files changed (+54 additions, -84 deletions)

View changed files

📝 src/domain/electronStaticAnalysisBrowser.ts (+2 -2)
📝 src/domain/electronStaticAnalysisValues.ts (+2 -5)
📝 src/domain/javascriptSemanticMemberMutations.ts (+14 -12)
📝 src/domain/javascriptSemanticProjection.ts (+4 -8)
📝 src/domain/javascriptSemanticValues.ts (+6 -10)
📝 src/domain/webBundleAnalyzer.test.ts (+20 -0)
📝 src/domain/webBundleAnalyzerAst.ts (+1 -44)
📝 src/domain/webBundleAnalyzerInspection.ts (+5 -3)

📄 Description

Summary

Area 1 of the duplicate-ownership cleanup. One canonical exact-key owner (semanticStaticPropertyKey in javascriptAstValues.ts); all private wrappers inlined or deleted.

Inline propertyKey (MemberMutations), memberKey (Projection, Values) to direct canonical calls. Zero behavior change.
Migrate electron Browser/Values member keys off legacy propertyName (provably identical: both sites retain an explicit property.computed guard).
Delegate bundle calleeName/endpointArgument/stringArgument to the static helpers. Observable delta, all additions: bundle now recognizes loadURL endpoints and keeps nested-dynamic-receiver parity; dynamic-key fabrication stays excluded in both.
Remaining computed-identifier forks in electron Native/Ipc need composition-level regressions first — tracked in #822.

Verification

New bundle parity regressions failed before the delegation (loadURL) and pass after; nested-receiver parity locked.
Semantic suites (mutations, empty keys, graph builder, builtins, promises, reference import): 111/111.
Electron composition suites + bundle suite green.
npm run check: 5/5.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/823 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/property-keys` --- ### 📝 Commits (1) - [`f3e3183`](https://github.com/morluto/rea/commit/f3e3183b1e593feb3cf324e2e81ddec9141c8491) refactor(domain): consolidate property-key extraction behind semanticStaticPropertyKey ### 📊 Changes **8 files changed** (+54 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/electronStaticAnalysisBrowser.ts` (+2 -2) 📝 `src/domain/electronStaticAnalysisValues.ts` (+2 -5) 📝 `src/domain/javascriptSemanticMemberMutations.ts` (+14 -12) 📝 `src/domain/javascriptSemanticProjection.ts` (+4 -8) 📝 `src/domain/javascriptSemanticValues.ts` (+6 -10) 📝 `src/domain/webBundleAnalyzer.test.ts` (+20 -0) 📝 `src/domain/webBundleAnalyzerAst.ts` (+1 -44) 📝 `src/domain/webBundleAnalyzerInspection.ts` (+5 -3) </details> ### 📄 Description ## Summary Area 1 of the duplicate-ownership cleanup. One canonical exact-key owner (`semanticStaticPropertyKey` in `javascriptAstValues.ts`); all private wrappers inlined or deleted. - Inline `propertyKey` (MemberMutations), `memberKey` (Projection, Values) to direct canonical calls. Zero behavior change. - Migrate electron Browser/Values member keys off legacy `propertyName` (provably identical: both sites retain an explicit `property.computed` guard). - Delegate bundle `calleeName`/`endpointArgument`/`stringArgument` to the static helpers. Observable delta, all additions: bundle now recognizes `loadURL` endpoints and keeps nested-dynamic-receiver parity; dynamic-key fabrication stays excluded in both. - Remaining computed-identifier forks in electron Native/Ipc need composition-level regressions first — tracked in #822. ## Verification - New bundle parity regressions failed before the delegation (loadURL) and pass after; nested-receiver parity locked. - Semantic suites (mutations, empty keys, graph builder, builtins, promises, reference import): 111/111. - Electron composition suites + bundle suite green. - npm run check: 5/5. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:16:30 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:04:11 +00:00

[PR #2265] [MERGED] fix(browser): give the DevToolsActivePort wait one deadline owner #5128

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2265

No description provided.

Rows
Columns