[PR #824] [MERGED] refactor(domain): converge comparison mechanics on shared vocabulary #2267

New issue

Closed

opened 2026-10-16 21:16:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:16:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/824
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: cleanup/comparison-pipelines

📝 Commits (1)

3b98efe refactor(domain): converge comparison mechanics on shared vocabulary

📊 Changes

4 files changed (+161 additions, -12 deletions)

View changed files

📝 src/domain/bundleComparison.ts (+2 -1)
➕ src/domain/comparisonStatus.test.ts (+86 -0)
➕ src/domain/comparisonStatus.ts (+70 -0)
📝 src/domain/functionComparisonNormalization.ts (+3 -11)

📄 Description

Summary

Area 2 of the duplicate-ownership cleanup.

Delete the private canonicalJson duplicate in functionComparisonNormalization in favor of comparisonSemantics.canonicalJson (identical bytes via the context parameter).
Add domain/comparisonStatus.ts as the single owner of the canonical unchanged/changed/unknown triple and conclusion vocabulary, with mappers pinning every pipeline-native status (bundle, source-to-bundle, function incl. truncated, scenario artifacts).
Adopt the shared triple schema where wire-identical (bundle result status, scenario overall/step statuses). Native detail enums, collation choices (localeCompare tie-breaks, rule-id ordering), and all wire schemas otherwise untouched.

Verification

New mapping table tests pin every native status value.
Bundle, scenario-diff, function, and MCP comparison suites green.
npm run check: 5/5.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/824 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/comparison-pipelines` --- ### 📝 Commits (1) - [`3b98efe`](https://github.com/morluto/rea/commit/3b98efe450cfdcc04e4f41f106338273603e311a) refactor(domain): converge comparison mechanics on shared vocabulary ### 📊 Changes **4 files changed** (+161 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/bundleComparison.ts` (+2 -1) ➕ `src/domain/comparisonStatus.test.ts` (+86 -0) ➕ `src/domain/comparisonStatus.ts` (+70 -0) 📝 `src/domain/functionComparisonNormalization.ts` (+3 -11) </details> ### 📄 Description ## Summary Area 2 of the duplicate-ownership cleanup. - Delete the private `canonicalJson` duplicate in `functionComparisonNormalization` in favor of `comparisonSemantics.canonicalJson` (identical bytes via the context parameter). - Add `domain/comparisonStatus.ts` as the single owner of the canonical unchanged/changed/unknown triple and conclusion vocabulary, with mappers pinning every pipeline-native status (bundle, source-to-bundle, function incl. truncated, scenario artifacts). - Adopt the shared triple schema where wire-identical (bundle result status, scenario overall/step statuses). Native detail enums, collation choices (`localeCompare` tie-breaks, rule-id ordering), and all wire schemas otherwise untouched. ## Verification - New mapping table tests pin every native status value. - Bundle, scenario-diff, function, and MCP comparison suites green. - npm run check: 5/5. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:16:30 +00:00