[PR #830] [MERGED] refactor(domain): extract artifact path syntax helpers #2270

New issue

Closed

opened 2026-10-16 21:16:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:16:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/830
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: cleanup/path-resolution

📝 Commits (1)

7791846 refactor(domain): extract artifact path syntax helpers

📊 Changes

4 files changed (+89 additions, -21 deletions)

View changed files

📝 src/application/JavaScriptArtifactPathResolution.ts (+8 -18)
➕ src/domain/artifactPathSyntax.test.ts (+45 -0)
➕ src/domain/artifactPathSyntax.ts (+34 -0)
📝 src/domain/electronStaticAnalysisNative.ts (+2 -3)

📄 Description

Summary

Area 4 of the duplicate-ownership cleanup (mechanical slice).

New domain/artifactPathSyntax.ts owns hasScheme, looksExternal, stripQueryAndFragment, admitsCanonicalPathSyntax with a header doc recording the deliberate policy divergence (artifact-root confinement vs allowedOrigins vs exact-origin fetch).
Adopted in JavaScriptArtifactPathResolution (including two looksExternal call sites) and the Electron native .node specifier check. No behavior change.
Characterization tests pin scheme/external/query/fragment/encoded-byte handling.
Policy-outcome unification explicitly deferred to #829.

Verification

Path-resolution, file-URL, module-specifier, electron composition suites: 85/85 in the focused run.
npm run check: 5/5.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/830 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/path-resolution` --- ### 📝 Commits (1) - [`7791846`](https://github.com/morluto/rea/commit/779184694f8670f5c3792417b127eb0e6b88f1db) refactor(domain): extract artifact path syntax helpers ### 📊 Changes **4 files changed** (+89 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/application/JavaScriptArtifactPathResolution.ts` (+8 -18) ➕ `src/domain/artifactPathSyntax.test.ts` (+45 -0) ➕ `src/domain/artifactPathSyntax.ts` (+34 -0) 📝 `src/domain/electronStaticAnalysisNative.ts` (+2 -3) </details> ### 📄 Description ## Summary Area 4 of the duplicate-ownership cleanup (mechanical slice). - New `domain/artifactPathSyntax.ts` owns `hasScheme`, `looksExternal`, `stripQueryAndFragment`, `admitsCanonicalPathSyntax` with a header doc recording the deliberate policy divergence (artifact-root confinement vs allowedOrigins vs exact-origin fetch). - Adopted in `JavaScriptArtifactPathResolution` (including two `looksExternal` call sites) and the Electron native `.node` specifier check. No behavior change. - Characterization tests pin scheme/external/query/fragment/encoded-byte handling. - Policy-outcome unification explicitly deferred to #829. ## Verification - Path-resolution, file-URL, module-specifier, electron composition suites: 85/85 in the focused run. - npm run check: 5/5. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:16:33 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:07:29 +00:00

[PR #2995] [CLOSED] fix(setup): detect existing Hopper install on Linux before reinstalling (#2270) #5546

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2270

No description provided.

Rows
Columns