[PR #833] [MERGED] refactor(domain): map validation taxonomies and add inventory Result seam #2271

New issue

Closed

opened 2026-10-16 21:16:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:16:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/833
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: cleanup/validation-taxonomy

📝 Commits (1)

fd678b5 refactor(domain): map validation taxonomies and add inventory Result seam

📊 Changes

2 files changed (+86 additions, -3 deletions)

View changed files

📝 src/domain/artifactInventoryEvidence.ts (+26 -3)
➕ src/domain/validationTaxonomy.test.ts (+60 -0)

📄 Description

Summary

Area 5 of the duplicate-ownership cleanup (first seam, no signature changes).

New domain/validationTaxonomy.test.ts pins the three disjoint failure taxonomies: filesystem reader codes, session reference reasons, inventory TypeErrors.
Export ParsedInventorySet and add tryAssembleInventorySet covering the empty-pages leaf as Result; other assembly failures still throw and parseArtifactInventoryEvidence keeps its throwing contract until the 4 domain comparison callers migrate (follow-up).

Verification

New mapping tests (disjointness, Result leaf, throwing contract preserved).
npm run check: 5/5.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/833 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/validation-taxonomy` --- ### 📝 Commits (1) - [`fd678b5`](https://github.com/morluto/rea/commit/fd678b5ea783d2483766a6b0416a3a763bd22d97) refactor(domain): map validation taxonomies and add inventory Result seam ### 📊 Changes **2 files changed** (+86 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/artifactInventoryEvidence.ts` (+26 -3) ➕ `src/domain/validationTaxonomy.test.ts` (+60 -0) </details> ### 📄 Description ## Summary Area 5 of the duplicate-ownership cleanup (first seam, no signature changes). - New `domain/validationTaxonomy.test.ts` pins the three disjoint failure taxonomies: filesystem reader codes, session reference reasons, inventory TypeErrors. - Export `ParsedInventorySet` and add `tryAssembleInventorySet` covering the empty-pages leaf as `Result`; other assembly failures still throw and `parseArtifactInventoryEvidence` keeps its throwing contract until the 4 domain comparison callers migrate (follow-up). ## Verification - New mapping tests (disjointness, Result leaf, throwing contract preserved). - npm run check: 5/5. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:16:34 +00:00