[PR #854] [MERGED] fix: preserve native UI failure reasons and dedupe version literals #2290

New issue

Closed

opened 2026-10-16 21:16:50 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:16:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/854
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: cursor/debt-honesty-cleanup-6404

📝 Commits (1)

a5dc483 fix: preserve native UI failure reasons and dedupe version literals

📊 Changes

17 files changed (+67 additions, -46 deletions)

View changed files

📝 src/android/JadxAnalysis.ts (+3 -2)
📝 src/android/JadxConfiguration.ts (+2 -3)
📝 src/android/JadxProvider.ts (+5 -2)
📝 src/android/JadxRelease.ts (+9 -0)
📝 src/android/JadxSession.ts (+2 -1)
📝 src/application/Doctor.test.ts (+3 -1)
📝 src/application/DoctorDiagnostics.ts (+5 -2)
📝 src/application/Setup.recovery.test.ts (+2 -1)
📝 src/application/SetupHost.ts (+5 -2)
📝 src/domain/browserObservationSchemas.ts (+2 -1)
📝 src/domain/browserSession.ts (+2 -7)
📝 src/domain/electronObservation.ts (+1 -7)
📝 src/domain/runtimeVersion.ts (+4 -0)
📝 src/domain/webMcpDiscovery.ts (+1 -8)
📝 src/domain/webScreenshot.ts (+1 -8)
📝 src/native/NativeUiObservation.test.ts (+18 -0)
📝 src/native/NativeUiObservation.ts (+2 -1)

📄 Description

Summary

Preserve the underlying native UI helper/OS failure message in diagnostics.reason, and keep the Xcode/permissions guidance as diagnostics.remediation.
Deduplicate browserVersionSchema, share SUPPORTED_NODE_VERSION_PROSE, and derive JADX heap/-Xmx plus jar-configuration remediation from JadxRelease (handshake SHA/version pins unchanged).
The planned test-suite-audit.md banner is obsolete: that file was already removed on main (#849).

Verification

npm run check:fast
npm run test:focused -- src/native/NativeUiObservation.test.ts src/application/Doctor.test.ts src/application/Setup.recovery.test.ts
Real Android/Apple/Ghidra/firmware verification was not run

Notes

Capability inventory remediation still names 0.7.1 in application code because application→android imports are restricted; android-layer remediations and heap limits now derive from JadxRelease.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/854 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cursor/debt-honesty-cleanup-6404` --- ### 📝 Commits (1) - [`a5dc483`](https://github.com/morluto/rea/commit/a5dc48363c125da88eaa6c2720ec27ed59ee5154) fix: preserve native UI failure reasons and dedupe version literals ### 📊 Changes **17 files changed** (+67 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `src/android/JadxAnalysis.ts` (+3 -2) 📝 `src/android/JadxConfiguration.ts` (+2 -3) 📝 `src/android/JadxProvider.ts` (+5 -2) 📝 `src/android/JadxRelease.ts` (+9 -0) 📝 `src/android/JadxSession.ts` (+2 -1) 📝 `src/application/Doctor.test.ts` (+3 -1) 📝 `src/application/DoctorDiagnostics.ts` (+5 -2) 📝 `src/application/Setup.recovery.test.ts` (+2 -1) 📝 `src/application/SetupHost.ts` (+5 -2) 📝 `src/domain/browserObservationSchemas.ts` (+2 -1) 📝 `src/domain/browserSession.ts` (+2 -7) 📝 `src/domain/electronObservation.ts` (+1 -7) 📝 `src/domain/runtimeVersion.ts` (+4 -0) 📝 `src/domain/webMcpDiscovery.ts` (+1 -8) 📝 `src/domain/webScreenshot.ts` (+1 -8) 📝 `src/native/NativeUiObservation.test.ts` (+18 -0) 📝 `src/native/NativeUiObservation.ts` (+2 -1) </details> ### 📄 Description  ## Summary - Preserve the underlying native UI helper/OS failure message in `diagnostics.reason`, and keep the Xcode/permissions guidance as `diagnostics.remediation`. - Deduplicate `browserVersionSchema`, share `SUPPORTED_NODE_VERSION_PROSE`, and derive JADX heap/`-Xmx` plus jar-configuration remediation from `JadxRelease` (handshake SHA/version pins unchanged). - The planned `test-suite-audit.md` banner is obsolete: that file was already removed on `main` (#849). ## Verification - `npm run check:fast` - `npm run test:focused -- src/native/NativeUiObservation.test.ts src/application/Doctor.test.ts src/application/Setup.recovery.test.ts` - Real Android/Apple/Ghidra/firmware verification was **not** run ## Notes Capability inventory remediation still names `0.7.1` in application code because application→android imports are restricted; android-layer remediations and heap limits now derive from `JadxRelease`.  <div><a href="https://cursor.com/agents/bc-44a88d98-6d9b-4da2-a464-22f0c2a36404?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-44a88d98-6d9b-4da2-a464-22f0c2a36404&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:16:50 +00:00