[PR #856] [MERGED] refactor(ghidra): extract createClient and load-image attestation #2293

New issue

Closed

opened 2026-10-16 21:16:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:16:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/856
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: cursor/split-ghidra-provider-client-6404

📝 Commits (1)

a2d4d80 refactor(ghidra): extract createClient and load-image attestation

📊 Changes

3 files changed (+443 additions, -363 deletions)

View changed files

➕ src/ghidra/GhidraLoadImageAttest.ts (+70 -0)
📝 src/ghidra/GhidraProvider.ts (+18 -363)
➕ src/ghidra/GhidraProviderClient.ts (+355 -0)

📄 Description

Summary

Extract createGhidraProviderClient / client factory into GhidraProviderClient.ts.
Extract DOS MZ/COM inspect_native_load_image attestation into GhidraLoadImageAttest.ts.
Thin GhidraProvider to the candidate adapter; keep public identity/contracts/factory types stable.

Verification

npm run check:fast
npm run test:focused -- GhidraProvider + load-image unit tests (78 passed)
Real Ghidra verification was not run

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/856 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cursor/split-ghidra-provider-client-6404` --- ### 📝 Commits (1) - [`a2d4d80`](https://github.com/morluto/rea/commit/a2d4d80da1e2764647e9ca314350749de5edec81) refactor(ghidra): extract createClient and load-image attestation ### 📊 Changes **3 files changed** (+443 additions, -363 deletions) <details> <summary>View changed files</summary> ➕ `src/ghidra/GhidraLoadImageAttest.ts` (+70 -0) 📝 `src/ghidra/GhidraProvider.ts` (+18 -363) ➕ `src/ghidra/GhidraProviderClient.ts` (+355 -0) </details> ### 📄 Description  ## Summary - Extract `createGhidraProviderClient` / client factory into `GhidraProviderClient.ts`. - Extract DOS MZ/COM `inspect_native_load_image` attestation into `GhidraLoadImageAttest.ts`. - Thin `GhidraProvider` to the candidate adapter; keep public identity/contracts/factory types stable. ## Verification - `npm run check:fast` - `npm run test:focused --` GhidraProvider + load-image unit tests (78 passed) - Real Ghidra verification was **not** run  <div><a href="https://cursor.com/agents/bc-44a88d98-6d9b-4da2-a464-22f0c2a36404?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-44a88d98-6d9b-4da2-a464-22f0c2a36404&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:16:51 +00:00