morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #898] [MERGED] ci: verify native arm64 and Intel macOS workflows #2328

New issue

Closed

opened 2026-10-16 21:17:20 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:17:20 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/898
Author: @N0zoM1z0
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @N0zoM1z0

Base: main ← Head: ci/native-platform-coverage

📝 Commits (1)

dae0fd9 ci: verify native arm64 and Intel macOS workflows

📊 Changes

2 files changed (+81 additions, -3 deletions)

View changed files

📝 .github/workflows/ci.yml (+56 -2)
📝 docs/testing.md (+25 -1)

📄 Description

Summary

Add native Linux arm64/aarch64 and Intel macOS baseline coverage, and run the existing real Node Inspector workflow on all five mainstream host/architecture pairs. This strengthens T7 verification in #740.

Problem and expected behavior

Installed-package CI covered Linux x64 and macOS arm64; real Inspector CI covered Linux and Windows x64. Linux arm64, Intel macOS and macOS Inspector behavior could regress without a corresponding native workflow. Runner labels alone also did not verify the architecture of the Node process.

Change and scope

Reuse existing verification entrypoints rather than adding another test framework. Package CI now includes Linux x64/arm64 and macOS x64/arm64; the existing Windows x64 native/package lane remains. Inspector CI covers all five pairs. Each matrix asserts native platform/architecture, records Node version, limits concurrency to two, and has explicit timeout/heap/thread bounds.

Runner labels were checked against the official hosted-runner reference. The testing guide distinguishes this baseline from real analysis-provider conformance.

Contract and boundary impact

Semantic owner and earliest changed stage: native CI runner selection and verification.
CLI and MCP/tool-catalog contract: none.
Provider, bridge, target-format, or platform compatibility: no backend support change; native baseline workflows expose actual compatibility failures.
Evidence, artifact, provenance, or reconstruction contract: none.
Process execution, authorization, cleanup, or containment impact: existing source-owned isolated verifier lifecycles reused.
Generated metadata (docs/product-catalog.json), package, or installation impact: none.

Evidence and regression coverage

Tests added or updated: CI matrices only; existing installed-package and real Inspector workflows reused.
Base reproduction or other evidence: the base matrices omit Linux arm64 and Intel macOS; macOS Inspector is also absent.
User-visible CLI/MCP output: unchanged; CI emits checked platform, architecture and Node version.
Remaining proof gaps: local host is Linux x64. ARM/macOS execution must be established by the new hosted checks before merge. Provider-specific real workflows remain separate.

Validation performed

npm run check:fast — typecheck and lint passed.
Oxfmt and git diff --check — passed.
Parsed workflow and executed identity steps — native identity accepted, mismatched architecture rejected; existing Windows package/native steps retained.
npm run build:cached — fresh baseline build passed.
Existing curatedWindowsLane.test.ts — all referenced test paths exist.
npm run verify:inspector — eight actual Linux CLI/MCP filename fixtures passed with the same two-CPU/1-GiB-heap limits.

Compatibility, safety, and release

Breaking changes or migration steps: none; existing check names preserved and new matrix entries added.
Real Hopper/Ghidra, browser, or OS coverage: actual Linux Inspector locally; added native hosts require green CI. No local real Hopper/Ghidra/IDA claim for this workflow-only increment.
Package or release metadata impact: none; no production dependencies or engine installations added.
Security, privacy, process, or containment review: only workflow and testing guide changed. Runtime identity reports contain platform, architecture and version; no ambient environment or local target data. Heavy local verification remained serial and bounded.

Review checklist

The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/898 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `ci/native-platform-coverage` --- ### 📝 Commits (1) - [`dae0fd9`](https://github.com/morluto/rea/commit/dae0fd9f87cfd832dc9fe77b90ea34ea71fc6cd8) ci: verify native arm64 and Intel macOS workflows ### 📊 Changes **2 files changed** (+81 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+56 -2) 📝 `docs/testing.md` (+25 -1) </details> ### 📄 Description ## Summary Add native Linux arm64/aarch64 and Intel macOS baseline coverage, and run the existing real Node Inspector workflow on all five mainstream host/architecture pairs. This strengthens T7 verification in #740. ## Problem and expected behavior Installed-package CI covered Linux x64 and macOS arm64; real Inspector CI covered Linux and Windows x64. Linux arm64, Intel macOS and macOS Inspector behavior could regress without a corresponding native workflow. Runner labels alone also did not verify the architecture of the Node process. ## Change and scope Reuse existing verification entrypoints rather than adding another test framework. Package CI now includes Linux x64/arm64 and macOS x64/arm64; the existing Windows x64 native/package lane remains. Inspector CI covers all five pairs. Each matrix asserts native platform/architecture, records Node version, limits concurrency to two, and has explicit timeout/heap/thread bounds. Runner labels were checked against the [official hosted-runner reference](https://docs.github.com/en/actions/reference/runners/github-hosted-runners). The testing guide distinguishes this baseline from real analysis-provider conformance. ## Contract and boundary impact - Semantic owner and earliest changed stage: native CI runner selection and verification. - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: no backend support change; native baseline workflows expose actual compatibility failures. - Evidence, artifact, provenance, or reconstruction contract: none. - Process execution, authorization, cleanup, or containment impact: existing source-owned isolated verifier lifecycles reused. - Generated metadata (`docs/product-catalog.json`), package, or installation impact: none. ## Evidence and regression coverage - Tests added or updated: CI matrices only; existing installed-package and real Inspector workflows reused. - Base reproduction or other evidence: the base matrices omit Linux arm64 and Intel macOS; macOS Inspector is also absent. - User-visible CLI/MCP output: unchanged; CI emits checked platform, architecture and Node version. - Remaining proof gaps: local host is Linux x64. ARM/macOS execution must be established by the new hosted checks before merge. Provider-specific real workflows remain separate. ## Validation performed - `npm run check:fast` — typecheck and lint passed. - Oxfmt and `git diff --check` — passed. - Parsed workflow and executed identity steps — native identity accepted, mismatched architecture rejected; existing Windows package/native steps retained. - `npm run build:cached` — fresh baseline build passed. - Existing `curatedWindowsLane.test.ts` — all referenced test paths exist. - `npm run verify:inspector` — eight actual Linux CLI/MCP filename fixtures passed with the same two-CPU/1-GiB-heap limits. ## Compatibility, safety, and release - Breaking changes or migration steps: none; existing check names preserved and new matrix entries added. - Real Hopper/Ghidra, browser, or OS coverage: actual Linux Inspector locally; added native hosts require green CI. No local real Hopper/Ghidra/IDA claim for this workflow-only increment. - Package or release metadata impact: none; no production dependencies or engine installations added. - Security, privacy, process, or containment review: only workflow and testing guide changed. Runtime identity reports contain platform, architecture and version; no ambient environment or local target data. Heavy local verification remained serial and bounded. ## Review checklist - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:17:20 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2328

No description provided.

Rows
Columns