[PR #939] [MERGED] fix(javascript): handle deep static member paths #2516

New issue

Closed

opened 2026-10-17 21:07:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:07:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/939
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: codex/javascript-static-member-depth

📝 Commits (1)

a3bd85d fix(javascript): handle deep static member paths

📊 Changes

3 files changed (+119 additions, -21 deletions)

View changed files

📝 src/domain/javascript/javascriptAstFingerprint.ts (+25 -9)
➕ src/domain/javascript/javascriptStaticAnalysis.member_path_depth.test.ts (+63 -0)
📝 src/domain/javascript/javascriptStaticAnalysisHelpers.ts (+31 -12)

📄 Description

Summary

Follow-up to #932 for two remaining recursive JavaScript member-chain walkers. Export collection now builds member paths iteratively, and bundler runtime lookup searches iteratively while retaining its existing match order. Both paths now handle 12,000-member chains without a stack overflow.

Added regressions for deep export and runtime chains, empty and computed keys, private and this members, and left-first nested assignment runtime selection.

Verification

vitest run src/domain/javascript: 645 tests passed
npm run build:cached
npm run check:fast
npm run docs:check
Compared complete analyzeJavaScriptStaticSource outputs against origin/main for four ordinary fixtures, including member-key edge cases and nested assignment precedence; all four matched exactly.

The change fixes recursion depth. No ordinary-workload speedup is claimed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/939 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/javascript-static-member-depth` --- ### 📝 Commits (1) - [`a3bd85d`](https://github.com/morluto/rea/commit/a3bd85dd525e6861bf605aa27ae2965aaf70d393) fix(javascript): handle deep static member paths ### 📊 Changes **3 files changed** (+119 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptAstFingerprint.ts` (+25 -9) ➕ `src/domain/javascript/javascriptStaticAnalysis.member_path_depth.test.ts` (+63 -0) 📝 `src/domain/javascript/javascriptStaticAnalysisHelpers.ts` (+31 -12) </details> ### 📄 Description ## Summary Follow-up to #932 for two remaining recursive JavaScript member-chain walkers. Export collection now builds member paths iteratively, and bundler runtime lookup searches iteratively while retaining its existing match order. Both paths now handle 12,000-member chains without a stack overflow. Added regressions for deep export and runtime chains, empty and computed keys, private and `this` members, and left-first nested assignment runtime selection. ## Verification - `vitest run src/domain/javascript`: 645 tests passed - `npm run build:cached` - `npm run check:fast` - `npm run docs:check` - Compared complete `analyzeJavaScriptStaticSource` outputs against `origin/main` for four ordinary fixtures, including member-key edge cases and nested assignment precedence; all four matched exactly. The change fixes recursion depth. No ordinary-workload speedup is claimed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:07:04 +00:00