morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #943] [MERGED] fix(release): extend npm propagation window and improve diagnostics #2520

New issue

Closed

opened 2026-10-17 21:07:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:07:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/943
Author: @yunaremaia
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: fix/release-verification-propagation

📝 Commits (2)

479dd53 fix(release): extend npm propagation window and improve diagnostics
d673549 fix(release): drop no-op --force from npm propagation polling

📊 Changes

1 file changed (+10 additions, -6 deletions)

View changed files

📝 .github/workflows/release.yml (+10 -6)

📄 Description

Summary

The release verification step polls npm for up to 20 minutes (80 attempts × 15s), but npm registry propagation can take longer. When the version doesn't appear within the window, the workflow fails even though the package was already published successfully.

Fixes #621.

Changes

Extend polling window from 20 to 30 minutes (120 attempts × 15s)
Add --force flag to npm view to bypass cache on each poll
Report full retry window in diagnostics (attempts × sleep time)
Distinguish propagation delay from CLI verification failure in error message

Testing

This is a CI workflow change. The logic is straightforward shell scripting with no external dependencies. The change:

Increases max_attempts from 80 to 120
Adds --force to npm view to ensure fresh metadata on each poll
Improves error messages to clearly indicate propagation delay vs verification failure

Context

Issue #621 reports that the 2026-10-05 release run for rea-agents 4.0.0 successfully completed npm publish, but the follow-up verification failed because npm did not expose the version during the workflow's five-minute polling window. The package is visible on npm now.

The proposed fix in the issue:

Extend the bounded registry visibility window and request fresh metadata on each poll, while keeping CLI verification after the version appears. Report the full retry window in diagnostics so future failures distinguish propagation delay from CLI verification failure.

This PR implements exactly that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/943 **Author:** [@yunaremaia](https://github.com/yunaremaia) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/release-verification-propagation` --- ### 📝 Commits (2) - [`479dd53`](https://github.com/morluto/rea/commit/479dd53a6c1048b4158089b035cd0c78a08a8aaa) fix(release): extend npm propagation window and improve diagnostics - [`d673549`](https://github.com/morluto/rea/commit/d673549eac87261d09cf0c9a0a4f4295e61bb71a) fix(release): drop no-op --force from npm propagation polling ### 📊 Changes **1 file changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+10 -6) </details> ### 📄 Description ## Summary The release verification step polls npm for up to 20 minutes (80 attempts × 15s), but npm registry propagation can take longer. When the version doesn't appear within the window, the workflow fails even though the package was already published successfully. Fixes #621. ## Changes - **Extend polling window** from 20 to 30 minutes (120 attempts × 15s) - **Add `--force` flag** to `npm view` to bypass cache on each poll - **Report full retry window** in diagnostics (attempts × sleep time) - **Distinguish propagation delay** from CLI verification failure in error message ## Testing This is a CI workflow change. The logic is straightforward shell scripting with no external dependencies. The change: - Increases `max_attempts` from 80 to 120 - Adds `--force` to `npm view` to ensure fresh metadata on each poll - Improves error messages to clearly indicate propagation delay vs verification failure ## Context Issue #621 reports that the 2026-10-05 release run for rea-agents 4.0.0 successfully completed npm publish, but the follow-up verification failed because npm did not expose the version during the workflow's five-minute polling window. The package is visible on npm now. The proposed fix in the issue: > Extend the bounded registry visibility window and request fresh metadata on each poll, while keeping CLI verification after the version appears. Report the full retry window in diagnostics so future failures distinguish propagation delay from CLI verification failure. This PR implements exactly that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:07:07 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2520

No description provided.

Rows
Columns