[PR #978] [MERGED] fix(firmware): retain multi-file extraction failures #2548

New issue

Closed

opened 2026-10-17 21:07:25 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:07:25 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/978
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: codex/firmware-multifile-report-errors

📝 Commits (1)

0413a43 fix(firmware): retain multi-file extraction failures

📊 Changes

2 files changed (+74 additions, -0 deletions)

View changed files

📝 src/firmware/FirmwareReports.test.ts (+62 -0)
📝 src/firmware/FirmwareReports.ts (+12 -0)

📄 Description

Summary

Firmware normalization now retains extraction failures nested in Unblob MultiFileReport values. These reports include their extraction task and source paths; keeping them in caller-visible diagnostics preserves the failed extraction facet and makes coverage partial.

The regression fixture follows the pinned producer schema and includes a nested ExtractorDependencyNotFoundReport. It verifies the report wrapper and its raw details survive normalization.

Validation

npm run test:focused -- src/firmware/FirmwareReports.test.ts tests/boundary/firmware/firmwareIntegration.test.ts tests/boundary/mcp/firmwareMcp.test.ts (6 passed; platform-guarded integration/MCP tests skipped on macOS)
npm run check:fast
npm run format:check
npm run check:ci

No real Unblob execution or Linux firmware-toolchain verification is claimed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/978 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/firmware-multifile-report-errors` --- ### 📝 Commits (1) - [`0413a43`](https://github.com/morluto/rea/commit/0413a433c439d7fb92c2672114e900dbbcc1f418) fix(firmware): retain multi-file extraction failures ### 📊 Changes **2 files changed** (+74 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/firmware/FirmwareReports.test.ts` (+62 -0) 📝 `src/firmware/FirmwareReports.ts` (+12 -0) </details> ### 📄 Description ## Summary Firmware normalization now retains extraction failures nested in Unblob `MultiFileReport` values. These reports include their extraction task and source paths; keeping them in caller-visible diagnostics preserves the failed extraction facet and makes coverage partial. The regression fixture follows the pinned producer schema and includes a nested `ExtractorDependencyNotFoundReport`. It verifies the report wrapper and its raw details survive normalization. ## Validation - `npm run test:focused -- src/firmware/FirmwareReports.test.ts tests/boundary/firmware/firmwareIntegration.test.ts tests/boundary/mcp/firmwareMcp.test.ts` (6 passed; platform-guarded integration/MCP tests skipped on macOS) - `npm run check:fast` - `npm run format:check` - `npm run check:ci` No real Unblob execution or Linux firmware-toolchain verification is claimed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:07:25 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2548

No description provided.

Rows
Columns