[PR #987] [MERGED] fix(artifacts): preserve reader failure diagnostics #2555

New issue

Closed

opened 2026-10-17 21:07:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:07:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/987
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: codex/artifact-diagnostic-preservation

📝 Commits (5)

d06c62a fix(artifacts): preserve filesystem and DMG diagnostics
08d7b22 fix(artifacts): classify DMG verification failures
0a64d8c fix(artifacts): distinguish inaccessible disk images
df041db fix(artifacts): classify damaged image checksums
69e96c5 Merge remote-tracking branch 'origin/main' into codex/pr987-dmg-access-reasons

📊 Changes

6 files changed (+537 additions, -20 deletions)

View changed files

📝 src/artifacts/DirectoryArtifactReader.ts (+61 -7)
📝 src/artifacts/NativeDmgArtifactReader.ts (+167 -10)
📝 src/process/ExecFileOutput.test.ts (+9 -0)
📝 src/process/ExecFileOutput.ts (+2 -0)
➕ tests/boundary/providers/native/artifactProvider.directoryErrors.test.ts (+57 -0)
📝 tests/boundary/providers/native/nativeDmgArtifactReader.test.ts (+241 -3)

📄 Description

Summary

Artifact directory traversal now carries the affected filesystem path and errno into caller-visible failures. DMG command failures retain the hdiutil operation, arguments, exit code, stdout, and stderr. Numeric verify refusals are reported as format failures; child launch failures remain unavailable, permission and host I/O errors remain I/O failures, and unknown non-verify failures remain unavailable with their evidence intact.

Coverage includes a real chmod-denied member through provider error projection, a real invalid-image hdiutil verify refusal, and production-seam controls for launch ENOENT, permission EACCES, and unknown attach failure. The prior transient hosted hdiutil failure remains unexplained; this change improves its diagnostic evidence and does not claim to fix mount flakiness.

Validation

Focused artifact-reader/provider and ExecFileOutput tests (13 passed)
npm run check:fast
npm run format:check
npm run docs:check
npm run verify:macos-bundle (real local hdiutil; CLI and stdio MCP; directory, ZIP, DMG; detach verified)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/987 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/artifact-diagnostic-preservation` --- ### 📝 Commits (5) - [`d06c62a`](https://github.com/morluto/rea/commit/d06c62a48cb449d0bb67334abd59aafe2f4bf9f8) fix(artifacts): preserve filesystem and DMG diagnostics - [`08d7b22`](https://github.com/morluto/rea/commit/08d7b22690053bf031552c6333fb1857a8087066) fix(artifacts): classify DMG verification failures - [`0a64d8c`](https://github.com/morluto/rea/commit/0a64d8c1a9b2dc41ba8471329ceea0a9ae6accf2) fix(artifacts): distinguish inaccessible disk images - [`df041db`](https://github.com/morluto/rea/commit/df041db87774362967cc2a07ace07242934b42d7) fix(artifacts): classify damaged image checksums - [`69e96c5`](https://github.com/morluto/rea/commit/69e96c583fdc8c85b6624e3ec9dbf441b75ef143) Merge remote-tracking branch 'origin/main' into codex/pr987-dmg-access-reasons ### 📊 Changes **6 files changed** (+537 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/artifacts/DirectoryArtifactReader.ts` (+61 -7) 📝 `src/artifacts/NativeDmgArtifactReader.ts` (+167 -10) 📝 `src/process/ExecFileOutput.test.ts` (+9 -0) 📝 `src/process/ExecFileOutput.ts` (+2 -0) ➕ `tests/boundary/providers/native/artifactProvider.directoryErrors.test.ts` (+57 -0) 📝 `tests/boundary/providers/native/nativeDmgArtifactReader.test.ts` (+241 -3) </details> ### 📄 Description ## Summary Artifact directory traversal now carries the affected filesystem path and errno into caller-visible failures. DMG command failures retain the hdiutil operation, arguments, exit code, stdout, and stderr. Numeric `verify` refusals are reported as format failures; child launch failures remain unavailable, permission and host I/O errors remain I/O failures, and unknown non-verify failures remain unavailable with their evidence intact. Coverage includes a real chmod-denied member through provider error projection, a real invalid-image `hdiutil verify` refusal, and production-seam controls for launch ENOENT, permission EACCES, and unknown attach failure. The prior transient hosted hdiutil failure remains unexplained; this change improves its diagnostic evidence and does not claim to fix mount flakiness. ## Validation - Focused artifact-reader/provider and `ExecFileOutput` tests (13 passed) - `npm run check:fast` - `npm run format:check` - `npm run docs:check` - `npm run verify:macos-bundle` (real local hdiutil; CLI and stdio MCP; directory, ZIP, DMG; detach verified) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:07:32 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:43:13 +00:00

[GH-ISSUE #6060] [Bug] observe_web_session waits out its window after fatal CDP protocol failure #3705

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2555

No description provided.

Rows
Columns