[PR #999] [MERGED] test(process): wait for observable snapshot ctime changes #2568

New issue

Closed

opened 2026-10-17 21:07:41 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:07:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/999
Author: @N0zoM1z0
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: fix/process-snapshot-ctime-fixture

📝 Commits (1)

dba612a test(process): wait for observable snapshot ctime changes

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 src/application/FilesystemSnapshot.test.ts (+7 -2)

📄 Description

Two back-to-back writes can report the same ctime on the host filesystem, causing the snapshot regression to fail before it exercises hashFile.

Wait for an observable ctime change while preparing the same-size rewrite and restoring mtime. Keep the file identity, size, mtime, changed-ctime assertions and the actual hash rejection assertion. Production hashing and CI download configuration are unchanged.

Validation:

All four filesystem snapshot cases passed, followed by five serial suite repetitions.
Mutation check: removing the production ctime comparison fails the hash rejection assertion; restored production passes.
npm run check -- --output-logs=errors-only (typecheck, lint, formatting, unused-code and metadata checks).

Follow-up to #956, discovered during the process-owner migration in #988 / #740. Real Hopper/Ghidra verification was not run for this test-fixture-only change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/999 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/process-snapshot-ctime-fixture` --- ### 📝 Commits (1) - [`dba612a`](https://github.com/morluto/rea/commit/dba612a3e85825efc12e4cbca503a2303c13bc30) test(process): wait for observable snapshot ctime changes ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/application/FilesystemSnapshot.test.ts` (+7 -2) </details> ### 📄 Description Two back-to-back writes can report the same ctime on the host filesystem, causing the snapshot regression to fail before it exercises `hashFile`. Wait for an observable ctime change while preparing the same-size rewrite and restoring mtime. Keep the file identity, size, mtime, changed-ctime assertions and the actual hash rejection assertion. Production hashing and CI download configuration are unchanged. Validation: - All four filesystem snapshot cases passed, followed by five serial suite repetitions. - Mutation check: removing the production ctime comparison fails the hash rejection assertion; restored production passes. - `npm run check -- --output-logs=errors-only` (typecheck, lint, formatting, unused-code and metadata checks). Follow-up to #956, discovered during the process-owner migration in #988 / #740. Real Hopper/Ghidra verification was not run for this test-fixture-only change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:07:41 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2568

No description provided.

Rows
Columns