[PR #1023] [MERGED] test(ci): stabilize browser source identity fixture delivery #2588

New issue

Closed

opened 2026-10-17 21:07:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:07:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1023
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: fix/ci-browser-source-identity

📝 Commits (1)

0f88b28 test(ci): allow transport delivery in source identity regression

📊 Changes

1 file changed (+17 additions, -3 deletions)

View changed files

📝 tests/boundary/browser/cdpWebRuntimeSourceIdentity.test.ts (+17 -3)

📄 Description

The source-identity regression sends a real WebSocket request after the armed receipt but allows only 5 ms for delivery. Under CI load, the observation can end before the event arrives, leaving the expected callsite absent.

Use a bounded 100 ms fixture observation, assert normal window completion, and match the injected request ID plus its revalidated script association. Production behavior is unchanged.

Validation: the six source-identity cases and four stdio runtime cases passed with one worker (10 tests); npm run build:cached and npm run check:ci passed. Independent review accepted the fixture-only change. No real Hopper/Ghidra verification was performed.

Failure: https://github.com/morluto/rea/actions/runs/37669486079

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1023 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/ci-browser-source-identity` --- ### 📝 Commits (1) - [`0f88b28`](https://github.com/morluto/rea/commit/0f88b28766a4ebf75b47e5db94ca419c5fa404ac) test(ci): allow transport delivery in source identity regression ### 📊 Changes **1 file changed** (+17 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/browser/cdpWebRuntimeSourceIdentity.test.ts` (+17 -3) </details> ### 📄 Description The source-identity regression sends a real WebSocket request after the armed receipt but allows only 5 ms for delivery. Under CI load, the observation can end before the event arrives, leaving the expected callsite absent. Use a bounded 100 ms fixture observation, assert normal window completion, and match the injected request ID plus its revalidated script association. Production behavior is unchanged. Validation: the six source-identity cases and four stdio runtime cases passed with one worker (10 tests); `npm run build:cached` and `npm run check:ci` passed. Independent review accepted the fixture-only change. No real Hopper/Ghidra verification was performed. Failure: https://github.com/morluto/rea/actions/runs/37669486079 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:07:55 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:06:37 +00:00

[PR #2851] [CLOSED] fix(verify): route OpenAI model fixture requests by pathname #5437

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2588

No description provided.

Rows
Columns