[PR #1025] [MERGED] test(javascript): cover plain long-line loader identities #2590

New issue

Closed

opened 2026-10-17 21:07:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:07:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1025
Author: @N0zoM1z0
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @N0zoM1z0

Base: main ← Head: test/javascript-loader-empty-identities

📝 Commits (3)

ba8a181 test(javascript): cover plain long-line loader identities
18ca73d Merge remote-tracking branch 'origin/main' into test/javascript-loader-empty-identities
883f66e Merge remote-tracking branch 'origin/main' into test/javascript-loader-empty-identities

📊 Changes

1 file changed (+18 additions, -0 deletions)

View changed files

📝 src/application/javascript/JavaScriptApplicationEmptyLiterals.test.ts (+18 -0)

📄 Description

The published 4.1.0 CLI rejects legal empty endpoint and worker identities in a plain JavaScript loader with unreadable_output and Result schema rejected 2 issues at /identity/key (too_small). The identity correction already landed in #839; this adds a regression for the reported loader shape: two JavaScript files, no package metadata, and a 65,536-character string on a long line. It verifies that empty endpoint/worker keys are retained exactly and display labels remain absent.

Refs #1009; the published-version upgrade solution has been verified and posted in the issue.

Validation:

An isolated installed rea-agents@4.1.0 reproduces the same two schema errors (native exit 1). Current main analyzes the identical reduced fixture successfully on Linux (native exit 0), preserving both empty keys.
Windows Node 22.19.0 analyzes the same fixture successfully (native exit 0, approximately 192 MiB peak working set); no owned processes remain.
The focused empty-literal suite passes all 35 cases after integration with main. Restoring the original nonempty-key constraint makes the new regression fail; the production schema was restored afterward.
Static, formatting, and diff checks pass.

The original three game assets were not supplied; the reduced fixture reproduces the exact reported validation constraint. No real Hopper/Ghidra verification was performed; this is JavaScript static analysis.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1025 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `test/javascript-loader-empty-identities` --- ### 📝 Commits (3) - [`ba8a181`](https://github.com/morluto/rea/commit/ba8a1812527c26068ae21df4614efd3b4e894ee3) test(javascript): cover plain long-line loader identities - [`18ca73d`](https://github.com/morluto/rea/commit/18ca73d6dfa4076a09bf5445d80d9a33bc6044e0) Merge remote-tracking branch 'origin/main' into test/javascript-loader-empty-identities - [`883f66e`](https://github.com/morluto/rea/commit/883f66e5ace140cb4953adf51c5f837dbc21196b) Merge remote-tracking branch 'origin/main' into test/javascript-loader-empty-identities ### 📊 Changes **1 file changed** (+18 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/application/javascript/JavaScriptApplicationEmptyLiterals.test.ts` (+18 -0) </details> ### 📄 Description The published 4.1.0 CLI rejects legal empty endpoint and worker identities in a plain JavaScript loader with `unreadable_output` and `Result schema rejected 2 issues at /identity/key (too_small)`. The identity correction already landed in #839; this adds a regression for the reported loader shape: two JavaScript files, no package metadata, and a 65,536-character string on a long line. It verifies that empty endpoint/worker keys are retained exactly and display labels remain absent. Refs #1009; the published-version upgrade solution has been verified and posted in the issue. Validation: - An isolated installed `rea-agents@4.1.0` reproduces the same two schema errors (native exit 1). Current main analyzes the identical reduced fixture successfully on Linux (native exit 0), preserving both empty keys. - Windows Node 22.19.0 analyzes the same fixture successfully (native exit 0, approximately 192 MiB peak working set); no owned processes remain. - The focused empty-literal suite passes all 35 cases after integration with main. Restoring the original nonempty-key constraint makes the new regression fail; the production schema was restored afterward. - Static, formatting, and diff checks pass. The original three game assets were not supplied; the reduced fixture reproduces the exact reported validation constraint. No real Hopper/Ghidra verification was performed; this is JavaScript static analysis. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:07:57 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2590

No description provided.

Rows
Columns