[PR #1057] [MERGED] fix(process): stop failing captures on tokens macOS cannot expose #2610

New issue

Closed

opened 2026-10-17 21:08:12 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:08:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1057
Author: @muhammad-luay
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/darwin-sweep-os-withheld-tokens

📝 Commits (4)

148d200 fix(process): stop failing captures on tokens macOS cannot expose
9344b68 test(process): align ownership lanes with the uid-aware process table
0ad51f0 fix(process): retain withheld ownership observations in capture evidence
b0c81f0 fix(verify): recognize UID-bearing ownership process tables

📊 Changes

19 files changed (+791 additions, -161 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -0)
📝 bridge/process/ProcessRunTokenReader.swift (+31 -1)
📝 docs/process-capture.md (+6 -0)
📝 docs/product-catalog.json (+2 -2)
📝 docs/verification/managed-conformance-manifest.json (+2 -2)
📝 scripts/verify-binary-layout.mjs (+1 -1)
📝 scripts/verify-evm-interface.mjs (+3 -1)
📝 scripts/verify/recorded-crash/trace.mjs (+4 -2)
📝 skills/reverse-engineer-anything/SKILL.md (+1 -1)
📝 src/browser/PlaywrightElectronActiveProvider.ts (+38 -1)
📝 src/domain/process/processCapture.ts (+19 -0)
📝 src/process/ProcessOwnership.identity.test.ts (+94 -84)
📝 src/process/ProcessOwnership.part2.test.ts (+34 -0)
📝 src/process/ProcessOwnership.test.ts (+140 -5)
📝 src/process/ProcessOwnership.ts (+272 -52)
📝 src/process/ProcessOwnershipObservation.ts (+7 -4)
📝 src/process/capture/ProcessCaptureLifecycle.ts (+38 -3)
📝 src/process/capture/ProcessHarness.test.ts (+61 -0)
📝 tests/boundary/mcp/processEvidenceIdentityMcp.test.ts (+36 -2)

📄 Description

Fixes #1056.

The residual ownership sweep can fail a macOS capture because an unrelated process has an OS-withheld environment. Retry transient token reads within a bounded budget, distinguish positively identified Apple platform binaries and foreign-UID processes, and retain unrelated withheld candidates as unverified. Related candidates and unexplained failures remain strict; unverified processes are never signaled.

Maintainer follow-up preserves those PID/reason observations in successful and partial cleanup reports, process residual unknowns, and Electron limitations. CLI/MCP comparisons retain an unknown conclusion. Generated contracts and the process capture guide are updated.

Validation:

40 ownership/harness source tests and 9 capture domain tests passed.
69 compiled CLI/MCP/process boundary tests passed; 4 real Darwin reader cases require the macOS runner.
npm run check, npm run docs:generate, and npm run docs:check.
Added native Darwin reader, process cleanup, CLI, and MCP regressions to the Apple CI lane. Exact-head CI must pass before merge.

The contributor reported successful repeated repro runs under process churn on macOS 26.3 arm64. Local maintainer verification is Linux; hosted macOS 15 verification does not independently establish macOS 26 behavior. No real Hopper/Ghidra verification was needed for this process ownership change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1057 **Author:** [@muhammad-luay](https://github.com/muhammad-luay) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/darwin-sweep-os-withheld-tokens` --- ### 📝 Commits (4) - [`148d200`](https://github.com/morluto/rea/commit/148d2002836cf7df4d9826687b0d01c67aac47cd) fix(process): stop failing captures on tokens macOS cannot expose - [`9344b68`](https://github.com/morluto/rea/commit/9344b68a71b46896ca6487408e09b23ab2cd54f9) test(process): align ownership lanes with the uid-aware process table - [`0ad51f0`](https://github.com/morluto/rea/commit/0ad51f0a44f566e9e2001baf03f90e05117f7f97) fix(process): retain withheld ownership observations in capture evidence - [`b0c81f0`](https://github.com/morluto/rea/commit/b0c81f02e4def954d46717304afe70e85368b3d2) fix(verify): recognize UID-bearing ownership process tables ### 📊 Changes **19 files changed** (+791 additions, -161 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -0) 📝 `bridge/process/ProcessRunTokenReader.swift` (+31 -1) 📝 `docs/process-capture.md` (+6 -0) 📝 `docs/product-catalog.json` (+2 -2) 📝 `docs/verification/managed-conformance-manifest.json` (+2 -2) 📝 `scripts/verify-binary-layout.mjs` (+1 -1) 📝 `scripts/verify-evm-interface.mjs` (+3 -1) 📝 `scripts/verify/recorded-crash/trace.mjs` (+4 -2) 📝 `skills/reverse-engineer-anything/SKILL.md` (+1 -1) 📝 `src/browser/PlaywrightElectronActiveProvider.ts` (+38 -1) 📝 `src/domain/process/processCapture.ts` (+19 -0) 📝 `src/process/ProcessOwnership.identity.test.ts` (+94 -84) 📝 `src/process/ProcessOwnership.part2.test.ts` (+34 -0) 📝 `src/process/ProcessOwnership.test.ts` (+140 -5) 📝 `src/process/ProcessOwnership.ts` (+272 -52) 📝 `src/process/ProcessOwnershipObservation.ts` (+7 -4) 📝 `src/process/capture/ProcessCaptureLifecycle.ts` (+38 -3) 📝 `src/process/capture/ProcessHarness.test.ts` (+61 -0) 📝 `tests/boundary/mcp/processEvidenceIdentityMcp.test.ts` (+36 -2) </details> ### 📄 Description Fixes #1056. The residual ownership sweep can fail a macOS capture because an unrelated process has an OS-withheld environment. Retry transient token reads within a bounded budget, distinguish positively identified Apple platform binaries and foreign-UID processes, and retain unrelated withheld candidates as unverified. Related candidates and unexplained failures remain strict; unverified processes are never signaled. Maintainer follow-up preserves those PID/reason observations in successful and partial cleanup reports, process residual unknowns, and Electron limitations. CLI/MCP comparisons retain an unknown conclusion. Generated contracts and the process capture guide are updated. Validation: - 40 ownership/harness source tests and 9 capture domain tests passed. - 69 compiled CLI/MCP/process boundary tests passed; 4 real Darwin reader cases require the macOS runner. - `npm run check`, `npm run docs:generate`, and `npm run docs:check`. - Added native Darwin reader, process cleanup, CLI, and MCP regressions to the Apple CI lane. Exact-head CI must pass before merge. The contributor reported successful repeated repro runs under process churn on macOS 26.3 arm64. Local maintainer verification is Linux; hosted macOS 15 verification does not independently establish macOS 26 behavior. No real Hopper/Ghidra verification was needed for this process ownership change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:08:12 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:05:33 +00:00

[PR #2639] [CLOSED] fix(native): retain partial metadata when a protocol-list slot is unmapped #5300

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2610

No description provided.

Rows
Columns