[PR #1069] [MERGED] test(artifacts): verify native directory identity on supported Windows runtimes #2618

New issue

Closed

opened 2026-10-17 21:08:17 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:08:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1069
Author: @Adarsh-mk7
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/windows-directory-reader-device-integrity

📝 Commits (3)

1bce9c5 fix(artifacts): guard Windows device 0 in directory open integrity check
63edbe6 Merge remote-tracking branch 'origin/main' into review/1069-directory-identity
248066b test(artifacts): verify native directory identity without device bypasses

📊 Changes

2 files changed (+141 additions, -0 deletions)

View changed files

📝 .github/workflows/ci.yml (+15 -0)
➕ tests/boundary/filesystem/directoryArtifactReaderOpen.test.ts (+126 -0)

📄 Description

Native Node path/handle identity needs to be measured before relaxing directory integrity checks. The proposed Windows/device-zero bypass accepted mismatched source identities, and supported Node 22.19/24.18 libuv implementations populate the volume serial through both stat paths.

This revision preserves the existing device-and-inode checks and adds native producer coverage, actual replacement detection, mismatched device checks (including zero), missing identity, and non-file rejection. The Windows lane runs the directory and JavaScript artifact regressions on Node 24.18 and 22.19.

Validation: 49 focused tests passed on Linux; static checks passed; test discovery found all 588 files. Native Windows x64 passed all 39 focused tests on each of Node 24.18.0 and 22.19.0. Both reported matching nonzero device IDs (742408122) and matching file indices through lstat and handle.stat. The originally reported Windows false positive has not been independently reproduced; this PR does not claim a compatibility fix without that evidence. No real Hopper/Ghidra verification is required for these filesystem-only tests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1069 **Author:** [@Adarsh-mk7](https://github.com/Adarsh-mk7) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/windows-directory-reader-device-integrity` --- ### 📝 Commits (3) - [`1bce9c5`](https://github.com/morluto/rea/commit/1bce9c5f3d00f6d4e2438fc8491dd93673bd599e) fix(artifacts): guard Windows device 0 in directory open integrity check - [`63edbe6`](https://github.com/morluto/rea/commit/63edbe6896813c49623b9429c9b4cf9124ff59c8) Merge remote-tracking branch 'origin/main' into review/1069-directory-identity - [`248066b`](https://github.com/morluto/rea/commit/248066b7d0145393beb2c2cb8458c79c46acd3e0) test(artifacts): verify native directory identity without device bypasses ### 📊 Changes **2 files changed** (+141 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+15 -0) ➕ `tests/boundary/filesystem/directoryArtifactReaderOpen.test.ts` (+126 -0) </details> ### 📄 Description Native Node path/handle identity needs to be measured before relaxing directory integrity checks. The proposed Windows/device-zero bypass accepted mismatched source identities, and supported Node 22.19/24.18 libuv implementations populate the volume serial through both stat paths. This revision preserves the existing device-and-inode checks and adds native producer coverage, actual replacement detection, mismatched device checks (including zero), missing identity, and non-file rejection. The Windows lane runs the directory and JavaScript artifact regressions on Node 24.18 and 22.19. Validation: 49 focused tests passed on Linux; static checks passed; test discovery found all 588 files. Native Windows x64 passed all 39 focused tests on each of Node 24.18.0 and 22.19.0. Both reported matching nonzero device IDs (742408122) and matching file indices through lstat and handle.stat. The originally reported Windows false positive has not been independently reproduced; this PR does not claim a compatibility fix without that evidence. No real Hopper/Ghidra verification is required for these filesystem-only tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:08:17 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:06:20 +00:00

[PR #2796] [MERGED] fix(wasm): attribute invalid paths to their selected fields #5400

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2618

No description provided.

Rows
Columns