[PR #1072] [MERGED] fix(setup): launch Windows npx registrations through cmd.exe #2621

New issue

Closed

opened 2026-10-17 21:08:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:08:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1072
Author: @N0zoM1z0
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/windows-npx-registration

📝 Commits (1)

2196830 fix(setup): launch Windows npx registrations through cmd.exe

📊 Changes

8 files changed (+270 additions, -20 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -0)
➕ src/application/ClientRegistrationIdentity.test.ts (+52 -0)
📝 src/application/ClientRegistrationIdentity.ts (+28 -5)
📝 src/application/ClientRegistrationStatus.ts (+14 -7)
📝 src/application/SetupClientConfiguration.ts (+2 -6)
📝 src/application/SetupHost.ts (+2 -1)
📝 src/cli.ts (+2 -1)
➕ tests/boundary/filesystem/windowsNpxRegistration.test.ts (+168 -0)

📄 Description

Fixes #1066.

Use cmd.exe /d /c npx for Windows npm-run MCP registrations, including setup defaults and CLI-generated configuration. Keep legacy REA commands identifiable for safe migration and uninstall; mark bare Windows npx registrations stale and preserve unrelated settings and backups.

Verification: 37 source tests; 29 boundary tests passed with one native-Windows test skipped locally; npm run check, npm run docs:check, and test discovery passed. The Windows CI lane now exercises the written registration through an actual batch shim and MCP handshake without registry access. No real Hopper/Ghidra verification was needed for this setup-only change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1072 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/windows-npx-registration` --- ### 📝 Commits (1) - [`2196830`](https://github.com/morluto/rea/commit/21968301cca0f8d5394744c25d86cb5db314987b) fix(setup): launch Windows npx registrations through cmd.exe ### 📊 Changes **8 files changed** (+270 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -0) ➕ `src/application/ClientRegistrationIdentity.test.ts` (+52 -0) 📝 `src/application/ClientRegistrationIdentity.ts` (+28 -5) 📝 `src/application/ClientRegistrationStatus.ts` (+14 -7) 📝 `src/application/SetupClientConfiguration.ts` (+2 -6) 📝 `src/application/SetupHost.ts` (+2 -1) 📝 `src/cli.ts` (+2 -1) ➕ `tests/boundary/filesystem/windowsNpxRegistration.test.ts` (+168 -0) </details> ### 📄 Description Fixes #1066. Use `cmd.exe /d /c npx` for Windows npm-run MCP registrations, including setup defaults and CLI-generated configuration. Keep legacy REA commands identifiable for safe migration and uninstall; mark bare Windows npx registrations stale and preserve unrelated settings and backups. Verification: 37 source tests; 29 boundary tests passed with one native-Windows test skipped locally; `npm run check`, `npm run docs:check`, and test discovery passed. The Windows CI lane now exercises the written registration through an actual batch shim and MCP handshake without registry access. No real Hopper/Ghidra verification was needed for this setup-only change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:08:19 +00:00