[PR #1078] [MERGED] fix(browser): normalize selected script manifest roots on Windows #2626

New issue

Closed

opened 2026-10-17 21:08:22 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:08:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1078
Author: @N0zoM1z0
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/windows-web-script-paths

📝 Commits (2)

d6cb22b fix(browser): normalize selected script manifest roots on Windows
c4af466 test(browser): keep manifest fixtures valid across Windows drives

📊 Changes

5 files changed (+125 additions, -5 deletions)

View changed files

📝 .github/workflows/ci.yml (+3 -0)
📝 src/browser/assets/LocalWebScriptArtifacts.ts (+2 -2)
📝 tests/acceptance/webModuleCli.test.ts (+1 -1)
📝 tests/acceptance/webSourceLocationCli.test.ts (+42 -2)
➕ tests/boundary/filesystem/webScriptManifestPaths.test.ts (+77 -0)

📄 Description

Fixes #1067.

Normalize the selected manifest's host directory before joining and walking its source paths. Windows forward-slash drive paths now reach the same containment boundary as native paths; provider reads also terminate correctly for dot segments and relative roots. Keep the shared CLI/MCP absolute-path admission contract and preserve the caller-selected manifest spelling, capture metadata, URLs, and source identities.

Verification: 19 focused filesystem, CLI/MCP, schema, and Windows-lane regressions passed. The two new path regressions failed on the original implementation; they now cover real directories with spaces, host path spellings, and retained tamper rejection. Source-location parity uses the actual compiled stdio MCP server and owned source-map codec. npm run check, npm run docs:generate, npm run docs:check, and test discovery passed. After rebasing onto current main, the combined setup/path/CLI/MCP lane passed seven tests with one Windows-only case skipped locally, plus static and generated-document checks. Native Windows CI includes both real CLI/MCP journeys and the filesystem regressions. No real Hopper/Ghidra verification is applicable; no browser execution is claimed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1078 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/windows-web-script-paths` --- ### 📝 Commits (2) - [`d6cb22b`](https://github.com/morluto/rea/commit/d6cb22bdd4fe31cde73f4f42753fcf6bf3a531a5) fix(browser): normalize selected script manifest roots on Windows - [`c4af466`](https://github.com/morluto/rea/commit/c4af4667fc9451c2c4f552e5d31ccbeb0e469025) test(browser): keep manifest fixtures valid across Windows drives ### 📊 Changes **5 files changed** (+125 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+3 -0) 📝 `src/browser/assets/LocalWebScriptArtifacts.ts` (+2 -2) 📝 `tests/acceptance/webModuleCli.test.ts` (+1 -1) 📝 `tests/acceptance/webSourceLocationCli.test.ts` (+42 -2) ➕ `tests/boundary/filesystem/webScriptManifestPaths.test.ts` (+77 -0) </details> ### 📄 Description Fixes #1067. Normalize the selected manifest's host directory before joining and walking its source paths. Windows forward-slash drive paths now reach the same containment boundary as native paths; provider reads also terminate correctly for dot segments and relative roots. Keep the shared CLI/MCP absolute-path admission contract and preserve the caller-selected manifest spelling, capture metadata, URLs, and source identities. Verification: 19 focused filesystem, CLI/MCP, schema, and Windows-lane regressions passed. The two new path regressions failed on the original implementation; they now cover real directories with spaces, host path spellings, and retained tamper rejection. Source-location parity uses the actual compiled stdio MCP server and owned source-map codec. `npm run check`, `npm run docs:generate`, `npm run docs:check`, and test discovery passed. After rebasing onto current main, the combined setup/path/CLI/MCP lane passed seven tests with one Windows-only case skipped locally, plus static and generated-document checks. Native Windows CI includes both real CLI/MCP journeys and the filesystem regressions. No real Hopper/Ghidra verification is applicable; no browser execution is claimed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:08:22 +00:00