[PR #1086] [MERGED] fix(build): make catalogs and packaged skills generated outputs #2634

New issue

Closed

opened 2026-10-17 21:08:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:08:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1086
Author: @morluto
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @morluto

Base: main ← Head: fix/generated-output-ownership

📝 Commits (3)

4c2722c fix(build): generate catalogs and packaged skills without snapshot commits
39e3a4f fix(build): point skill drift recovery to uncached generation
fc01256 chore: integrate main and preserve canonical skill bundle identity

📊 Changes

41 files changed (+363 additions, -1219 deletions)

View changed files

📝 .github/pull_request_template.md (+1 -1)
📝 .github/workflows/ci.yml (+10 -0)
➖ .github/workflows/regen-generated.yml (+0 -75)
📝 .github/workflows/release.yml (+2 -36)
📝 .gitignore (+8 -0)
📝 AGENTS.md (+2 -2)
📝 CONTRIBUTING.md (+16 -9)
📝 README.md (+2 -2)
📝 docs/binary-diagnostics.md (+1 -1)
📝 docs/evm-bytecode.md (+1 -1)
📝 docs/installation.md (+1 -1)
📝 docs/managed-code-analysis.md (+1 -1)
📝 docs/mcp-contracts.md (+10 -0)
➖ docs/product-catalog.json (+0 -719)
📝 docs/releasing.md (+8 -5)
➖ docs/verification/managed-conformance-ledger.json (+0 -105)
➖ docs/verification/managed-conformance-manifest.json (+0 -201)
📝 package.json (+3 -1)
📝 release-please-config.json (+0 -5)
📝 scripts/generate-completion-ledger.mjs (+1 -1)

...and 21 more files

📄 Description

Fixes #1076. Builds on the now-merged #1075.

Problem

Parallel contract changes repeatedly update the same tracked catalog and skill metadata. The regeneration workflow pushes those derived edits onto feature branches, creating a recurring conflict cycle across #947, #936, and #934.

Changes

Move authored skill instructions and references to skill-src/. Build the distributable skills/ bundle with current inventory metadata while preserving #1075's canonical-bundle identity checks and omission of aggregate schema hashes.
Generate the product catalog at docs/public/product-catalog.json and portable managed-conformance projections under docs/verification/; stop tracking these build outputs. The conformance manifest still commits to the exact generated skill bytes installed by setup.
Include every generated output and its source inputs in the build cache. Missing outputs are restored on cache hits; drift checks reject stale, missing, or extra skill files, and explicit regeneration removes deleted references.
Remove feature-branch generated-file auto-push automation. PR CI validates generated outputs, requires a clean tracked tree, and retains the outputs as artifacts.
Generate the catalog before documentation development/build and serve it as a static asset. Update source links and correct two existing cross-tree documentation links exposed by the website build.
Release preparation validates derived documentation from the exact candidate checkout rather than committing another catalog snapshot. Tracked source versions remain bound to the immutable checkpoint.

Boundary impact

This changes source/build ownership and contributor paths. The npm skill path remains skills/reverse-engineer-anything; runtime CLI/MCP catalog identity and installed-skill diagnostics are preserved. Portable conformance projections remain distinct from optional real-provider verification records.

Verification

115 focused tests passed across generator, skill installation/doctor, product catalog, release checkpoint/workflow, dependency installation, and live MCP identity suites.
npm run docs:check — passed.
npm run docs:build — passed; confirmed the generated catalog is copied into the built site.
npm run check and the pre-push npm run check:fast — passed.
npm run verify:package — passed after integrating current main, including actual tarball installation, setup/doctor, CLI/MCP, and skill/reference checks. The tarball verifier checks generated inventory metadata and excludes authored skill sources.
npm pack --dry-run --json — passed.
npm run verify:test-discovery — passed.
Fresh detached worktree: npm ci, an uncached npm run build, npm run docs:check:built, and git diff --exit-code passed.
Deleted generated skill/catalog/conformance outputs and verified a cached build restores them.

Real Hopper/Ghidra verification was not performed; this PR changes build and publication ownership, and makes no new provider-runtime claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1086 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/generated-output-ownership` --- ### 📝 Commits (3) - [`4c2722c`](https://github.com/morluto/rea/commit/4c2722cf6d50e2003edf8ada94bd1bb42f4c657b) fix(build): generate catalogs and packaged skills without snapshot commits - [`39e3a4f`](https://github.com/morluto/rea/commit/39e3a4fc8e3e8f40cef9d2eb2932b34e651beabb) fix(build): point skill drift recovery to uncached generation - [`fc01256`](https://github.com/morluto/rea/commit/fc01256bd1d99e3c40e45b29154b307dae2cb1f9) chore: integrate main and preserve canonical skill bundle identity ### 📊 Changes **41 files changed** (+363 additions, -1219 deletions) <details> <summary>View changed files</summary> 📝 `.github/pull_request_template.md` (+1 -1) 📝 `.github/workflows/ci.yml` (+10 -0) ➖ `.github/workflows/regen-generated.yml` (+0 -75) 📝 `.github/workflows/release.yml` (+2 -36) 📝 `.gitignore` (+8 -0) 📝 `AGENTS.md` (+2 -2) 📝 `CONTRIBUTING.md` (+16 -9) 📝 `README.md` (+2 -2) 📝 `docs/binary-diagnostics.md` (+1 -1) 📝 `docs/evm-bytecode.md` (+1 -1) 📝 `docs/installation.md` (+1 -1) 📝 `docs/managed-code-analysis.md` (+1 -1) 📝 `docs/mcp-contracts.md` (+10 -0) ➖ `docs/product-catalog.json` (+0 -719) 📝 `docs/releasing.md` (+8 -5) ➖ `docs/verification/managed-conformance-ledger.json` (+0 -105) ➖ `docs/verification/managed-conformance-manifest.json` (+0 -201) 📝 `package.json` (+3 -1) 📝 `release-please-config.json` (+0 -5) 📝 `scripts/generate-completion-ledger.mjs` (+1 -1) _...and 21 more files_ </details> ### 📄 Description Fixes #1076. Builds on the now-merged #1075. ## Problem Parallel contract changes repeatedly update the same tracked catalog and skill metadata. The regeneration workflow pushes those derived edits onto feature branches, creating a recurring conflict cycle across #947, #936, and #934. ## Changes - Move authored skill instructions and references to `skill-src/`. Build the distributable `skills/` bundle with current inventory metadata while preserving #1075's canonical-bundle identity checks and omission of aggregate schema hashes. - Generate the product catalog at `docs/public/product-catalog.json` and portable managed-conformance projections under `docs/verification/`; stop tracking these build outputs. The conformance manifest still commits to the exact generated skill bytes installed by setup. - Include every generated output and its source inputs in the build cache. Missing outputs are restored on cache hits; drift checks reject stale, missing, or extra skill files, and explicit regeneration removes deleted references. - Remove feature-branch generated-file auto-push automation. PR CI validates generated outputs, requires a clean tracked tree, and retains the outputs as artifacts. - Generate the catalog before documentation development/build and serve it as a static asset. Update source links and correct two existing cross-tree documentation links exposed by the website build. - Release preparation validates derived documentation from the exact candidate checkout rather than committing another catalog snapshot. Tracked source versions remain bound to the immutable checkpoint. ## Boundary impact This changes source/build ownership and contributor paths. The npm skill path remains `skills/reverse-engineer-anything`; runtime CLI/MCP catalog identity and installed-skill diagnostics are preserved. Portable conformance projections remain distinct from optional real-provider verification records. ## Verification - 115 focused tests passed across generator, skill installation/doctor, product catalog, release checkpoint/workflow, dependency installation, and live MCP identity suites. - `npm run docs:check` — passed. - `npm run docs:build` — passed; confirmed the generated catalog is copied into the built site. - `npm run check` and the pre-push `npm run check:fast` — passed. - `npm run verify:package` — passed after integrating current main, including actual tarball installation, setup/doctor, CLI/MCP, and skill/reference checks. The tarball verifier checks generated inventory metadata and excludes authored skill sources. - `npm pack --dry-run --json` — passed. - `npm run verify:test-discovery` — passed. - Fresh detached worktree: `npm ci`, an uncached `npm run build`, `npm run docs:check:built`, and `git diff --exit-code` passed. - Deleted generated skill/catalog/conformance outputs and verified a cached build restores them. Real Hopper/Ghidra verification was not performed; this PR changes build and publication ownership, and makes no new provider-runtime claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:08:26 +00:00