[PR #1087] [MERGED] fix(javascript): retain NodeNext artifact source facts #2635

New issue

Closed

opened 2026-10-17 21:08:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:08:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1087
Author: @rudycelekli
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @N0zoM1z0

Base: main ← Head: validation/nodenext-artifact-selection-20261008

📝 Commits (4)

ef8726b test(javascript): reproduce omitted NodeNext artifact sources
26c8eed fix(javascript): retain NodeNext artifact source facts
9e2ead4 Merge branch 'main' into validation/nodenext-artifact-selection-20261008
f3ab9fd chore: integrate source coordinate fixes with NodeNext artifact coverage

📊 Changes

4 files changed (+103 additions, -1 deletions)

View changed files

📝 docs/javascript-artifact-reconstruction.md (+4 -0)
📝 src/artifacts/javascript/JavaScriptArtifactFiles.ts (+1 -1)
📝 tests/boundary/cli/javascriptApplicationProgress.test.ts (+34 -0)
📝 tests/composition/javascript-applications/javascriptArtifactReconstruction.test.ts (+64 -0)

📄 Description

Selected .mts and .cts files were silently omitted from directory and ASAR JavaScript artifact analysis even though the existing inert TypeScript parser accepts their contents. Include those suffixes in artifact selection so both public CLI analysis commands retain their source facts, exact digests and byte counts. Document the supported source suffixes.

Validation:

Tests-only before run reproduced eight Linux failures through actual directory/ASAR reconstruction and the built CLI, plus four Windows composition failures; ten existing suffix controls passed. Before reproduction.
All 18 added regression/control owners pass individually after the fix. Full deterministic aggregate: 4,970 passed, zero failed, 47 skipped (5,017 total).
All 22 unchanged fork CI jobs passed at 26c8eedb790b4a28d6cc1d0b682944180869d62e, including static/docs checks, four coverage shards and aggregate, Windows capability/package tests, Apple artifact tests, native Linux and macOS package baselines, and real Node Inspector observation. Fix qualification CI.
The unchanged upstream source baseline also passed. Baseline CI.

The tests use synthetic fixture inputs and preserve parse-without-execution behavior and existing source identities. No private input or credentials are included. Workflows and dependencies are unchanged. Real Hopper/Ghidra verification was not performed; their providers are unaffected.

Both commits are GitHub verified and carry Signed-off-by trailers.

Current upstream integration status:

The earlier newer-main CI reproduced five existing generated-output failures independently of this change. Attribution control. Separately owned #1091 is now merged as 5f93b4b125e78f088a2349a178e60f8c0af3e1a2.
This branch now includes that accepted main through GitHub verified merge head 9e2ead435cd7095e81bdb7772a5c1d912730e6f0, preserving the original signed fix and frozen owners. Current exact-head CI is pending; the historical green qualification above does not imply this new integration is green.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1087 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `validation/nodenext-artifact-selection-20261008` --- ### 📝 Commits (4) - [`ef8726b`](https://github.com/morluto/rea/commit/ef8726b9029401b21b90dcbed905680f62d5dc82) test(javascript): reproduce omitted NodeNext artifact sources - [`26c8eed`](https://github.com/morluto/rea/commit/26c8eedb790b4a28d6cc1d0b682944180869d62e) fix(javascript): retain NodeNext artifact source facts - [`9e2ead4`](https://github.com/morluto/rea/commit/9e2ead435cd7095e81bdb7772a5c1d912730e6f0) Merge branch 'main' into validation/nodenext-artifact-selection-20261008 - [`f3ab9fd`](https://github.com/morluto/rea/commit/f3ab9fd9091eaae88d55047883964a291952c725) chore: integrate source coordinate fixes with NodeNext artifact coverage ### 📊 Changes **4 files changed** (+103 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/javascript-artifact-reconstruction.md` (+4 -0) 📝 `src/artifacts/javascript/JavaScriptArtifactFiles.ts` (+1 -1) 📝 `tests/boundary/cli/javascriptApplicationProgress.test.ts` (+34 -0) 📝 `tests/composition/javascript-applications/javascriptArtifactReconstruction.test.ts` (+64 -0) </details> ### 📄 Description Selected `.mts` and `.cts` files were silently omitted from directory and ASAR JavaScript artifact analysis even though the existing inert TypeScript parser accepts their contents. Include those suffixes in artifact selection so both public CLI analysis commands retain their source facts, exact digests and byte counts. Document the supported source suffixes. Validation: - Tests-only before run reproduced eight Linux failures through actual directory/ASAR reconstruction and the built CLI, plus four Windows composition failures; ten existing suffix controls passed. [Before reproduction](https://github.com/rudycelekli/rea/actions/runs/37790373264). - All 18 added regression/control owners pass individually after the fix. Full deterministic aggregate: 4,970 passed, zero failed, 47 skipped (5,017 total). - All 22 unchanged fork CI jobs passed at `26c8eedb790b4a28d6cc1d0b682944180869d62e`, including static/docs checks, four coverage shards and aggregate, Windows capability/package tests, Apple artifact tests, native Linux and macOS package baselines, and real Node Inspector observation. [Fix qualification CI](https://github.com/rudycelekli/rea/actions/runs/37792544329). - The unchanged upstream source baseline also passed. [Baseline CI](https://github.com/rudycelekli/rea/actions/runs/37790333223). The tests use synthetic fixture inputs and preserve parse-without-execution behavior and existing source identities. No private input or credentials are included. Workflows and dependencies are unchanged. Real Hopper/Ghidra verification was not performed; their providers are unaffected. Both commits are GitHub verified and carry Signed-off-by trailers. Current upstream integration status: - The earlier newer-main CI reproduced five existing generated-output failures independently of this change. [Attribution control](https://github.com/rudycelekli/rea/actions/runs/37795715138). Separately owned #1091 is now merged as `5f93b4b125e78f088a2349a178e60f8c0af3e1a2`. - This branch now includes that accepted main through GitHub verified merge head `9e2ead435cd7095e81bdb7772a5c1d912730e6f0`, preserving the original signed fix and frozen owners. [Current exact-head CI](https://github.com/morluto/rea/actions/runs/37801166315) is pending; the historical green qualification above does not imply this new integration is green. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:08:28 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:05:32 +00:00

[PR #2635] [MERGED] test(javascript): verify Windows path case and load scope #5298

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2635

No description provided.

Rows
Columns