[PR #1091] [MERGED] fix(ci): restore generated shard inputs and cleanup assertions #2639

New issue

Closed

opened 2026-10-17 21:08:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:08:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1091
Author: @N0zoM1z0
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/ci-generated-artifacts

📝 Commits (1)

ff7ec0d fix(ci): restore generated shard inputs and cleanup assertions

📊 Changes

2 files changed (+17 additions, -4 deletions)

View changed files

📝 .github/workflows/ci.yml (+6 -2)
📝 tests/boundary/process/processCaptureLifecycle.test.ts (+11 -2)

📄 Description

Test shards download only dist/. Since #1086 moved catalog, skill, and portable conformance files to ignored build outputs, shards must regenerate those inputs before testing. Restore all four generation steps from the downloaded build without recompiling TypeScript or committing snapshots.

The native macOS timeout test also rejected the optional cleanup.unverified_processes introduced by #1057. Keep asserting that the owned group is verified and the temporary root removed; additionally require every reported unrelated process to remain visible in residual unknowns.

Validation:

Removed the owned generated outputs and ran the old shard preparation: reproduced all five catalog/skill failures from #1087/#1089.
Ran the new preparation and five focused suites: 42 tests passed, covering catalog, generated skill, installation/doctor, real local process lifecycle, and deterministic withheld-process cleanup.
npm run check and npm run docs:check passed.
No production provider behavior changes. Native macOS lifecycle acceptance runs in CI; real Hopper/Ghidra verification was not performed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1091 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/ci-generated-artifacts` --- ### 📝 Commits (1) - [`ff7ec0d`](https://github.com/morluto/rea/commit/ff7ec0dd54012f569063bbd7b95b4c3b155f6a0f) fix(ci): restore generated shard inputs and cleanup assertions ### 📊 Changes **2 files changed** (+17 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+6 -2) 📝 `tests/boundary/process/processCaptureLifecycle.test.ts` (+11 -2) </details> ### 📄 Description Test shards download only `dist/`. Since #1086 moved catalog, skill, and portable conformance files to ignored build outputs, shards must regenerate those inputs before testing. Restore all four generation steps from the downloaded build without recompiling TypeScript or committing snapshots. The native macOS timeout test also rejected the optional `cleanup.unverified_processes` introduced by #1057. Keep asserting that the owned group is verified and the temporary root removed; additionally require every reported unrelated process to remain visible in residual unknowns. Validation: - Removed the owned generated outputs and ran the old shard preparation: reproduced all five catalog/skill failures from #1087/#1089. - Ran the new preparation and five focused suites: 42 tests passed, covering catalog, generated skill, installation/doctor, real local process lifecycle, and deterministic withheld-process cleanup. - `npm run check` and `npm run docs:check` passed. - No production provider behavior changes. Native macOS lifecycle acceptance runs in CI; real Hopper/Ghidra verification was not performed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:08:29 +00:00