[PR #1103] [MERGED] fix(artifacts): retain failed DMG cleanup state and diagnostics #2651

New issue

Closed

opened 2026-10-17 21:08:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:08:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1103
Author: @N0zoM1z0
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/dmg-cleanup-diagnostics

📝 Commits (1)

df4ce00 fix(artifacts): retain failed DMG cleanup state and diagnostics

📊 Changes

2 files changed (+101 additions, -10 deletions)

View changed files

📝 src/artifacts/NativeDmgArtifactReader.ts (+17 -6)
📝 tests/boundary/providers/native/nativeDmgArtifactReader.test.ts (+84 -4)

📄 Description

A failed native DMG detach discarded the owned device list and attempted to remove the mount root. A later close() could then report success while the image was still attached. Native CI also lost the actual command failure behind a generic cleanup message.

Retain devices whose attachment is confirmed or unknown, remove the mount root only after detach, and preserve the image path and captured native diagnostics. A later close can retry the remaining owned cleanup. Attach failures retain both the original and cleanup reasons.

Validation: two regression cases failed before the fix, including lost diagnostics, premature mount-root removal and false cleanup success. The focused suite now passes 9 portable tests; 3 native macOS cases were skipped locally and remain required in CI. Build and pre-push static checks pass. The original CI detach failure's underlying cause remains unknown. No Hopper/Ghidra behavior or verification claim changes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1103 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/dmg-cleanup-diagnostics` --- ### 📝 Commits (1) - [`df4ce00`](https://github.com/morluto/rea/commit/df4ce00c89cfce0457a0cc93263a0a5607999e60) fix(artifacts): retain failed DMG cleanup state and diagnostics ### 📊 Changes **2 files changed** (+101 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/artifacts/NativeDmgArtifactReader.ts` (+17 -6) 📝 `tests/boundary/providers/native/nativeDmgArtifactReader.test.ts` (+84 -4) </details> ### 📄 Description A failed native DMG detach discarded the owned device list and attempted to remove the mount root. A later `close()` could then report success while the image was still attached. Native CI also lost the actual command failure behind a generic cleanup message. Retain devices whose attachment is confirmed or unknown, remove the mount root only after detach, and preserve the image path and captured native diagnostics. A later close can retry the remaining owned cleanup. Attach failures retain both the original and cleanup reasons. Validation: two regression cases failed before the fix, including lost diagnostics, premature mount-root removal and false cleanup success. The focused suite now passes 9 portable tests; 3 native macOS cases were skipped locally and remain required in CI. Build and pre-push static checks pass. The original CI detach failure's underlying cause remains unknown. No Hopper/Ghidra behavior or verification claim changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:08:39 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:07:02 +00:00

[PR #2907] [CLOSED] fix(reference): reconcile excluded symlink identities #5488

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2651

No description provided.

Rows
Columns