[PR #1110] [MERGED] fix(apple): classify empty dyld settings by consumer semantics #2658

New issue

Closed

opened 2026-10-17 21:08:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:08:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1110
Author: @morluto
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @morluto

Base: main ← Head: codex/dyld-empty-setting-semantics

📝 Commits (1)

7980cb9 fix(apple): classify empty dyld settings by consumer semantics

📊 Changes

8 files changed (+474 additions, -11 deletions)

View changed files

📝 docs/apple-application-analysis.md (+8 -0)
📝 docs/testing.md (+6 -0)
➕ scripts/verify/apple/dyld-environment.mjs (+223 -0)
📝 scripts/verify/apple/macos-bundle.mjs (+3 -0)
📝 src/domain/apple/dyldEnvironment.ts (+12 -11)
📝 src/domain/apple/dylibResolution.test.ts (+127 -0)
📝 tests/boundary/cli/dylibResolutionCli.test.ts (+43 -0)
📝 tests/boundary/mcp/dylibResolutionMcp.test.ts (+52 -0)

📄 Description

Empty versioned-directory lists and suffix lists containing only empty entries were making dylib resolution conditional or undetermined despite adding no candidates. Classify empty values in the setting-specific consumer logic, preserving the reported commands in the result.

Retain uncertainty for empty ordinary/fallback directory entries: current dyld appends a slash and image name, producing filesystem-root candidates. Real macOS diagnostics contradict the empty-fallback review finding on #1100; see Apple's path construction. Whitespace remains a real value rather than being trimmed.

Follow-up to #1100. Add domain and CLI/MCP coverage and retain ten real embedded-setting cases in the existing macOS bundle CI lane, each checked with its dependency present and removed. Caller-visible schemas are unchanged.

Validation:

npm run check
npm run docs:check
npm run test:focused -- src/domain/apple/dylibResolution.test.ts src/artifacts/apple/MachoLoadCommandReader.test.ts tests/boundary/cli/dylibResolutionCli.test.ts tests/boundary/mcp/dylibResolutionMcp.test.ts — 120 passed.
npm run verify:macos-bundle — real macOS arm64 directory/ZIP/DMG lane passed, including 20 embedded-setting dependency states, real dyld diagnostics, and CLI/MCP agreement.

Hopper/Ghidra verification was not performed; this change uses neither provider.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1110 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/dyld-empty-setting-semantics` --- ### 📝 Commits (1) - [`7980cb9`](https://github.com/morluto/rea/commit/7980cb98aa62b48cba4efc1b22b340c7bb882b3c) fix(apple): classify empty dyld settings by consumer semantics ### 📊 Changes **8 files changed** (+474 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `docs/apple-application-analysis.md` (+8 -0) 📝 `docs/testing.md` (+6 -0) ➕ `scripts/verify/apple/dyld-environment.mjs` (+223 -0) 📝 `scripts/verify/apple/macos-bundle.mjs` (+3 -0) 📝 `src/domain/apple/dyldEnvironment.ts` (+12 -11) 📝 `src/domain/apple/dylibResolution.test.ts` (+127 -0) 📝 `tests/boundary/cli/dylibResolutionCli.test.ts` (+43 -0) 📝 `tests/boundary/mcp/dylibResolutionMcp.test.ts` (+52 -0) </details> ### 📄 Description Empty versioned-directory lists and suffix lists containing only empty entries were making dylib resolution conditional or undetermined despite adding no candidates. Classify empty values in the setting-specific consumer logic, preserving the reported commands in the result. Retain uncertainty for empty ordinary/fallback directory entries: current dyld appends a slash and image name, producing filesystem-root candidates. Real macOS diagnostics contradict the empty-fallback review finding on #1100; see [Apple's path construction](https://github.com/apple-oss-distributions/dyld/blob/main/dyld/DyldProcessConfig.cpp). Whitespace remains a real value rather than being trimmed. Follow-up to #1100. Add domain and CLI/MCP coverage and retain ten real embedded-setting cases in the existing macOS bundle CI lane, each checked with its dependency present and removed. Caller-visible schemas are unchanged. Validation: - `npm run check` - `npm run docs:check` - `npm run test:focused -- src/domain/apple/dylibResolution.test.ts src/artifacts/apple/MachoLoadCommandReader.test.ts tests/boundary/cli/dylibResolutionCli.test.ts tests/boundary/mcp/dylibResolutionMcp.test.ts` — 120 passed. - `npm run verify:macos-bundle` — real macOS arm64 directory/ZIP/DMG lane passed, including 20 embedded-setting dependency states, real dyld diagnostics, and CLI/MCP agreement. Hopper/Ghidra verification was not performed; this change uses neither provider. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:08:43 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2658

No description provided.

Rows
Columns