[PR #1294] [MERGED] test(process): check malformed capture choices concurrently #2774

New issue

Closed

opened 2026-10-17 21:10:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:10:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1294
Author: @kaoru0822-kitauji
Created: 10/9/2026
Status: ✅ Merged
Merged: 10/9/2026
Merged by: @kaoru0822-kitauji

Base: main ← Head: test/process-contract-rejections-concurrent

📝 Commits (1)

48de11c test(process): check malformed capture choices concurrently

📊 Changes

1 file changed (+20 additions, -15 deletions)

View changed files

📝 tests/acceptance/tools/localToolContracts.test.ts (+20 -15)

📄 Description

Summary

tests/acceptance/tools/localToolContracts.test.ts › "rejects malformed process choices through CLI and MCP before launching the command" runs 26 malformed scenarios. Each spawns a fresh rea capture-process CLI process, sequentially, under a 60 s deadline. On CI's Test shard (4/4) it takes 45–59 s when it passes (#1289: 44.9 s, #1286: 58.8 s, #1292: 58.9 s), and it timed out at 60 s on #1288 and #1291, whose changes don't touch process-choice validation.

Change

Run the independent cases concurrently with Promise.all, each writing its own scenario-N.json. The MCP rejection check, the CLI exit code and invalid_request check, the "command was never launched" marker check and the missing-executable checks are all unchanged. CLI expectations now carry the case's options as the assertion message, so a failure still names its case.

Verification

npm run build:cached && npm run test:focused -- tests/acceptance/tools/localToolContracts.test.ts: all 5 pass; this case goes from 13.9 s to 6.2 s locally (macOS arm64).

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1294 **Author:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Created:** 10/9/2026 **Status:** ✅ Merged **Merged:** 10/9/2026 **Merged by:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Base:** `main` ← **Head:** `test/process-contract-rejections-concurrent` --- ### 📝 Commits (1) - [`48de11c`](https://github.com/morluto/rea/commit/48de11ce2e5af9810fc97d1c2f89df56bf3a3d4d) test(process): check malformed capture choices concurrently ### 📊 Changes **1 file changed** (+20 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `tests/acceptance/tools/localToolContracts.test.ts` (+20 -15) </details> ### 📄 Description ## Summary `tests/acceptance/tools/localToolContracts.test.ts` › "rejects malformed process choices through CLI and MCP before launching the command" runs 26 malformed scenarios. Each spawns a fresh `rea capture-process` CLI process, sequentially, under a 60 s deadline. On CI's `Test shard (4/4)` it takes 45–59 s when it passes (#1289: 44.9 s, #1286: 58.8 s, #1292: 58.9 s), and it timed out at 60 s on #1288 and #1291, whose changes don't touch process-choice validation. ## Change Run the independent cases concurrently with `Promise.all`, each writing its own `scenario-N.json`. The MCP rejection check, the CLI exit code and `invalid_request` check, the "command was never launched" marker check and the missing-executable checks are all unchanged. CLI expectations now carry the case's options as the assertion message, so a failure still names its case. ## Verification - `npm run build:cached && npm run test:focused -- tests/acceptance/tools/localToolContracts.test.ts`: all 5 pass; this case goes from 13.9 s to 6.2 s locally (macOS arm64). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:10:04 +00:00