[PR #1300] [MERGED] test(apple): verify compiled Mach-O root occurrence facts #2781

New issue

Closed

opened 2026-10-17 21:10:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:10:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1300
Author: @N0zoM1z0
Created: 10/9/2026
Status: ✅ Merged
Merged: 10/9/2026
Merged by: @N0zoM1z0

Base: main ← Head: test/macho-root-occurrence

📝 Commits (1)

7967532 test(artifacts): verify compiled Mach-O roles and permissions

📊 Changes

2 files changed (+90 additions, -1 deletions)

View changed files

➕ scripts/verify/apple/macho-occurrences.mjs (+86 -0)
📝 scripts/verify/apple/macos-bundle.mjs (+4 -1)

📄 Description

Protect the Mach-O root classification and permission fix already on main in 63bf9140. A direct Mach-O and the identical contained file must both have the executable artifact role, while filesystem execution permission reflects the selected mode independently.

Closes #1235. Complements #1298's portable header/projection regressions with real compiler output and the public macOS artifact workflow.

Extend the existing real macOS bundle verifier with its actual compiler-produced executable in modes 755 and 644. Check direct CLI versus contained CLI classification/content identity and contained CLI/stdio MCP parity; verify byte content is unchanged and restore the original mode in finally. The existing fixture and prerequisites are reused.

Validation:

Existing content/occurrence source regressions: all three pass locally on Linux. npm run check:fast passes both tasks.
Real macOS CI passed on exact head 79675321decc8cc4eb30076c4c37537cae3f3d67: compiler-produced Mach-O retains its content identity and executable role at modes 755 and 644; the permission flag changes independently. Direct CLI and contained CLI/stdio MCP agree, target bytes stay identical, and the directory/ZIP/DMG and dyld workflows also pass. Real Apple job.
This adds verification coverage; production schemas and provider behavior were already repaired by the linked main commit.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1300 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/9/2026 **Status:** ✅ Merged **Merged:** 10/9/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `test/macho-root-occurrence` --- ### 📝 Commits (1) - [`7967532`](https://github.com/morluto/rea/commit/79675321decc8cc4eb30076c4c37537cae3f3d67) test(artifacts): verify compiled Mach-O roles and permissions ### 📊 Changes **2 files changed** (+90 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `scripts/verify/apple/macho-occurrences.mjs` (+86 -0) 📝 `scripts/verify/apple/macos-bundle.mjs` (+4 -1) </details> ### 📄 Description Protect the Mach-O root classification and permission fix already on main in [63bf9140](https://github.com/morluto/rea/commit/63bf91405cf97b114a84f337fb1272d98a267999). A direct Mach-O and the identical contained file must both have the executable artifact role, while filesystem execution permission reflects the selected mode independently. Closes #1235. Complements #1298's portable header/projection regressions with real compiler output and the public macOS artifact workflow. Extend the existing real macOS bundle verifier with its actual compiler-produced executable in modes `755` and `644`. Check direct CLI versus contained CLI classification/content identity and contained CLI/stdio MCP parity; verify byte content is unchanged and restore the original mode in `finally`. The existing fixture and prerequisites are reused. Validation: - Existing content/occurrence source regressions: all three pass locally on Linux. `npm run check:fast` passes both tasks. - Real macOS CI passed on exact head `79675321decc8cc4eb30076c4c37537cae3f3d67`: compiler-produced Mach-O retains its content identity and executable role at modes 755 and 644; the permission flag changes independently. Direct CLI and contained CLI/stdio MCP agree, target bytes stay identical, and the directory/ZIP/DMG and dyld workflows also pass. [Real Apple job](https://github.com/morluto/rea/actions/runs/37949184641/job/113883301601). - This adds verification coverage; production schemas and provider behavior were already repaired by the linked main commit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:10:10 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:06:15 +00:00

[PR #2781] [MERGED] fix(javascript): recover child-process options without args #5388

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2781

No description provided.

Rows
Columns